[element model] migrate use_setters_to_change_properties

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I456c6e950c745f5f41bfba5d131e991d2435f713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394385
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -11,9 +11,7 @@ lib/src/rules/prefer_initializing_formals.dart
 lib/src/rules/public_member_api_docs.dart
 lib/src/rules/unnecessary_overrides.dart
 lib/src/rules/use_build_context_synchronously.dart
-lib/src/rules/use_key_in_widget_constructors.dart
 lib/src/rules/use_late_for_private_fields_and_variables.dart
-lib/src/rules/use_setters_to_change_properties.dart
 lib/src/util/dart_type_utilities.dart
 lib/src/util/flutter_utils.dart
 lib/src/util/leak_detector_visitor.dart

pkg/linter/lib/src/extensions.dart

@@ -371,6 +371,12 @@ extension ElementExtension on Element {
 }
 
 extension ElementExtension2 on Element2? {
+  Element2? get canonicalElement2 => switch (this) {
+        GetterElement(:var variable3) => variable3,
+        SetterElement(:var variable3) => variable3,
+        _ => this,
+      };
+
   bool get isDartCorePrint {
     var self = this;
     return self is TopLevelFunctionElement &&

pkg/linter/lib/src/rules/use_setters_to_change_properties.dart

@@ -5,7 +5,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 
 import '../analyzer.dart';
@@ -50,10 +50,11 @@ class _Visitor extends SimpleAstVisitor<void> {
     void checkExpression(Expression expression) {
       if (expression is AssignmentExpression &&
           expression.operator.type == TokenType.EQ) {
-        var leftOperand = expression.writeElement?.canonicalElement;
-        var rightOperand = expression.rightHandSide.canonicalElement;
-        var parameterElement = node.declaredElement?.parameters.first;
-        if (rightOperand == parameterElement && leftOperand is FieldElement) {
+        var leftOperand = expression.writeElement2?.canonicalElement2;
+        var rightOperand = expression.rightHandSide.canonicalElement2;
+        var parameterElement =
+            node.declaredFragment?.element.formalParameters.first;
+        if (rightOperand == parameterElement && leftOperand is FieldElement2) {
           rule.reportLintForToken(node.name);
         }
       }