Skip to content

Commit 073a700

Browse files
aamCommit Queue
authored andcommitted
[build/win] Roll crashpad and minichromium deps.
Roll not to the lastest, but to the one before move to breaking c++20 changes in those deps. Pulls changes and fixes to crashpad from 10/22/2018 to 1/10/2024. TEST=ci Change-Id: I1ff37eaec91ea6b1fb3d73b38b360b2e8d88a47c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393903 Commit-Queue: Alexander Aprelev <[email protected]> Reviewed-by: Siva Annamalai <[email protected]>
1 parent a31939c commit 073a700

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

DEPS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@ vars = {
176176
"yaml_edit_rev": "3d1421b928ec62cf866ec3487940e560852c5c3b",
177177

178178
# Windows deps
179-
"crashpad_rev": "bf327d8ceb6a669607b0dbab5a83a275d03f99ed",
180-
"minichromium_rev": "8d641e30a8b12088649606b912c2bc4947419ccc",
179+
"crashpad_rev": "d256de317164c0eb362bdd9cbb4d259fe6d086f3",
180+
"minichromium_rev": "203a01130fac64bfdcc8cab2e1798c7b2c0619bf",
181181
"googletest_rev": "f854f1d27488996dc8a6db3c9453f80b02585e12",
182182

183183
# Pinned browser versions used by the testing infrastructure. These are not

build/config/BUILDCONFIG.gn

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,9 @@ if (is_win) {
374374
set_defaults("shared_library") {
375375
configs = _shared_library_configs
376376
}
377+
set_defaults("loadable_module") {
378+
configs = _shared_library_configs
379+
}
377380

378381
# Source set defaults (also for components in non-component mode).
379382
set_defaults("source_set") {

build/config/win/BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ config("sdk") {
1414
"_ATL_NO_OPENGL",
1515
"_WINDOWS",
1616
"CERT_CHAIN_PARA_HAS_EXTRA_FIELDS",
17-
"NTDDI_VERSION=0x06030000",
17+
"NTDDI_VERSION=0x0A000006",
1818
"PSAPI_VERSION=1",
1919
"WIN32",
2020
"_SECURE_ATL",

0 commit comments

Comments
 (0)