analyzer_plugin: support library_private_types_in_public_api lint rule

Luckily, the two cases which were reported could both be remedied by
making more things private.

* `DartFileEditBuilderImpl.librariesToImport` exposed `_LibraryImport`,
  but could be made private anyhow. Also, it's package-private code,
  so this is not a breaking change.
* `CodegenVisitor.generateConstant` accepted a private type as an
  argument, but the whole class can be made private.

Change-Id: I8613812385ed0e9a7e36922d86889dad4cedf3cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428924
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analyzer_plugin/analysis_options.yaml

@@ -9,8 +9,6 @@ analyzer:
     constant_identifier_names: ignore
     implementation_imports: ignore
     non_constant_identifier_names: ignore
-    # Existing violations (3)
-    library_private_types_in_public_api: ignore
     # Existing violations (194)
     unintended_html_in_doc_comment: ignore
 

pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart

@@ -1449,7 +1449,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
 
   /// A mapping from libraries that need to be imported in order to make visible
   /// the names used in generated code, to information about these imports.
-  Map<Uri, _LibraryImport> librariesToImport = {};
+  final Map<Uri, _LibraryImport> _librariesToImport = {};
 
   /// A mapping of elements to pending imports that will be added to make them
   /// visible in the generated code.
@@ -1472,10 +1472,10 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
 
   @override
   bool get hasEdits =>
-      super.hasEdits || librariesToImport.isNotEmpty || fileHeader != null;
+      super.hasEdits || _librariesToImport.isNotEmpty || fileHeader != null;
 
   @override
-  List<Uri> get requiredImports => librariesToImport.keys.toList();
+  List<Uri> get requiredImports => _librariesToImport.keys.toList();
 
   CodeStyleOptions get _codeStyleOptions => resolvedUnit.session.analysisContext
       .getAnalysisOptionsForFile(resolvedUnit.file)
@@ -1544,8 +1544,8 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
         createEditsForImports: _createEditsForImports);
     copy.fileEdit.edits.addAll(fileEdit.edits);
     copy.importPrefixGenerator = importPrefixGenerator;
-    for (var entry in librariesToImport.entries) {
-      copy.librariesToImport[entry.key] = entry.value;
+    for (var entry in _librariesToImport.entries) {
+      copy._librariesToImport[entry.key] = entry.value;
     }
     for (var entry in _elementLibrariesToImport.entries) {
       copy._elementLibrariesToImport[entry.key] = entry.value;
@@ -1561,8 +1561,8 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
 
   @override
   void finalize() {
-    if (_createEditsForImports && librariesToImport.isNotEmpty) {
-      _addLibraryImports(librariesToImport.values);
+    if (_createEditsForImports && _librariesToImport.isNotEmpty) {
+      _addLibraryImports(_librariesToImport.values);
     }
     var header = fileHeader;
     if (header != null) {
@@ -1741,7 +1741,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
     }
 
     // Queued change.
-    var importChange = (libraryChangeBuilder ?? this).librariesToImport[uri];
+    var importChange = (libraryChangeBuilder ?? this)._librariesToImport[uri];
     return importChange != null;
   }
 
@@ -1909,7 +1909,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
     super.revert();
 
     for (var uri in _revertData._addedLibrariesToImport) {
-      librariesToImport.remove(uri);
+      _librariesToImport.remove(uri);
     }
 
     _revertData._addedLibrariesToImport.clear();
@@ -2400,7 +2400,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
     bool forceAbsolute = false,
     bool forceRelative = false,
   }) {
-    var import = (libraryChangeBuilder ?? this).librariesToImport[uri];
+    var import = (libraryChangeBuilder ?? this)._librariesToImport[uri];
     var existingShownNames = <List<String>>[];
     var existingHiddenNames = <List<String>>[];
 
@@ -2457,7 +2457,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
       if (showName != null) {
         import._ensureShown(showName, useShow: useShow);
       }
-      (libraryChangeBuilder ?? this).librariesToImport[uri] = import;
+      (libraryChangeBuilder ?? this)._librariesToImport[uri] = import;
       _revertData._addedLibrariesToImport.add(uri);
     }
     return import;
@@ -2506,7 +2506,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
     // And finally, remove the remaining candidates from the set of libraries to
     // be imported.
     (libraryChangeBuilder ?? this)
-        .librariesToImport
+        ._librariesToImport
         .removeWhere((_, import) => candidatesToRemove.contains(import));
   }
 

pkg/analyzer_plugin/tool/spec/codegen_protocol_constants.dart

@@ -10,14 +10,14 @@ import 'from_html.dart';
 
 final GeneratedFile target = GeneratedFile(
     'lib/protocol/protocol_constants.dart', (String pkgPath) async {
-  var visitor = CodegenVisitor(readApi(pkgPath));
+  var visitor = _CodegenVisitor(readApi(pkgPath));
   return visitor.collectCode(visitor.visitApi);
 });
 
 /// A visitor that produces Dart code defining constants associated with the
 /// API.
-class CodegenVisitor extends DartCodegenVisitor with CodeGenerator {
-  CodegenVisitor(super.api) {
+class _CodegenVisitor extends DartCodegenVisitor with CodeGenerator {
+  _CodegenVisitor(super.api) {
     codeGeneratorSettings.commentLineLength = 79;
     codeGeneratorSettings.docCommentStartMarker = null;
     codeGeneratorSettings.docCommentLineLeader = '/// ';