[cfe] Support declaring parameters in primary constructors

This adds support for declaring parameters in primary constructors on classes and enums. Default values are currently not supported.

Part of #61700

Change-Id: Ibe8983e8e10fb7948510304c8bbcb4184372b6c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458920
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/base/modifiers.dart

@@ -57,6 +57,10 @@ const int _declaresConstConstructorMask = _initializingFormalMask << 1;
 /// super-parameter initializers.
 const int _superInitializingFormalMask = _declaresConstConstructorMask << 1;
 
+/// Not a modifier, used by formal parameters to track if they are declaring
+/// parameters.
+const int _declaringParameterMask = _superInitializingFormalMask << 1;
+
 /// Extension type that encodes a set of modifiers as a bit mask.
 extension type const Modifiers(int _mask) implements Object {
   /// The empty set of modifiers.
@@ -477,6 +481,23 @@ extension type const Modifiers(int _mask) implements Object {
   bool get isSuperInitializingFormal =>
       (_mask & _superInitializingFormalMask) != 0;
 
+  /// The set of modifiers containing only the synthetic modifier used to denote
+  /// that a parameter is a declaring parameter.
+  ///
+  /// ```
+  /// DartDocTest(
+  ///     Modifiers.DeclaringParameter.isDeclaringParameter, true)
+  /// DartDocTest(Modifiers.DeclaringParameter.isEmpty, false)
+  /// DartDocTest(Modifiers.DeclaringParameter.isAbstract, false)
+  /// ```
+  static const Modifiers DeclaringParameter = const Modifiers(
+    _declaringParameterMask,
+  );
+
+  /// Returns `true` if the set of modifiers contains the synthetic modifier
+  /// used to denote that a parameter is a declaring parameter.
+  bool get isDeclaringParameter => (_mask & _declaringParameterMask) != 0;
+
   /// Returns `true` if this set of modifiers contains any syntactic modifiers.
   ///
   /// If [ignoreRequired] is `true`, `required` is ignored. If
@@ -531,7 +552,8 @@ extension type const Modifiers(int _mask) implements Object {
             _initializingFormalMask |
             _declaresConstConstructorMask |
             _namedMixinApplicationMask |
-            _superInitializingFormalMask);
+            _superInitializingFormalMask |
+            _declaringParameterMask);
     if (ignoreRequired) {
       mask &= ~_requiredMask;
     }

pkg/front_end/lib/src/fragment/constructor/declaration.dart

@@ -1291,9 +1291,7 @@ class PrimaryConstructorDeclaration
     returnType.registerInferredTypeListener(this);
     if (formals != null) {
       for (FormalParameterBuilder formal in formals!) {
-        if (formal.isInitializingFormal ||
-            // Coverage-ignore(suite): Not run.
-            formal.isSuperInitializingFormal) {
+        if (formal.isInitializingFormal || formal.isSuperInitializingFormal) {
           formal.type.registerInferable(inferable);
         }
       }

pkg/front_end/lib/src/fragment/declaration.dart

@@ -54,11 +54,9 @@ abstract class DeclarationFragmentImpl implements DeclarationFragment {
 
   UriOffsetLength get uriOffset;
 
-  void addPrimaryConstructorField(PrimaryConstructorFieldFragment fragment) {
-    throw new UnsupportedError(
-      "Unexpected primary constructor field in $this.",
-    );
-  }
+  void registerPrimaryConstructorField(
+    PrimaryConstructorFieldFragment fragment,
+  ) {}
 
   void addEnumElement(EnumElementFragment fragment) {
     throw new UnsupportedError("Unexpected enum element in $this.");

pkg/front_end/lib/src/fragment/extension_type.dart

@@ -62,7 +62,9 @@ class ExtensionTypeFragment extends DeclarationFragmentImpl
       DeclarationFragmentKind.extensionTypeDeclaration;
 
   @override
-  void addPrimaryConstructorField(PrimaryConstructorFieldFragment fragment) {
+  void registerPrimaryConstructorField(
+    PrimaryConstructorFieldFragment fragment,
+  ) {
     primaryConstructorFields.add(fragment);
   }
 

pkg/front_end/lib/src/fragment/field/class_member.dart

@@ -6,17 +6,24 @@ part of '../fragment.dart';
 
 class _FieldClassMember implements ClassMember {
   final SourcePropertyBuilder _builder;
-  final FieldFragment _fragment;
+
+  @override
+  final UriOffsetLength uriOffset;
+
+  @override
+  final bool isStatic;
 
   @override
   final bool forSetter;
 
   Covariance? _covariance;
 
-  _FieldClassMember(this._builder, this._fragment, {required this.forSetter});
-
-  @override
-  UriOffsetLength get uriOffset => _fragment.uriOffset;
+  _FieldClassMember(
+    this._builder, {
+    required this.uriOffset,
+    required this.isStatic,
+    required this.forSetter,
+  });
 
   @override
   DeclarationBuilder get declarationBuilder => _builder.declarationBuilder!;
@@ -99,11 +106,8 @@ class _FieldClassMember implements ClassMember {
   ClassMember get interfaceMember => this;
 
   @override
-  // TODO(johnniwinther): This should not be determined by the builder. A
-  // property can have a non-abstract getter and an abstract setter or the
-  // reverse. With augmentations, abstract introductory declarations might even
-  // be implemented by augmentations.
-  bool get isAbstract => _fragment.modifiers.isAbstract;
+  bool get isAbstract =>
+      forSetter ? _builder.hasAbstractSetter : _builder.hasAbstractGetter;
 
   @override
   bool get isDuplicate => _builder.isDuplicate;
@@ -134,9 +138,6 @@ class _FieldClassMember implements ClassMember {
   @override
   bool get isSourceDeclaration => true;
 
-  @override
-  bool get isStatic => _fragment.modifiers.isStatic;
-
   @override
   bool get isSynthesized => false;