[dartdev] Add 'compile js-dev' command in the Dart cli tool.

Added the option 'js-dev' to the compile command to allow compilation
of Dart sources using DDC. This ensures that tools will not be reaching
into the internal implementation details of a Dart SDK to run DDC.

TEST=unit tests added in compile_test.dart

Change-Id: I3c670b43a989dfa60c75622fdbc1b7f99b399293
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392202
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>

Author: a-siva

pkg/dartdev/lib/src/commands/compile.dart

@@ -125,6 +125,58 @@ class CompileJSCommand extends CompileSubcommandCommand {
   }
 }
 
+class CompileDDCCommand extends CompileSubcommandCommand {
+  static const String cmdName = 'js-dev';
+
+  /// Accept all flags so we can delegate arg parsing to ddc internally.
+  @override
+  final ArgParser argParser = ArgParser.allowAnything();
+
+  // This command is an internal developer command used by tools and is
+  // hidden in the help message.
+  CompileDDCCommand({bool verbose = false})
+      : super(cmdName, 'Compile Dart to JavaScript using ddc.', verbose,
+              hidden:true,);
+
+  @override
+  String get invocation => '${super.invocation} <dart entry point>';
+
+  @override
+  FutureOr<int> run() async {
+    if (!Sdk.checkArtifactExists(sdk.librariesJson)) {
+      return genericErrorExitCode;
+    }
+    final args = argResults!;
+    var snapshot = sdk.ddcAotSnapshot;
+    var runtime = sdk.dartAotRuntime;
+    if (!Sdk.checkArtifactExists(snapshot, logError: false)) {
+      // AOT snapshots cannot be generated on IA32, so we need this fallback
+      // branch until support for IA32 is dropped (https://dartbug.com/49969).
+      snapshot = sdk.ddcSnapshot;
+      runtime = sdk.dart;
+      if (!Sdk.checkArtifactExists(snapshot)) {
+        return genericErrorExitCode;
+      }
+    }
+    final ddcCommand = <String>[
+      runtime,
+      snapshot,
+      // Add the remaining arguments.
+      if (args.rest.isNotEmpty) ...args.rest.sublist(0),
+    ];
+    try {
+      return await runProcessInheritStdio(ddcCommand);
+    } catch (e, st) {
+      log.stderr('Error: JS compilation failed');
+      log.stderr(e.toString());
+      if (verbose) {
+        log.stderr(st.toString());
+      }
+      return compileErrorExitCode;
+    }
+  }
+}
+
 class CompileKernelSnapshotCommand extends CompileSubcommandCommand {
   static const commandName = 'kernel';
   static const help = 'Compile Dart to a kernel snapshot.\n'
@@ -947,6 +999,7 @@ class CompileCommand extends DartdevCommand {
     bool nativeAssetsExperimentEnabled = false,
   }) : super(cmdName, 'Compile Dart to various formats.', verbose) {
     addSubcommand(CompileJSCommand(verbose: verbose));
+    addSubcommand(CompileDDCCommand(verbose: verbose));
     addSubcommand(CompileJitSnapshotCommand(verbose: verbose));
     addSubcommand(CompileKernelSnapshotCommand(verbose: verbose));
     addSubcommand(CompileNativeCommand(

pkg/dartdev/lib/src/sdk.dart

@@ -67,6 +67,14 @@ class Sdk {
         'analysis_server.dart.snapshot',
       );
 
+  String get ddcSnapshot => _snapshotPathFor(
+        'dartdevc.dart.snapshot',
+      );
+
+  String get ddcAotSnapshot => _snapshotPathFor(
+        'dartdevc_aot.dart.snapshot',
+      );
+
   String get dart2jsSnapshot => _snapshotPathFor(
         'dart2js.dart.snapshot',
       );

pkg/dartdev/test/commands/compile_test.dart

@@ -179,6 +179,7 @@ void defineCompileTests() {
       ],
     );
     expect(result.stderr, contains('Compile Dart'));
+    expect(result.stderr, isNot(contains('js-dev')));
     expect(result.exitCode, 64);
   });
 
@@ -198,6 +199,7 @@ void defineCompileTests() {
     expect(result.stdout, contains('jit-snapshot'));
     expect(result.stdout, contains('kernel'));
     expect(result.stdout, contains('js'));
+    expect(result.stderr, isNot(contains('js-dev')));
     expect(result.stdout, contains('aot-snapshot'));
     expect(result.stdout, contains('exe'));
     expect(result.exitCode, 0);
@@ -209,6 +211,7 @@ void defineCompileTests() {
       ['compile', '--help', '--verbose'],
     );
     expect(result.stdout, contains('Compile Dart'));
+    expect(result.stdout, isNot(contains('js-dev')));
     expect(
       result.stdout,
       contains(
@@ -602,6 +605,35 @@ void defineCompileTests() {
     expect(contents.contains('2: foo'), true);
   });
 
+  test('Compile JS DDC', () async {
+    final p = project(mainSrc: '''
+        void main() {
+          print('1: ' + const String.fromEnvironment('foo'));
+          print('2: ' + const String.fromEnvironment('bar'));
+        }''');
+    final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
+    final outFile = path.canonicalize(path.join(p.dirPath, 'main.js'));
+
+    final result = await p.run([
+      'compile',
+      'js-dev',
+      '-Dfoo=bar',
+      '--define=bar=foo',
+      '-o',
+      outFile,
+      inFile,
+    ]);
+    expect(result.stdout, isNot(contains(usingTargetOSMessage)));
+    expect(result.stderr, isEmpty);
+    expect(result.exitCode, 0);
+    final file = File(outFile);
+    expect(file.existsSync(), true, reason: 'File not found: $outFile');
+
+    final contents = file.readAsStringSync();
+    expect(contents.contains('"1: " + "bar"'), true);
+    expect(contents.contains('"2: " + "foo"'), true);
+  });
+
   test('Compile exe with error', () async {
     final p = project(mainSrc: '''
 void main() {
@@ -939,6 +971,28 @@ void main() {
         reason: 'File not found: $outFile');
   }, skip: isRunningOnIA32);
 
+  test('Compile JS DDC with sound null safety', () async {
+    final p = project(mainSrc: '''void main() {}''');
+    final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
+    final outFile = path.canonicalize(path.join(p.dirPath, 'myjs'));
+
+    final result = await p.run(
+      [
+        'compile',
+        'js-dev',
+        '-o',
+        outFile,
+        inFile,
+      ],
+    );
+
+    expect(result.stdout, isNot(contains(soundNullSafetyMessage)));
+    expect(result.stderr, isEmpty);
+    expect(result.exitCode, 0);
+    expect(File(outFile).existsSync(), true,
+        reason: 'File not found: $outFile');
+  }, skip: isRunningOnIA32);
+
   test('Compile JS with unsound null safety', () async {
     final p = project(mainSrc: '''
 // @dart=2.9

pkg/dartdev/test/core_test.dart

@@ -41,7 +41,7 @@ void _dartdevCommand() {
   });
 
   test('compile', () {
-    assertDartdevCommandProperties(CompileCommand(), 'compile', 'compile', 6);
+    assertDartdevCommandProperties(CompileCommand(), 'compile', 'compile', 7);
   });
 
   test('compile/js', () {
@@ -51,6 +51,13 @@ void _dartdevCommand() {
         'compile/js');
   });
 
+  test('compile/js-dev', () {
+    assertDartdevCommandProperties(
+        CompileCommand().subcommands['js-dev'] as DartdevCommand,
+        'js-dev',
+        'compile/js-dev');
+  });
+
   test('compile/jit-snapshot', () {
     assertDartdevCommandProperties(
         CompileCommand().subcommands['jit-snapshot'] as DartdevCommand,