[sdk] Remove some redundant kernel-worker JIT snapshot generation code.

Change-Id: Ic092633dd6f5eb0dcfdef70472221ddc7951bbbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412783
Reviewed-by: Srujan Gaddam <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>
Reviewed-by: Nicholas Shahan <[email protected]>

Author: a-siva

pkg/compiler/tool/modular_test_suite_helper.dart

@@ -29,7 +29,6 @@ Uri packageConfigUri = sdkRoot.resolve(packageConfigJsonPath);
 late Options _options;
 late String _dart2jsScript;
 late String _kernelWorkerAotScript;
-late String _kernelWorkerScript;
 
 const dillSummaryId = DataId("summary.dill");
 const dillId = DataId("full.dill");
@@ -127,19 +126,13 @@ abstract class CFEStep extends IOModularStep {
       sources = getSources(module);
     }
 
-    var isAot = File(_kernelWorkerAotScript).existsSync();
     var script = _kernelWorkerAotScript;
     var sdkPath = p.dirname(p.dirname(Platform.resolvedExecutable));
     var executable = p.absolute(
       sdkPath,
       'bin',
       Platform.isWindows ? 'dartaotruntime.exe' : 'dartaotruntime',
     );
-    if (!isAot) {
-      // This can be removed once we stop supporting ia32 architecture.
-      script = _kernelWorkerScript;
-      executable = Platform.resolvedExecutable;
-    }
 
     List<String> args = [
       script,
@@ -737,10 +730,6 @@ Future<void> resolveScripts(Options options) async {
     'utils/bazel/kernel_worker.dart',
     'snapshots/kernel_worker_aot.dart.snapshot',
   );
-  _kernelWorkerScript = await resolve(
-    'utils/bazel/kernel_worker.dart',
-    'snapshots/kernel_worker.dart.snapshot',
-  );
 }
 
 String _librarySpecForSnapshot =

pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_shared.dart

@@ -1195,18 +1195,15 @@ class DDCKernelGenerator {
   DDCKernelGenerator(this.config, this.verbose);
 
   Future<int> generate() async {
+    var exitCode = 0;
     if (!File(dartdevc).existsSync()) {
-      // This can be removed once we stop supporting ia32 architecture.
-      dartdevc = p.join(
-          sdkPath, 'dart-sdk', 'bin', 'snapshots', 'dartdevc.dart.snapshot');
-      kernelWorker = p.join(sdkPath, 'dart-sdk', 'bin', 'snapshots',
-          'kernel_worker.dart.snapshot');
-      dartExecutable = Platform.resolvedExecutable;
+      exitCode = 1;
+      expect(exitCode, 0,
+          reason: 'Unable to locate snapshot for compiler $dartdevc');
     }
     Directory.fromUri(config.outputPath).createSync();
 
     // generate summaries
-    var exitCode = 0;
     for (var module in config.modules.values) {
       exitCode = await _generateSummary(module);
       expect(exitCode, 0,

pkg/dev_compiler/test/modular_helpers.dart

@@ -325,12 +325,5 @@ Future<void> resolveScripts(Options options) async {
       'bin',
       Platform.isWindows ? 'dartaotruntime.exe' : 'dartaotruntime',
     );
-  } else {
-    // This can be removed once we stop supporting ia32 architecture.
-    _dartdevcScript = await resolve('pkg/dev_compiler/bin/dartdevc.dart',
-        'snapshots/dartdevc.dart.snapshot');
-    _kernelWorkerScript = await resolve('utils/bazel/kernel_worker.dart',
-        'snapshots/kernel_worker.dart.snapshot');
-    _dartExecutable = Platform.resolvedExecutable;
   }
 }

sdk/BUILD.gn

@@ -57,8 +57,7 @@ declare_args() {
 # ........frontend_server.dart.snapshot (JIT snapshot only on ia32)
 # ........gen_kernel_aot.dart.snapshot (if not on ia32)
 # ........kernel-service.dart.snapshot
-# ........kernel_worker_aot.dart.snapshot (JIT snapshot only on ia32)
-# ........kernel_worker.dart.snapshot (AOT snapshot, it not ia32)
+# ........kernel_worker_aot.dart.snapshot (AOT snapshot)
 # ......resources/
 # ........dartdoc/
 # ..........resources/
@@ -205,11 +204,6 @@ if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
           "../utils/ddc:dartdevc",
           "dartdevc",
         ],
-        [
-          "kernel_worker",
-          "../utils/bazel:kernel_worker",
-          "kernel_worker",
-        ],
       ]
 } else {
   _full_sdk_snapshots = _platform_sdk_snapshots + [