Skip to content

Commit 0e9cd07

Browse files
committed
Elements. Use PropertyAccessorElementImpl for PropertyAccessorMember.
Change-Id: Ie86e6cc5750bb42343b7c5e906b84bcd668a4140 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417121 Reviewed-by: Paul Berry <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 0f42cba commit 0e9cd07

File tree

2 files changed

+25
-17
lines changed

2 files changed

+25
-17
lines changed

pkg/analyzer/lib/src/dart/element/element.dart

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5445,10 +5445,10 @@ class GetterFragmentImpl extends PropertyAccessorElementImpl
54455445
: super.forVariable();
54465446

54475447
@override
5448-
PropertyAccessorElement? get correspondingGetter => null;
5448+
PropertyAccessorElementImpl? get correspondingGetter => null;
54495449

54505450
@override
5451-
PropertyAccessorElement? get correspondingSetter => variable2?.setter;
5451+
PropertyAccessorElementImpl? get correspondingSetter => variable2?.setter;
54525452

54535453
@override
54545454
GetterElementImpl get element {
@@ -9892,6 +9892,12 @@ sealed class PropertyAccessorElementImpl extends ExecutableElementImpl
98929892
isSynthetic = true;
98939893
}
98949894

9895+
@override
9896+
PropertyAccessorElementImpl? get correspondingGetter;
9897+
9898+
@override
9899+
PropertyAccessorElementImpl? get correspondingSetter;
9900+
98959901
@override
98969902
PropertyAccessorElementImpl get declaration => this;
98979903

@@ -10494,10 +10500,10 @@ class SetterFragmentImpl extends PropertyAccessorElementImpl
1049410500
: super.forVariable();
1049510501

1049610502
@override
10497-
PropertyAccessorElement? get correspondingGetter => variable2?.getter;
10503+
PropertyAccessorElementImpl? get correspondingGetter => variable2?.getter;
1049810504

1049910505
@override
10500-
PropertyAccessorElement? get correspondingSetter => null;
10506+
PropertyAccessorElementImpl? get correspondingSetter => null;
1050110507

1050210508
@override
1050310509
SetterElementImpl get element {

pkg/analyzer/lib/src/dart/element/member.dart

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -711,12 +711,12 @@ class GetterMember extends PropertyAccessorMember
711711
GetterElement get baseElement => _element2;
712712

713713
@override
714-
SetterElement? get correspondingSetter2 {
714+
SetterElement2OrMember? get correspondingSetter2 {
715715
var setter = correspondingSetter;
716716
if (setter is SetterMember) {
717717
return setter;
718718
}
719-
return setter.asElement2 as SetterElement?;
719+
return setter.asElement2 as SetterElementImpl?;
720720
}
721721

722722
@override
@@ -1312,7 +1312,7 @@ abstract class PropertyAccessorMember extends ExecutableMember
13121312
PropertyAccessorElementOrMember,
13131313
PropertyAccessorElement2OrMember {
13141314
factory PropertyAccessorMember({
1315-
required PropertyAccessorElement declaration,
1315+
required PropertyAccessorElementImpl declaration,
13161316
required MapSubstitution substitution,
13171317
}) {
13181318
var freshTypeParameters = _SubstitutedTypeParameters(
@@ -1335,13 +1335,13 @@ abstract class PropertyAccessorMember extends ExecutableMember
13351335
}
13361336

13371337
PropertyAccessorMember._({
1338-
required PropertyAccessorElement super.declaration,
1338+
required PropertyAccessorElementImpl super.declaration,
13391339
required super.substitution,
13401340
required super.typeParameters,
13411341
});
13421342

13431343
@override
1344-
PropertyAccessorElement? get correspondingGetter {
1344+
PropertyAccessorElementOrMember? get correspondingGetter {
13451345
var baseGetter = declaration.correspondingGetter;
13461346
if (baseGetter == null) {
13471347
return null;
@@ -1353,7 +1353,7 @@ abstract class PropertyAccessorMember extends ExecutableMember
13531353
}
13541354

13551355
@override
1356-
PropertyAccessorElement? get correspondingSetter {
1356+
PropertyAccessorElementOrMember? get correspondingSetter {
13571357
var baseSetter = declaration.correspondingSetter;
13581358
if (baseSetter == null) {
13591359
return null;
@@ -1419,19 +1419,21 @@ abstract class PropertyAccessorMember extends ExecutableMember
14191419
);
14201420
}
14211421

1422-
/// If the given [accessor]'s type is different when any type parameters from
1422+
/// If the given [element]'s type is different when any type parameters from
14231423
/// the defining type's declaration are replaced with the actual type
14241424
/// arguments from the [definingType], create an accessor member representing
14251425
/// the given accessor. Return the member that was created, or the base
14261426
/// accessor if no member was created.
14271427
static PropertyAccessorElementOrMember? from(
1428-
PropertyAccessorElementOrMember? accessor, InterfaceType definingType) {
1429-
if (accessor == null || definingType.typeArguments.isEmpty) {
1430-
return accessor;
1428+
PropertyAccessorElementImpl? element,
1429+
InterfaceType definingType,
1430+
) {
1431+
if (element == null || definingType.typeArguments.isEmpty) {
1432+
return element;
14311433
}
14321434

14331435
return PropertyAccessorMember(
1434-
declaration: accessor,
1436+
declaration: element,
14351437
substitution: Substitution.fromInterfaceType(definingType),
14361438
);
14371439
}
@@ -1451,12 +1453,12 @@ class SetterMember extends PropertyAccessorMember
14511453
SetterElement get baseElement => _element2;
14521454

14531455
@override
1454-
GetterElement? get correspondingGetter2 {
1456+
GetterElement2OrMember? get correspondingGetter2 {
14551457
var getter = correspondingGetter;
14561458
if (getter is GetterMember) {
14571459
return getter;
14581460
}
1459-
return getter.asElement2 as GetterElement?;
1461+
return getter.asElement2 as GetterElementImpl?;
14601462
}
14611463

14621464
@override

0 commit comments

Comments
 (0)