Version 3.9.0-239.0.dev

Merge ab4f935 into dev

Author: Dart CI

DEPS

@@ -114,7 +114,7 @@ vars = {
   "ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
   "protobuf_gn_rev": "ca669f79945418f6229e4fef89b666b2a88cbb10",
   "WebCore_rev": "bcb10901266c884e7b3740abc597ab95373ab55c",
-  "zlib_rev": "108fa50cda23ed4a712a098d058dccbbfd248206",
+  "zlib_rev": "470d3a2ee4ef721688ce6961bc865a99fcb64070",
 
   # Note: Updates to dart_style have to be coordinated with the infrastructure
   # team so that the internal formatter `tools/sdks/dart-sdk/bin/dart format`

PRESUBMIT.py

@@ -380,7 +380,7 @@ def _CheckAnalyzerFiles(input_api, output_api):
 
     # Verify the "error fix status" file.
     code_files = [
-        "pkg/analyzer/lib/src/error/error_code_values.g.dart",
+        "pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart",
         "pkg/linter/lib/src/rules.dart",
     ]
 

benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart

@@ -8,10 +8,7 @@ import 'dart:io';
 
 const executables = <String>['dart', 'dartaotruntime'];
 
-const libs = <String>[
-  'vm_platform_strong.dill',
-  'vm_platform_strong_product.dill',
-];
+const libs = <String>['vm_platform.dill', 'vm_platform_product.dill'];
 
 const snapshots = <String>[
   'analysis_server',

build/gn_dart_compile_exe.py

@@ -90,7 +90,7 @@ def main(argv):
         return 1
 
     platform_dill = os.path.join(prebuilt_sdk, "lib", "_internal",
-                                 "vm_platform_strong.dill")
+                                 "vm_platform.dill")
     if not os.path.isfile(platform_dill):
         print("Binary not found: " + platform_dill)
         return 1

build/rbe/rewrapper_dart.py

@@ -360,8 +360,7 @@ def parse_dart(self):
                 self.extra_paths.add(self.rebase(arg))
                 self.extra_paths.add(
                     self.rebase(
-                        os.path.join(self.dart_subdir,
-                                     'vm_platform_strong.dill')))
+                        os.path.join(self.dart_subdir, 'vm_platform.dill')))
                 return self.parse_kernel_service_snapshot()
             else:
                 self.unsupported('dart', arg)
@@ -509,7 +508,7 @@ def parse_compile_platform(self):
                     if sdk.endswith('libraries.json'):
                         sdk = os.path.dirname(sdk)
                     self.extra_paths.add(self.rebase(sdk))
-                elif len(compile_platform_args) == 2:  # vm_outline_strong dill
+                elif len(compile_platform_args) == 2:  # vm_outline dill
                     arg = self.rebase(arg)
                 elif len(compile_platform_args) == 3:  # platform dill
                     arg = self.rebase(arg)

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -2885,9 +2885,6 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
       keywordHelper.addKeyword(Keyword.CASE);
       keywordHelper.addKeywordAndText(Keyword.DEFAULT, ':');
       if (members.isNotEmpty) {
-        if (!members.any((element) => element is SwitchDefault)) {
-          keywordHelper.addKeywordAndText(Keyword.DEFAULT, ':');
-        }
         var element = members.elementBefore(offset);
         if (element != null) {
           _forStatement(element);

pkg/analysis_server/lib/src/services/completion/yaml/analysis_options_generator.dart

@@ -74,8 +74,8 @@ class _ErrorProducer extends KeyValueProducer {
   @override
   Iterable<CompletionSuggestion> suggestions(YamlCompletionRequest request) {
     return [
-      for (var error in errorCodeValues)
-        identifier('${error.name.toLowerCase()}: '),
+      for (var diagnostic in diagnosticCodeValues)
+        identifier('${diagnostic.name.toLowerCase()}: '),
       for (var rule in Registry.ruleRegistry.rules)
         identifier('${rule.name}: '),
     ];

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -157,7 +157,7 @@ class BulkFixProcessor {
   static final Map<DiagnosticCode, bool> _bulkFixableCodes = {};
 
   static final Set<String> _diagnosticCodes =
-      errorCodeValues.map((code) => code.name.toLowerCase()).toSet();
+      diagnosticCodeValues.map((code) => code.name.toLowerCase()).toSet();
 
   static final Set<String> _lintCodes =
       Registry.ruleRegistry.rules.map((rule) => rule.name).toSet();

pkg/analysis_server/tool/presubmit/verify_error_fix_status.dart

@@ -57,7 +57,7 @@ String? verifyErrorFixStatus() {
   var lintRuleNames = {for (var lintCode in lintRuleCodes) lintCode.uniqueName};
 
   var errorData = ErrorData();
-  for (var code in errorCodeValues) {
+  for (var code in diagnosticCodeValues) {
     var name = code.uniqueName;
     if (name.startsWith('TodoCode.')) {
       // To-do codes are ignored.
@@ -99,10 +99,10 @@ String? verifyErrorFixStatus() {
     }
   }
 
-  var errorCodeNames = {for (var code in errorCodeValues) code.uniqueName};
+  var codeNames = {for (var code in diagnosticCodeValues) code.uniqueName};
   for (var key in statusInfo.keys) {
     if (key is String) {
-      if (!errorCodeNames.contains(key) && !lintRuleNames.contains(key)) {
+      if (!codeNames.contains(key) && !lintRuleNames.contains(key)) {
         errorData.entriesWithNoCode.add(key);
       }
     }

pkg/analyzer/api.txt

@@ -4685,7 +4685,8 @@ package:analyzer/diagnostic/diagnostic.dart:
     values (static getter: List<Severity>)
     warning (static getter: Severity)
 package:analyzer/error/error.dart:
-  errorCodeValues (static getter: List<DiagnosticCode>)
+  diagnosticCodeValues (static getter: List<DiagnosticCode>)
+  errorCodeValues (static getter: List<DiagnosticCode>, deprecated)
   errorCodeByUniqueName (function: DiagnosticCode? Function(String))
   DiagnosticCode (class extends Object):
     new (constructor: DiagnosticCode Function({String? correctionMessage, bool hasPublishedDocs, bool isUnresolvedIdentifier, required String name, required String problemMessage, required String uniqueName}))