[dart2js] Simplify HTypeKnow.isRedundant

rakudrama · Commit Queue · commit 0f601c3a359b · 2025-05-05T14:07:54.000-07:00
After 0bb3adb it seems we should not need the HTypeKnown to stick around since the knownType can no longer change. Bug: #60327 Change-Id: I575816a11e41e75acebecde1c32d37d251b5947b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426343 Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Stephen Adams <sra@google.com>
diff --git a/pkg/compiler/lib/src/ssa/nodes.dart b/pkg/compiler/lib/src/ssa/nodes.dart
@@ -4088,9 +4088,6 @@ class HTypeKnown extends HCheck {
 
   bool isRedundant(JClosedWorld closedWorld) {
     AbstractValueDomain abstractValueDomain = closedWorld.abstractValueDomain;
-    if (abstractValueDomain.containsAll(knownType).isPotentiallyTrue) {
-      return false;
-    }
     AbstractValue inputType = checkedInput.instructionType;
     return abstractValueDomain.isIn(inputType, knownType).isDefinitelyTrue;
   }

Original file line number	Diff line number	Diff line change
`@@ -4088,9 +4088,6 @@ class HTypeKnown extends HCheck {`
`4088`	`4088`
`4089`	`4089`	`bool isRedundant(JClosedWorld closedWorld) {`
`4090`	`4090`	`AbstractValueDomain abstractValueDomain = closedWorld.abstractValueDomain;`
`4091`		`- if (abstractValueDomain.containsAll(knownType).isPotentiallyTrue) {`
`4092`		`- return false;`
`4093`		`- }`
`4094`	`4091`	`AbstractValue inputType = checkedInput.instructionType;`
`4095`	`4092`	`return abstractValueDomain.isIn(inputType, knownType).isDefinitelyTrue;`
`4096`	`4093`	`}`