Elements. Inline _readFragmentMetadata().

The private helper method `_readFragmentMetadata` has been inlined at
all of its call sites within `BundleReader`.

This method only contained a single line of code, making it an
unnecessary abstraction.

Change-Id: Ib429e1cf98c355dda96b91dc36c65754b4c5b8dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445126
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -327,7 +327,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           fragment.supertype = reader._readOptionalInterfaceType();
           fragment.mixins = reader._readInterfaceTypeList();
           fragment.interfaces = reader._readInterfaceTypeList();
@@ -393,7 +393,7 @@ class LibraryReader {
             reader,
             fragment.formalParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           fragment.constantInitializers = reader.readNodeList();
         },
       );
@@ -522,7 +522,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           fragment.supertype = reader._readOptionalInterfaceType();
           fragment.mixins = reader._readInterfaceTypeList();
           fragment.interfaces = reader._readInterfaceTypeList();
@@ -605,7 +605,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
         },
       );
     });
@@ -664,7 +664,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           fragment.interfaces = reader._readInterfaceTypeList();
           fragment.typeErasure = reader.readRequiredType();
         },
@@ -713,7 +713,7 @@ class LibraryReader {
               fragment.element.enclosingElement as InstanceElementImpl;
           reader._addTypeParameters2(enclosingElement.typeParameters);
 
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           if (reader.readOptionalExpression() case var initializer?) {
             fragment.constantInitializer = initializer;
             ConstantContextForExpressionImpl(fragment, initializer);
@@ -754,14 +754,6 @@ class LibraryReader {
     return _reader.readUInt30();
   }
 
-  void _readFragmentMetadata<T extends FragmentImpl>(
-    T fragment,
-    ResolutionReader reader,
-  ) {
-    // TODO(scheglov): inline it
-    fragment.metadata = reader._readMetadata();
-  }
-
   String? _readFragmentName() {
     return _reader.readOptionalStringReference();
   }
@@ -820,7 +812,7 @@ class LibraryReader {
             reader,
             fragment.formalParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
         },
       );
     });
@@ -951,7 +943,7 @@ class LibraryReader {
             reader,
             fragment.formalParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
         },
       );
     });
@@ -1010,7 +1002,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           // _readTypeParameters(reader, fragment.typeParameters);
           fragment.superclassConstraints = reader._readInterfaceTypeList();
           fragment.interfaces = reader._readInterfaceTypeList();
@@ -1138,7 +1130,7 @@ class LibraryReader {
             reader,
             fragment.formalParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
         },
       );
     });
@@ -1216,7 +1208,7 @@ class LibraryReader {
             reader,
             fragment.formalParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
         },
       );
     });
@@ -1261,7 +1253,7 @@ class LibraryReader {
         },
         readResolution: (fragment, reader) {
           reader.currentLibraryFragment = fragment.libraryFragment;
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           if (reader.readOptionalExpression() case var initializer?) {
             fragment.constantInitializer = initializer;
             ConstantContextForExpressionImpl(fragment, initializer);
@@ -1310,7 +1302,7 @@ class LibraryReader {
             reader,
             fragment.typeParameters,
           );
-          _readFragmentMetadata(fragment, reader);
+          fragment.metadata = reader._readMetadata();
           fragment.aliasedElement = reader._readAliasedElement(unitElement);
         },
       );