Fine. Support for top-level setters.

Many existing manifest tests involving top level variables were changed to use `final` variables, so that the test expectations don't need to contain distracting references to top level setters.

Change-Id: I5a641c2d446f366435a127d66e951d78d784d0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419983
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -325,6 +325,23 @@ class LibraryManifestBuilder {
     newItems[lookupName] = item;
   }
 
+  void _addTopLevelSetter({
+    required EncodeContext encodingContext,
+    required Map<LookupName, TopLevelItem> newItems,
+    required SetterElementImpl element,
+    required LookupName lookupName,
+  }) {
+    var item = _getOrBuildElementItem(element, () {
+      return TopLevelSetterItem.fromElement(
+        name: lookupName,
+        id: ManifestItemId.generate(),
+        context: encodingContext,
+        element: element,
+      );
+    });
+    newItems[lookupName] = item;
+  }
+
   /// Fill `result` with new library manifests.
   /// We reuse existing items when they fully match.
   /// We build new items for mismatched elements.
@@ -357,6 +374,13 @@ class LibraryManifestBuilder {
               element: element,
               lookupName: lookupName,
             );
+          case SetterElementImpl():
+            _addTopLevelSetter(
+              encodingContext: encodingContext,
+              newItems: newItems,
+              element: element,
+              lookupName: lookupName,
+            );
           case TopLevelFunctionElementImpl():
             _addTopLevelFunction(
               encodingContext: encodingContext,
@@ -524,6 +548,10 @@ class _LibraryMatch {
           if (!_matchTopGetter(name: name, element: element)) {
             structureMismatched.add(element);
           }
+        case SetterElementImpl():
+          if (!_matchTopSetter(name: name, element: element)) {
+            structureMismatched.add(element);
+          }
         case TopLevelFunctionElementImpl():
           if (!_matchTopFunction(name: name, element: element)) {
             structureMismatched.add(element);
@@ -718,4 +746,24 @@ class _LibraryMatch {
     refExternalIds.addAll(matchContext.externalIds);
     return true;
   }
+
+  bool _matchTopSetter({
+    required LookupName? name,
+    required SetterElementImpl element,
+  }) {
+    var item = manifest.items[name];
+    if (item is! TopLevelSetterItem) {
+      return false;
+    }
+
+    var matchContext = item.match(element);
+    if (matchContext == null) {
+      return false;
+    }
+
+    itemMap[element] = item;
+    refElementsMap[element] = matchContext.elementList;
+    refExternalIds.addAll(matchContext.externalIds);
+    return true;
+  }
 }

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -514,7 +514,7 @@ class TopLevelGetterItem extends TopLevelItem {
     sink.writeUri(libraryUri);
     name.write(sink);
     id.write(sink);
-    sink.writeList(metadata, (annotation) => annotation.write(sink));
+    metadata.writeList(sink);
     returnType.write(sink);
   }
 }
@@ -546,19 +546,98 @@ sealed class TopLevelItem extends ManifestItem {
         return TopLevelFunctionItem.read(reader);
       case _ManifestItemKind.topLevelGetter:
         return TopLevelGetterItem.read(reader);
+      case _ManifestItemKind.topLevelSetter:
+        return TopLevelSetterItem.read(reader);
     }
   }
 }
 
+class TopLevelSetterItem extends TopLevelItem {
+  final List<ManifestAnnotation> metadata;
+  final ManifestType valueType;
+
+  TopLevelSetterItem({
+    required super.libraryUri,
+    required super.name,
+    required super.id,
+    required this.metadata,
+    required this.valueType,
+  });
+
+  factory TopLevelSetterItem.fromElement({
+    required LookupName name,
+    required ManifestItemId id,
+    required EncodeContext context,
+    required SetterElementImpl element,
+  }) {
+    return TopLevelSetterItem(
+      libraryUri: element.library2.uri,
+      name: name,
+      id: id,
+      metadata: element.metadata2.annotations.map((annotation) {
+        return ManifestAnnotation.encode(context, annotation);
+      }).toFixedList(),
+      valueType: element.formalParameters[0].type.encode(context),
+    );
+  }
+
+  factory TopLevelSetterItem.read(SummaryDataReader reader) {
+    return TopLevelSetterItem(
+      libraryUri: reader.readUri(),
+      name: LookupName.read(reader),
+      id: ManifestItemId.read(reader),
+      metadata: reader.readTypedList(() => ManifestAnnotation.read(reader)),
+      valueType: ManifestType.read(reader),
+    );
+  }
+
+  MatchContext? match(SetterElementImpl element) {
+    var context = MatchContext(parent: null);
+
+    var annotations = element.metadata2.annotations;
+    if (annotations.length != metadata.length) {
+      return null;
+    }
+    for (var i = 0; i < metadata.length; i++) {
+      if (!metadata[i].match(context, annotations[i])) {
+        return null;
+      }
+    }
+
+    if (!valueType.match(context, element.formalParameters[0].type)) {
+      return null;
+    }
+
+    return context;
+  }
+
+  @override
+  void write(BufferedSink sink) {
+    sink.writeEnum(_ManifestItemKind.topLevelSetter);
+    sink.writeUri(libraryUri);
+    name.write(sink);
+    id.write(sink);
+    metadata.writeList(sink);
+    valueType.write(sink);
+  }
+}
+
 enum _ManifestItemKind {
   class_,
   export_,
   topLevelFunction,
   topLevelGetter,
+  topLevelSetter,
 }
 
 enum _ManifestItemKind2 {
   instanceGetter,
   instanceMethod,
   interfaceConstructor,
 }
+
+extension ListOfManifestAnnotationExtension on List<ManifestAnnotation> {
+  void writeList(BufferedSink sink) {
+    sink.writeList(this, (x) => x.write(sink));
+  }
+}