[CFE] Fixes for instrumenter

Change-Id: Ib63140b2a64a9ab1a235d1b8e2e8872e13eecd34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448401
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: jensjoha

pkg/front_end/tool/flame/instrumenter.dart

@@ -247,7 +247,7 @@ class TimerCounterInstrumenterConfig implements InstrumenterConfig {
     Set<String> procedureNamesWantedInFile =
         wanted[p.fileUri.pathSegments.last] ?? const {};
     return procedureNamesWantedInFile.contains(name) ||
-        !procedureNamesWantedInFile.contains("*");
+        procedureNamesWantedInFile.contains("*");
   }
 
   @override

pkg/front_end/tool/flame/instrumenter_lib.dart

@@ -112,22 +112,18 @@ void _processData(WithOutputInfo? withOutputInfo, int factorForMicroSeconds) {
             "${withOutputInfo.names[enterProcedureNumber]}.",
           );
         }
-        bool foundMatch = false;
-        int steps = 1;
+        int? foundAt;
         for (int i = _activeStack.length - 2; i >= 0; i -= 2) {
-          steps++;
           if (_activeStack[i] == procedureNumber) {
-            foundMatch = true;
+            foundAt = i;
             break;
           }
         }
-        if (foundMatch) {
+        if (foundAt != null) {
           _activeStack.add(enterProcedureNumber);
           _activeStack.add(enterTicks);
-          enterProcedureNumber = _activeStack.removeAt(
-            _activeStack.length - steps * 2,
-          );
-          enterTicks = _activeStack.removeAt(_activeStack.length - steps * 2);
+          enterProcedureNumber = _activeStack.removeAt(foundAt);
+          enterTicks = _activeStack.removeAt(foundAt);
           assert(enterProcedureNumber != procedureNumber);
         } else {
           throw "Mismatching enter/exit with no matching "