[model] Mark erroneously initialized optional parameters as such

This adds the flag isErroneouslyInitialized to the VariableDeclaration
AST node in Kernel. The flag is set to true whenever it is concluded
during compilation that the initializer contains errors is erroneous
for the parameter in any other way, for exaple, due to a type mismatch.

Change-Id: I1b3c9c662974fb9537ab4f89b58dd004979feebe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431862
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/builder/formal_parameter_builder.dart

@@ -6,7 +6,13 @@ import 'package:_fe_analyzer_shared/src/parser/formal_parameter_kind.dart'
     show FormalParameterKind;
 import 'package:_fe_analyzer_shared/src/scanner/scanner.dart' show Token;
 import 'package:kernel/ast.dart'
-    show DartType, DynamicType, Expression, NullLiteral, VariableDeclaration;
+    show
+        DartType,
+        DynamicType,
+        Expression,
+        InvalidExpression,
+        NullLiteral,
+        VariableDeclaration;
 import 'package:kernel/class_hierarchy.dart';
 
 import '../base/constant_context.dart' show ConstantContext;
@@ -282,6 +288,9 @@ class FormalParameterBuilder extends NamedBuilderImpl
         initializer = bodyBuilder.typeInferrer.inferParameterInitializer(
             bodyBuilder, initializer, variable!.type, hasDeclaredInitializer);
         variable!.initializer = initializer..parent = variable;
+        if (initializer is InvalidExpression) {
+          variable!.isErroneouslyInitialized = true;
+        }
         initializerWasInferred = true;
         bodyBuilder.performBacklogComputations();
       } else if (kind.isOptional) {

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -1242,6 +1242,9 @@ class BodyBuilder extends StackListenerImpl
                 originParameter.type,
                 parameter.hasDeclaredInitializer);
             originParameter.initializer = initializer..parent = originParameter;
+            if (initializer is InvalidExpression) {
+              originParameter.isErroneouslyInitialized = true;
+            }
             parameter.initializerWasInferred = true;
           }
           VariableDeclaration? tearOffParameter =

pkg/front_end/lib/src/source/source_library_builder.dart

@@ -1424,6 +1424,7 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
               formal.fileOffset,
               formal.name.length,
               formal.fileUri);
+          formal.variable?.isErroneouslyInitialized = true;
         }
       }
     }

pkg/front_end/testcases/extension_types/issue56402.dart.strong.expect

@@ -40,13 +40,13 @@ static extension-type-member method E|constructor#(core::int x) → self::E% /*
 }
 static extension-type-member synthetic method E|constructor#_#new#tearOff(core::int x) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#(x);
-static extension-type-member method E|constructor#testPositional([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testPositional([erroneously-initialized core::int x = #C1, erroneously-initialized core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }
 static extension-type-member synthetic method E|constructor#_#testPositional#tearOff([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#testPositional(x, y);
-static extension-type-member method E|constructor#testNamed({core::int x = #C1, core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testNamed({erroneously-initialized core::int x = #C1, erroneously-initialized core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }

pkg/front_end/testcases/extension_types/issue56402.dart.strong.modular.expect

@@ -40,13 +40,13 @@ static extension-type-member method E|constructor#(core::int x) → self::E% /*
 }
 static extension-type-member synthetic method E|constructor#_#new#tearOff(core::int x) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#(x);
-static extension-type-member method E|constructor#testPositional([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testPositional([erroneously-initialized core::int x = #C1, erroneously-initialized core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }
 static extension-type-member synthetic method E|constructor#_#testPositional#tearOff([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#testPositional(x, y);
-static extension-type-member method E|constructor#testNamed({core::int x = #C1, core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testNamed({erroneously-initialized core::int x = #C1, erroneously-initialized core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }

pkg/front_end/testcases/extension_types/issue56402.dart.strong.outline.expect

@@ -38,11 +38,11 @@ static extension-type-member method E|constructor#(core::int x) → self::E% /*
   ;
 static extension-type-member synthetic method E|constructor#_#new#tearOff(core::int x) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#(x);
-static extension-type-member method E|constructor#testPositional([core::int x = null, core::int y = null]) → self::E% /* erasure=core::int, declared=! */
+static extension-type-member method E|constructor#testPositional([erroneously-initialized core::int x = null, erroneously-initialized core::int y = null]) → self::E% /* erasure=core::int, declared=! */
   ;
 static extension-type-member synthetic method E|constructor#_#testPositional#tearOff([core::int x, core::int y]) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#testPositional(x, y);
-static extension-type-member method E|constructor#testNamed({core::int x = null, core::String y = null}) → self::E% /* erasure=core::int, declared=! */
+static extension-type-member method E|constructor#testNamed({erroneously-initialized core::int x = null, erroneously-initialized core::String y = null}) → self::E% /* erasure=core::int, declared=! */
   ;
 static extension-type-member synthetic method E|constructor#_#testNamed#tearOff({core::int x, core::String y}) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#testNamed(x: x, y: y);

pkg/front_end/testcases/extension_types/issue56402.dart.strong.transformed.expect

@@ -40,13 +40,13 @@ static extension-type-member method E|constructor#(core::int x) → self::E% /*
 }
 static extension-type-member synthetic method E|constructor#_#new#tearOff(core::int x) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#(x);
-static extension-type-member method E|constructor#testPositional([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testPositional([erroneously-initialized core::int x = #C1, erroneously-initialized core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }
 static extension-type-member synthetic method E|constructor#_#testPositional#tearOff([core::int x = #C1, core::int y = #C1]) → self::E% /* erasure=core::int, declared=! */
   return self::E|constructor#testPositional(x, y);
-static extension-type-member method E|constructor#testNamed({core::int x = #C1, core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
+static extension-type-member method E|constructor#testNamed({erroneously-initialized core::int x = #C1, erroneously-initialized core::String y = #C1}) → self::E% /* erasure=core::int, declared=! */ {
   lowered final self::E% /* erasure=core::int, declared=! */ #this = x;
   return #this;
 }

pkg/front_end/testcases/extension_types/nullability.dart.strong.expect

@@ -267,8 +267,8 @@ static method testNotNullable(self::E1<core::num?>% /* erasure=core::num?, decla
   e4NNNullable = null;
   e5NNNullable = null;
 }
-static method testOptionalPositional([self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP = #C1, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP = #C1, self::E2% /* erasure=core::Object?, declared=! */ e2OP = #C1, self::E3% /* erasure=core::String?, declared=! */ e3OP = #C1, self::E4% /* erasure=core::int, declared=! */ e4OP = #C1, self::E5% /* erasure=core::Object?, declared=! */ e5OP = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable = #C1, self::E2? /* erasure=core::Object? */ e2OPNullable = #C1, self::E3? /* erasure=core::String? */ e3OPNullable = #C1, self::E4? /* erasure=core::int? */ e4OPNullable = #C1, self::E5? /* erasure=core::Object? */ e5OPNullable = #C1]) → dynamic {}
-static method testNamedNotRequired({self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR = #C1, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR = #C1, self::E2% /* erasure=core::Object?, declared=! */ e2NNR = #C1, self::E3% /* erasure=core::String?, declared=! */ e3NNR = #C1, self::E4% /* erasure=core::int, declared=! */ e4NNR = #C1, self::E5% /* erasure=core::Object?, declared=! */ e5NNR = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable = #C1, self::E2? /* erasure=core::Object? */ e2NNRNullable = #C1, self::E3? /* erasure=core::String? */ e3NNRNullable = #C1, self::E4? /* erasure=core::int? */ e4NNRNullable = #C1, self::E5? /* erasure=core::Object? */ e5NNRNullable = #C1}) → dynamic {}
+static method testOptionalPositional([erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP = #C1, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP = #C1, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2OP = #C1, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3OP = #C1, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4OP = #C1, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5OP = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable = #C1, self::E2? /* erasure=core::Object? */ e2OPNullable = #C1, self::E3? /* erasure=core::String? */ e3OPNullable = #C1, self::E4? /* erasure=core::int? */ e4OPNullable = #C1, self::E5? /* erasure=core::Object? */ e5OPNullable = #C1]) → dynamic {}
+static method testNamedNotRequired({erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR = #C1, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR = #C1, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2NNR = #C1, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3NNR = #C1, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4NNR = #C1, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5NNR = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable = #C1, self::E2? /* erasure=core::Object? */ e2NNRNullable = #C1, self::E3? /* erasure=core::String? */ e3NNRNullable = #C1, self::E4? /* erasure=core::int? */ e4NNRNullable = #C1, self::E5? /* erasure=core::Object? */ e5NNRNullable = #C1}) → dynamic {}
 
 constants  {
   #C1 = null

pkg/front_end/testcases/extension_types/nullability.dart.strong.modular.expect

@@ -267,8 +267,8 @@ static method testNotNullable(self::E1<core::num?>% /* erasure=core::num?, decla
   e4NNNullable = null;
   e5NNNullable = null;
 }
-static method testOptionalPositional([self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP = #C1, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP = #C1, self::E2% /* erasure=core::Object?, declared=! */ e2OP = #C1, self::E3% /* erasure=core::String?, declared=! */ e3OP = #C1, self::E4% /* erasure=core::int, declared=! */ e4OP = #C1, self::E5% /* erasure=core::Object?, declared=! */ e5OP = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable = #C1, self::E2? /* erasure=core::Object? */ e2OPNullable = #C1, self::E3? /* erasure=core::String? */ e3OPNullable = #C1, self::E4? /* erasure=core::int? */ e4OPNullable = #C1, self::E5? /* erasure=core::Object? */ e5OPNullable = #C1]) → dynamic {}
-static method testNamedNotRequired({self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR = #C1, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR = #C1, self::E2% /* erasure=core::Object?, declared=! */ e2NNR = #C1, self::E3% /* erasure=core::String?, declared=! */ e3NNR = #C1, self::E4% /* erasure=core::int, declared=! */ e4NNR = #C1, self::E5% /* erasure=core::Object?, declared=! */ e5NNR = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable = #C1, self::E2? /* erasure=core::Object? */ e2NNRNullable = #C1, self::E3? /* erasure=core::String? */ e3NNRNullable = #C1, self::E4? /* erasure=core::int? */ e4NNRNullable = #C1, self::E5? /* erasure=core::Object? */ e5NNRNullable = #C1}) → dynamic {}
+static method testOptionalPositional([erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP = #C1, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP = #C1, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2OP = #C1, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3OP = #C1, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4OP = #C1, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5OP = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable = #C1, self::E2? /* erasure=core::Object? */ e2OPNullable = #C1, self::E3? /* erasure=core::String? */ e3OPNullable = #C1, self::E4? /* erasure=core::int? */ e4OPNullable = #C1, self::E5? /* erasure=core::Object? */ e5OPNullable = #C1]) → dynamic {}
+static method testNamedNotRequired({erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR = #C1, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR = #C1, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2NNR = #C1, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3NNR = #C1, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4NNR = #C1, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5NNR = #C1, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable = #C1, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable = #C1, self::E2? /* erasure=core::Object? */ e2NNRNullable = #C1, self::E3? /* erasure=core::String? */ e3NNRNullable = #C1, self::E4? /* erasure=core::int? */ e4NNRNullable = #C1, self::E5? /* erasure=core::Object? */ e5NNRNullable = #C1}) → dynamic {}
 
 constants  {
   #C1 = null

pkg/front_end/testcases/extension_types/nullability.dart.strong.outline.expect

@@ -130,7 +130,7 @@ static method testNotNonNullable(self::E1<core::num?>% /* erasure=core::num?, de
   ;
 static method testNotNullable(self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNN, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNN, self::E2% /* erasure=core::Object?, declared=! */ e2NN, self::E3% /* erasure=core::String?, declared=! */ e3NN, self::E4% /* erasure=core::int, declared=! */ e4NN, self::E5% /* erasure=core::Object?, declared=! */ e5NN, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNNullable, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNNullable, self::E2? /* erasure=core::Object? */ e2NNNullable, self::E3? /* erasure=core::String? */ e3NNNullable, self::E4? /* erasure=core::int? */ e4NNNullable, self::E5? /* erasure=core::Object? */ e5NNNullable) → dynamic
   ;
-static method testOptionalPositional([self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP, self::E2% /* erasure=core::Object?, declared=! */ e2OP, self::E3% /* erasure=core::String?, declared=! */ e3OP, self::E4% /* erasure=core::int, declared=! */ e4OP, self::E5% /* erasure=core::Object?, declared=! */ e5OP, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable, self::E2? /* erasure=core::Object? */ e2OPNullable, self::E3? /* erasure=core::String? */ e3OPNullable, self::E4? /* erasure=core::int? */ e4OPNullable, self::E5? /* erasure=core::Object? */ e5OPNullable]) → dynamic
+static method testOptionalPositional([erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableOP, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleOP, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2OP, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3OP, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4OP, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5OP, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableOPNullable, self::E1<core::double>? /* erasure=core::double? */ e1doubleOPNullable, self::E2? /* erasure=core::Object? */ e2OPNullable, self::E3? /* erasure=core::String? */ e3OPNullable, self::E4? /* erasure=core::int? */ e4OPNullable, self::E5? /* erasure=core::Object? */ e5OPNullable]) → dynamic
   ;
-static method testNamedNotRequired({self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR, self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR, self::E2% /* erasure=core::Object?, declared=! */ e2NNR, self::E3% /* erasure=core::String?, declared=! */ e3NNR, self::E4% /* erasure=core::int, declared=! */ e4NNR, self::E5% /* erasure=core::Object?, declared=! */ e5NNR, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable, self::E2? /* erasure=core::Object? */ e2NNRNullable, self::E3? /* erasure=core::String? */ e3NNRNullable, self::E4? /* erasure=core::int? */ e4NNRNullable, self::E5? /* erasure=core::Object? */ e5NNRNullable}) → dynamic
+static method testNamedNotRequired({erroneously-initialized self::E1<core::num?>% /* erasure=core::num?, declared=! */ e1numNullableNNR, erroneously-initialized self::E1<core::double>% /* erasure=core::double, declared=! */ e1doubleNNR, erroneously-initialized self::E2% /* erasure=core::Object?, declared=! */ e2NNR, erroneously-initialized self::E3% /* erasure=core::String?, declared=! */ e3NNR, erroneously-initialized self::E4% /* erasure=core::int, declared=! */ e4NNR, erroneously-initialized self::E5% /* erasure=core::Object?, declared=! */ e5NNR, self::E1<core::num?>? /* erasure=core::num? */ e1numNullableNNRNullable, self::E1<core::double>? /* erasure=core::double? */ e1doubleNNRNullable, self::E2? /* erasure=core::Object? */ e2NNRNullable, self::E3? /* erasure=core::String? */ e3NNRNullable, self::E4? /* erasure=core::int? */ e4NNRNullable, self::E5? /* erasure=core::Object? */ e5NNRNullable}) → dynamic
   ;