Roll dart_style 3.1.0 into the SDK.

Change-Id: I6392327cadce5194dabaa719bff945868a690225
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419990
Auto-Submit: Bob Nystrom <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>

Author: munificent

CHANGELOG.md

@@ -73,7 +73,6 @@
 - (Thanks [@FMorschel](https://github.com/FMorschel) for many of the above
   enhancements!)
 
-
 [`unnecessary_ignore`]: http://dart.dev/lints/unnecessary_ignore
 
 #### Dart Development Compiler (dartdevc)
@@ -90,6 +89,175 @@ disallowed.
 
 Removed the `--experiment-new-rti` and `--use-old-rti` flags.
 
+#### Dart format
+
+In 3.7.0, we released a largely rewritten formatter supporting a new
+["tall" style][tall style]. Since then, we've gotten a lot of feedback and bug
+reports and made a number of fixes in response to that.
+
+[tall style]: https://github.com/dart-lang/dart_style/issues/1253
+
+### Features
+
+Some users strongly prefer the old behavior where a trailing comma will be
+preserved by the formatter and force the surrounding construct to split. That
+behavior is supported again (but off by default) and can enabled by adding this
+to a surrounding `analysis_options.yaml` file:
+
+```yaml
+formatter:
+  trailing_commas: preserve
+```
+
+This is similar to how trailing commas work in the old short style formatter
+applied to code before language version 3.7.
+
+### Bug fixes
+
+* Don't add a trailing comma in lists that don't allow it, even when there is
+  a trailing comment (#1639).
+
+### Style changes
+
+The following style changes are language versioned and only affect code whose
+language version is 3.8 or later. Dart code at 3.7 or earlier is formatted the
+same as it was before.
+
+* Allow more code on the same line as a named argument or `=>`.
+
+  ```dart
+  // Before:
+  function(
+    name:
+        (param) => another(
+          argument1,
+          argument2,
+        ),
+  );
+
+  // After:
+  function(
+    name: (param) => another(
+      argument1,
+      argument3,
+    ),
+  );
+  ```
+
+* Allow the target or property chain part of a split method chain on the RHS of
+  `=`, `:`, and `=>`.
+
+  ```dart
+  // Before:
+  variable =
+      target.property
+          .method()
+          .another();
+
+  // After:
+  variable = target.property
+      .method()
+      .another();
+  ```
+
+* Allow the condition part of a split conditional expression on the RHS of `=`,
+  `:`, and `=>`.
+
+  ```dart
+  // Before:
+  variable =
+      condition
+      ? longThenBranch
+      : longElseBranch;
+
+  // After:
+  variable = condition
+      ? longThenBranch
+      : longElseBranch;
+  ```
+
+* Don't indent conditional branches redundantly after `=`, `:`, and `=>`.
+
+  ```dart
+  // Before:
+  function(
+    argument:
+        condition
+            ? thenBranch
+            : elseBranch,
+  )
+
+  // After:
+  function(
+    argument:
+        condition
+        ? thenBranch
+        : elseBranch,
+  )
+  ```
+
+* Indent conditional branches past the operators.
+
+  ```dart
+  // Before:
+  condition
+      ? thenBranch +
+          anotherOperand
+      : elseBranch(
+        argument,
+      );
+
+  // After:
+  condition
+      ? thenBranch +
+            anotherOperand
+      : elseBranch(
+          argument,
+        );
+  ```
+
+* Block format record types in typedefs:
+
+  ```dart
+  // Before:
+  typedef ExampleRecordTypedef =
+      (
+        String firstParameter,
+        int secondParameter,
+        String thirdParameter,
+        String fourthParameter,
+      );
+
+  // After:
+  typedef ExampleRecordTypedef = (
+    String firstParameter,
+    int secondParameter,
+    String thirdParameter,
+    String fourthParameter,
+  );
+  ```
+
+* Eagerly split argument lists whose contents are complex enough to be easier
+  to read spread across multiple lines even if they would otherwise fit on a
+  single line.
+
+  The heuristic is that the argument list must contain at least three named
+  arguments, some of which are nested and some of which are not.
+
+  ```dart
+  // Before:
+  TabBar(tabs: [Tab(text: 'A'), Tab(text: 'B')], labelColor: Colors.white70);
+
+  // After:
+  TabBar(
+    tabs: [
+      Tab(text: 'A'),
+      Tab(text: 'B'),
+    ],
+    labelColor: Colors.white70,
+  );
+  ```
+
 ## 3.7.0
 
 **Released on:** 2025-02-12

DEPS

@@ -125,7 +125,7 @@ vars = {
   #   and land the review.
   #
   # For more details, see https://github.com/dart-lang/sdk/issues/30164.
-  "dart_style_rev": "21de99ec0ff8ace4d946a746fb427fffd6afa535", # rolled manually
+  "dart_style_rev": "100db45075abdd66fd8788b205243e90ff0595df", # rolled manually
 
   ### /third_party/pkg dependencies
   # 'tools/rev_sdk_deps.dart' will rev pkg dependencies to their latest; put an

PRESUBMIT.py

@@ -104,6 +104,10 @@ def load_source(modname, filename):
 
 
 def _CheckDartFormat(input_api, output_api):
+    # TODO(rnystrom): Dart format presubmit checks are temporarily disabled
+    # while rolling the new formatter into the SDK.
+    return []
+
     local_root = input_api.change.RepositoryRoot()
     utils = load_source('utils', os.path.join(local_root, 'tools', 'utils.py'))
 

pkg/compiler/test/tool/graph_isomorphizer/golden/simple/libImport.dart

@@ -19,7 +19,8 @@ mixin M_100 {}
 class T_100 {}
 
 const C_100 iC_100 = const C_100();
-closureC_100(foo) => (C_100 unused) => iC_100.toString() == foo.toString();
+closureC_100(foo) =>
+    (C_100 unused) => iC_100.toString() == foo.toString();
 
 class C_101 {
   const C_101();
@@ -30,7 +31,8 @@ mixin M_101 {}
 class T_101 {}
 
 const C_101 iC_101 = const C_101();
-closureC_101(foo) => (C_101 unused) => iC_101.toString() == foo.toString();
+closureC_101(foo) =>
+    (C_101 unused) => iC_101.toString() == foo.toString();
 
 class C_111 {
   const C_111();
@@ -41,7 +43,8 @@ mixin M_111 {}
 class T_111 {}
 
 const C_111 iC_111 = const C_111();
-closureC_111(foo) => (C_111 unused) => iC_111.toString() == foo.toString();
+closureC_111(foo) =>
+    (C_111 unused) => iC_111.toString() == foo.toString();
 
 class C_010 {
   const C_010();
@@ -52,7 +55,8 @@ mixin M_010 {}
 class T_010 {}
 
 const C_010 iC_010 = const C_010();
-closureC_010(foo) => (C_010 unused) => iC_010.toString() == foo.toString();
+closureC_010(foo) =>
+    (C_010 unused) => iC_010.toString() == foo.toString();
 
 class C_011 {
   const C_011();
@@ -63,7 +67,8 @@ mixin M_011 {}
 class T_011 {}
 
 const C_011 iC_011 = const C_011();
-closureC_011(foo) => (C_011 unused) => iC_011.toString() == foo.toString();
+closureC_011(foo) =>
+    (C_011 unused) => iC_011.toString() == foo.toString();
 
 class C_001 {
   const C_001();
@@ -74,7 +79,8 @@ mixin M_001 {}
 class T_001 {}
 
 const C_001 iC_001 = const C_001();
-closureC_001(foo) => (C_001 unused) => iC_001.toString() == foo.toString();
+closureC_001(foo) =>
+    (C_001 unused) => iC_001.toString() == foo.toString();
 
 class C_101_class_1 extends C_100
     with M_100, M_101, M_111, M_001

pkg/dartdev/lib/src/templates/server_shelf.dart

@@ -117,10 +117,9 @@ import 'package:shelf/shelf_io.dart';
 import 'package:shelf_router/shelf_router.dart';
 
 // Configure routes.
-final _router =
-    Router()
-      ..get('/', _rootHandler)
-      ..get('/echo/<message>', _echoHandler);
+final _router = Router()
+  ..get('/', _rootHandler)
+  ..get('/echo/<message>', _echoHandler);
 
 Response _rootHandler(Request req) {
   return Response.ok('Hello, World!\n');