Skip to content

Commit 13507d2

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[test] Don't test the profiler in a test with a large number of threads.
TSAN's vector clocks become more expensive as the number of threads that touch a variable increases. The Mac/Windows/Fuchsia profilers will sample threads by suspending it and accessing it from another thread. TEST=ci Bug: #61960 Change-Id: I2bfb7908af8ff864bc52577bacbb89a4778150d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465980 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent ebfddeb commit 13507d2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/ffi/many_listener_callbacks_test.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111
// VMOptions=--use-slow-path --stacktrace-every=100
1212
// VMOptions=--dwarf_stack_traces --no-retain_function_objects --no-retain_code_objects
1313
// VMOptions=--test_il_serialization
14-
// VMOptions=--profiler --profile_vm=true
15-
// VMOptions=--profiler --profile_vm=false
1614
// SharedObjects=ffi_test_functions
1715

16+
// No profiler for this test. TSAN's vector clocks become more expensive as the
17+
// number of threads that touch a variable increases. This test creates many
18+
// threads, and the Mac/Windows/Fuchsia profilers will sample them from another
19+
// thread.
20+
1821
import 'dart:async';
1922
import 'dart:ffi';
2023

0 commit comments

Comments
 (0)