[dartdev] Don't ignore the --define option in dart run

An earlier comment in the source specifies options have to be specified in both places to not be ignored.

Fixes #61373 which is a regression in current 3.10 beta and dev releases.

TEST=pkg/dartdev/test/commands/run_test.dart
Change-Id: Ideae8638dce8ff530f7c46735d6cd7e9cd9a2836
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446681
Commit-Queue: Slava Egorov <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>

Author: parlough

pkg/dartdev/test/commands/run_test.dart

@@ -383,6 +383,31 @@ void main(List<String> args) => print("$b $args");
     ], onData3);
   });
 
+  test('with VM environment declaration options specified', () async {
+    p = project(mainSrc: r'''
+    void main() {
+      print(const bool.fromEnvironment('key'));
+    }
+    ''');
+
+    final result =
+        await p.run(['run', '--define=key=true', p.relativeFilePath]);
+
+    expect(result.stderr, isEmpty);
+    expect(result.stdout, contains('true'));
+    expect(result.exitCode, 0);
+
+    final abbreviationResult = await p.run([
+      'run',
+      '-Dkey=true',
+      p.relativeFilePath,
+    ]);
+
+    expect(abbreviationResult.stderr, isEmpty);
+    expect(abbreviationResult.stdout, contains('true'));
+    expect(abbreviationResult.exitCode, 0);
+  });
+
   test('with accepted VM flags related to the timeline', () async {
     p = project(
         mainSrc: 'import "dart:developer";'

runtime/bin/dartdev_options.cc

@@ -118,6 +118,8 @@ bool Options::ProcessVMOptions(const char* arg,
   V("--disable-service-auth-codes", arg)                                       \
   V("--write-service-info", arg)                                               \
   V("--enable-service-port-fallback", arg)                                     \
+  V("--define", arg)                                                           \
+  V("-D", arg)                                                                 \
   V("--disable-service-auth-codes", arg)                                       \
   V("--serve-observatory", arg)                                                \
   V("--print-dtd", arg)                                                        \