Skip to content

Commit 13f5fc6

Browse files
derekxu16Commit Queue
authored andcommitted
[VM/Service] Fix evaluate_with_scope_with_resident_compiler_test
This test is currently marked as flaky (https://dart-current-results.web.app/#/filter=pkg/vm_service/test/evaluate_with_scope_with_resident_compiler_test&showAll) and I believe that this change will fix it. Issue: #59909 Change-Id: Ib13d298347c1ebd768e4c9ac8fd5449e8291c870 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410780 Commit-Queue: Derek Xu <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
1 parent 7188447 commit 13f5fc6

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

pkg/vm_service/test/evaluate_with_scope_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ Future<void> main([args = const <String>[]]) => runIsolateTests(
1010
evaluteWithScopeTests,
1111
'evaluate_with_scope_test.dart',
1212
testeeBefore: testeeMain,
13+
pauseOnExit: true,
1314
);

pkg/vm_service/test/evaluate_with_scope_test_common.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'package:test/test.dart';
66
import 'package:vm_service/vm_service.dart';
77

8-
import 'common/test_helper.dart';
8+
import 'common/service_test_common.dart';
99

1010
int? thing1;
1111
int? thing2;
@@ -24,6 +24,7 @@ Future<InstanceRef> evaluate(VmService service, isolate, target, x, y) async =>
2424
) as InstanceRef;
2525

2626
final evaluteWithScopeTests = <IsolateTest>[
27+
hasStoppedAtExit,
2728
(VmService service, IsolateRef isolateRef) async {
2829
final isolateId = isolateRef.id!;
2930
final isolate = await service.getIsolate(isolateId);

pkg/vm_service/test/evaluate_with_scope_with_resident_compiler_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@ Future<void> main([args = const <String>[]]) => runIsolateTests(
1010
evaluteWithScopeTests,
1111
'evaluate_with_scope_with_resident_compiler_test.dart',
1212
testeeBefore: testeeMain,
13+
pauseOnExit: true,
1314
shouldTesteeBeLaunchedWithDartRunResident: true,
1415
);

0 commit comments

Comments
 (0)