Skip to content

Commit 1499a30

Browse files
aamCommit Queue
authored andcommitted
[gardening] Fix httpIG sample test, update new isolate_group_bound test status on fuchsia.
Fix failures https://dart-ci.appspot.com/log/vm-linux-release-x64/vm-linux-release-x64/6082/samples/ffi/httpIG/test/http_test Lift .status-file constraints on where http and httpIG samples can run. Follow-up to b759d09 TEST=ci Change-Id: Icc71d6407e910d30f6ff028830550a05b179f1da Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444927 Commit-Queue: Alexander Aprelev <[email protected]> Reviewed-by: Ryan Macnak <[email protected]>
1 parent 5e2dc27 commit 1499a30

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

samples/ffi/httpIG/lib/http.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'package:ffi/ffi.dart';
1212

1313
import 'dylib_utils.dart';
1414

15-
Function (Pointer<Utf8>) createGetSender(SendPort sendPort) {
15+
Function (Pointer<Utf8>) createGetSender(final SendPort sendPort) {
1616
return (Pointer<Utf8> responsePointer) {
1717
final typedList = responsePointer.cast<Uint8>().asTypedList(
1818
responsePointer.length,
@@ -57,7 +57,7 @@ Future<String> httpGet(String uri) async {
5757
@pragma('vm:shared')
5858
late int counter;
5959

60-
Function (Pointer<Utf8>) createServeSender(SendPort sendPort) {
60+
Function (Pointer<Utf8>) createServeSender(final SendPort sendPort) {
6161
return (Pointer<Utf8> requestPointer) {
6262
counter++;
6363
final typedList = requestPointer.cast<Uint8>().asTypedList(

samples/samples.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ ffi/*: SkipByDesign # FFI skips, see ffi.status
1515
*: Skip # Not yet triaged.
1616

1717
[ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ]
18-
ffi/http/test/http_test: SkipByDesign
19-
ffi/httpIG/test/http_test: SkipByDesign
2018
ffi/sqlite/test/sqlite_test: SkipByDesign # FFI not supported or libsqlite3.so not available.
2119

2220
[ $runtime == d8 || $browser ]

tests/ffi/ffi.status

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ function_callbacks_structs_by_value_generated_test/*: Skip # Test harness doesn'
5858
function_callbacks_structs_by_value_native_callable_generated_test/*: Skip # Test harness doesn't support multitest with Fuchsia
5959
function_callbacks_subtype_test/*: Skip # Test harness doesn't support multitest with Fuchsia
6060
isolate_group_bound_callback_test: Skip # gen_snapshot requires experimental-shared-data flag
61+
isolate_group_bound_captured_local_test: Skip # gen_snapshot requires experimental-shared-data flag
6162
isolate_group_bound_init_test: Skip # gen_snapshot requires experimental-shared-data flag
6263
isolate_group_bound_send_test: Skip # gen_snapshot requires experimental-shared-data flag
6364
native_assets/*: Skip # Source not available in the emulator

0 commit comments

Comments
 (0)