Skip to content

Commit 14ce41b

Browse files
jensjohaCommit Queue
authored andcommitted
[CFE] (Temporarily?) disable coverage on weekly bot
The weekly bot has failed for the last two weeks (turned purple, not actually failed) --- and there's no actual loging about what's going on. This CL disables coverage with a theory that running the coverage uses too much ram (e.g. `large_app_benchmark_test.dart` which is run as part of the coverage uses ~15GB on its own). If it turns out to work we might consider trying something like https://dart-review.googlesource.com/c/sdk/+/460421 to make the test use less ram. Change-Id: I80994793fd89529baca1c97d2d31ee549858a315 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460440 Commit-Queue: Johnni Winther <[email protected]> Auto-Submit: Jens Johansen <[email protected]> Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Jens Johansen <[email protected]>
1 parent 790d844 commit 14ce41b

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

pkg/front_end/test/weekly_tester.dart

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ import 'dart:async' show Future;
66
import 'dart:convert' show LineSplitter, utf8;
77
import 'dart:io' show File, Platform, Process, ProcessResult;
88

9+
// Temporarily disable because the weekly bot fails - maybe because of this?
10+
const bool doCoverage = false;
11+
912
Future<void> main(List<String> args) async {
1013
// General idea: Launch - in separate processes - whatever we want to run
1114
// concurrently, capturing the stdout and stderr, printing it with some
@@ -111,12 +114,14 @@ Future<void> main(List<String> args) async {
111114
}
112115

113116
// Now run all coverage and print a diff.
114-
WrappedProcess coverageProcess = await run([
115-
Platform.script.resolve("run_all_coverage_update.dart").toString(),
116-
], "coverage update");
117-
await coverageProcess.process.exitCode;
118-
ProcessResult coverageDiffResult = Process.runSync("git", ["diff"]);
119-
print(coverageDiffResult.stdout);
117+
if (doCoverage) {
118+
WrappedProcess coverageProcess = await run([
119+
Platform.script.resolve("run_all_coverage_update.dart").toString(),
120+
], "coverage update");
121+
await coverageProcess.process.exitCode;
122+
ProcessResult coverageDiffResult = Process.runSync("git", ["diff"]);
123+
print(coverageDiffResult.stdout);
124+
}
120125

121126
if (shouldThrow) throw "There were failures!";
122127
}

0 commit comments

Comments
 (0)