Skip to content

Commit 1511cbe

Browse files
stereotype441Commit Queue
authored andcommitted
Ensure appropriate code review of changes to the analyzer public API.
This change uses Gerrit OWNERS file syntax (documented here: https://gerrit.googlesource.com/plugins/find-owners/+/HEAD/src/main/resources/Documentation/syntax.md?pli=1) to ensure that any changes affecting pkg/analyzer/api.txt will be reviewed by the developer experience team (or one of the last resort global reviewers), rather than the Dart Model team. Since changes to the analyzer that affect its public API will inevitably affect both .dart files in pkg/analyzer (or pkg/_fe_analyzer_shared) as well as pkg/analyzer/api.txt, this ownership change ensures that any change affecting the analyzer public API will be reviewed both by a member of the Dart Model team and by a member of the developer experience team. Change-Id: I07527efe1fa7aa3f1d75488c1800410c2aaaa6ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410660 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 999f39e commit 1511cbe

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

pkg/analyzer/OWNERS

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,8 @@
11
file:/tools/OWNERS_MODEL
2+
3+
# api.txt is a generated file that documents the types and methods in
4+
# the analyzer public API; accordingly, changes to it need to be
5+
# reviewed by the developer experience team.
6+
per-file api.txt=set noparent
7+
per-file api.txt=file:/tools/OWNERS_DEVELOPER_EXPERIENCE
8+
per-file api.txt=file:/OWNERS # (For last resort global approvers)

0 commit comments

Comments
 (0)