[DAS] Differentiates tearoff fixes from invocation fixes for methods and functions

This is mostly a no-op change to make clear to anyone reading the tests that we should probably make sure both cases are covered. This is a step towards #61186 (comment) which will be handled in a separate CL.

Bug: #61186
Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444384
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart

@@ -27,7 +27,10 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer {
 
   factory CreateMethodOrFunction({required CorrectionProducerContext context}) {
     if (context is StubCorrectionProducerContext) {
-      return CreateMethodOrFunction._(context: context);
+      return CreateMethodOrFunction._(
+        context: context,
+        fixKind: DartFixKind.CREATE_FUNCTION_TEAROFF,
+      );
     }
 
     if (context.node case SimpleIdentifier node) {
@@ -54,18 +57,21 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer {
         targetElement: targetElement,
         fixKind:
             targetElement is InterfaceElement
-                ? DartFixKind.CREATE_METHOD
-                : DartFixKind.CREATE_FUNCTION,
+                ? DartFixKind.CREATE_METHOD_TEAROFF
+                : DartFixKind.CREATE_FUNCTION_TEAROFF,
       );
     }
 
-    return CreateMethodOrFunction._(context: context);
+    return CreateMethodOrFunction._(
+      context: context,
+      fixKind: DartFixKind.CREATE_FUNCTION_TEAROFF,
+    );
   }
 
   CreateMethodOrFunction._({
     required super.context,
     Element? targetElement,
-    this.fixKind = DartFixKind.CREATE_METHOD,
+    required this.fixKind,
   }) : _targetElement = targetElement;
 
   @override

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -808,6 +808,11 @@ abstract final class DartFixKind {
     DartFixKindPriority.standard - 1,
     "Create function '{0}'",
   );
+  static const CREATE_FUNCTION_TEAROFF = FixKind(
+    'dart.fix.create.function.tearoff',
+    DartFixKindPriority.standard - 1,
+    "Create function '{0}'",
+  );
   static const CREATE_GETTER = FixKind(
     'dart.fix.create.getter',
     DartFixKindPriority.standard,
@@ -823,6 +828,11 @@ abstract final class DartFixKind {
     DartFixKindPriority.standard,
     "Create method '{0}'",
   );
+  static const CREATE_METHOD_TEAROFF = FixKind(
+    'dart.fix.create.method.tearoff',
+    DartFixKindPriority.standard,
+    "Create method '{0}'",
+  );
 
   // TODO(pq): used by LintNames.hash_and_equals; consider removing.
   static const CREATE_METHOD_MULTI = FixKind(