Skip to content

Commit 1597303

Browse files
lrhnCommit Queue
authored andcommitted
Make VM int parsing not use static global non-constant tables.
In anticipation of isolate-group code execution. While there, made it skip leading zeros before doing length-based choices for parsing. Tested: Refactoring, not change in behavior. Bug: https://dartbug.com/61030 Change-Id: I4b27b3b85b263c67fe0066eff85172a20f0fed5b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442680 Commit-Queue: Lasse Nielsen <[email protected]> Reviewed-by: Martin Kustermann <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
1 parent db36ab2 commit 1597303

File tree

3 files changed

+324
-164
lines changed

3 files changed

+324
-164
lines changed

sdk/lib/_internal/vm/lib/double_patch.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ class double {
7272
} else if ((c | 0x20) == _e) {
7373
i++;
7474
if (i == end) return null;
75-
// int._tryParseSmi treats its end argument as inclusive.
76-
final int? expPart = int._tryParseSmi(str, i, end - 1);
75+
final int? expPart = int._tryParseSmi(str, i, end);
7776
if (expPart == null) return null;
7877
exponent += expPart;
7978
break;

0 commit comments

Comments
 (0)