Skip to content

Commit 15f8c42

Browse files
FMorschelCommit Queue
authored andcommitted
[DAS] Adds tests for create extension member fixes for Object? target
I'd already added the required fixes to the specific diagnostics at 2175df0 so this only adds tests for them. Bug: #61192 Change-Id: Ia49cd4ddb68ad04fc0eab0a02614959fa2296759 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447280 Auto-Submit: Felipe Morschel <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
1 parent 385bd8f commit 15f8c42

File tree

1 file changed

+68
-0
lines changed

1 file changed

+68
-0
lines changed

pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,23 @@ extension E on int {
250250
''');
251251
}
252252

253+
Future<void> test_nullableObject_target() async {
254+
await resolveTestCode('''
255+
void f(Object? o) {
256+
int _ = o.test;
257+
}
258+
''');
259+
await assertHasFix('''
260+
void f(Object? o) {
261+
int _ = o.test;
262+
}
263+
264+
extension on Object? {
265+
int get test => null;
266+
}
267+
''');
268+
}
269+
253270
Future<void> test_nullableTargetType() async {
254271
await resolveTestCode('''
255272
void f(int? p) {
@@ -827,6 +844,23 @@ extension E on int {
827844
''');
828845
}
829846

847+
Future<void> test_nullableObject_target() async {
848+
await resolveTestCode('''
849+
void f(Object? o) {
850+
int _ = o.test();
851+
}
852+
''');
853+
await assertHasFix('''
854+
void f(Object? o) {
855+
int _ = o.test();
856+
}
857+
858+
extension on Object? {
859+
int test() {}
860+
}
861+
''');
862+
}
863+
830864
Future<void> test_nullableTargetType() async {
831865
await resolveTestCode('''
832866
void f(int? p) {
@@ -1533,6 +1567,23 @@ extension on int {
15331567
''');
15341568
}
15351569

1570+
Future<void> test_nullableObject_target() async {
1571+
await resolveTestCode('''
1572+
void f(Object? o) {
1573+
o + 0;
1574+
}
1575+
''');
1576+
await assertHasFix('''
1577+
void f(Object? o) {
1578+
o + 0;
1579+
}
1580+
1581+
extension on Object? {
1582+
void operator +(int other) {}
1583+
}
1584+
''');
1585+
}
1586+
15361587
Future<void> test_nullableTargetType() async {
15371588
await resolveTestCode('''
15381589
void f(int? p) {
@@ -1746,6 +1797,23 @@ extension on int {}
17461797
''');
17471798
}
17481799

1800+
Future<void> test_nullableObject_target() async {
1801+
await resolveTestCode('''
1802+
void f(Object? o) {
1803+
o.test = 0;
1804+
}
1805+
''');
1806+
await assertHasFix('''
1807+
void f(Object? o) {
1808+
o.test = 0;
1809+
}
1810+
1811+
extension on Object? {
1812+
set test(int test) {}
1813+
}
1814+
''');
1815+
}
1816+
17491817
Future<void> test_nullableTargetType() async {
17501818
await resolveTestCode('''
17511819
void f(int? p) {

0 commit comments

Comments
 (0)