analyzer: Move LinterOptions to the linter package test utilities

Change-Id: I525132a98f2d2a683150393b22ee66b002a4d507
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392244
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -27,7 +27,6 @@ import 'package:analyzer/src/dart/element/type_system.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/lint/linter_visitor.dart' show NodeLintRegistry;
 import 'package:analyzer/src/lint/pub.dart';
-import 'package:analyzer/src/lint/registry.dart';
 import 'package:analyzer/src/lint/state.dart';
 import 'package:analyzer/src/workspace/workspace.dart';
 import 'package:meta/meta.dart';
@@ -183,20 +182,6 @@ final class LinterContextWithResolvedResults implements LinterContext {
   LibraryElement2 get libraryElement2 => libraryElement as LibraryElement2;
 }
 
-class LinterOptions {
-  final Iterable<LintRule> enabledRules;
-
-  /// The path to the Dart SDK.
-  String? dartSdkPath;
-
-  /// Whether to gather timing data during analysis.
-  bool enableTiming = false;
-
-  LinterOptions({
-    Iterable<LintRule>? enabledRules,
-  }) : enabledRules = enabledRules ?? Registry.ruleRegistry;
-}
-
 /// Describes a lint rule.
 abstract class LintRule {
   /// Used to report lint warnings.

pkg/linter/lib/src/analyzer.dart

@@ -21,7 +21,6 @@ export 'package:analyzer/src/lint/linter.dart'
         dart3_3,
         LintRule,
         LinterContext,
-        LinterOptions,
         NodeLintRegistry,
         State;
 export 'package:analyzer/src/lint/pub.dart' show PSEntry, PubspecVisitor;

pkg/linter/lib/src/test_utilities/lint_driver.dart

@@ -13,8 +13,8 @@ import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/src/generated/engine.dart' show AnalysisEngine;
 // ignore: implementation_imports
 import 'package:analyzer/src/lint/io.dart';
-// ignore: implementation_imports
-import 'package:analyzer/src/lint/linter.dart';
+
+import 'linter_options.dart';
 
 import 'analysis_error_info.dart';
 

pkg/linter/lib/src/test_utilities/linter_options.dart

@@ -0,0 +1,22 @@
+// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// ignore: implementation_imports
+import 'package:analyzer/src/lint/linter.dart';
+// ignore: implementation_imports
+import 'package:analyzer/src/lint/registry.dart';
+
+class LinterOptions {
+  final Iterable<LintRule> enabledRules;
+
+  /// The path to the Dart SDK.
+  String? dartSdkPath;
+
+  /// Whether to gather timing data during analysis.
+  bool enableTiming = false;
+
+  LinterOptions({
+    Iterable<LintRule>? enabledRules,
+  }) : enabledRules = enabledRules ?? Registry.ruleRegistry;
+}

pkg/linter/lib/src/test_utilities/test_linter.dart

@@ -13,14 +13,13 @@ import 'package:analyzer/source/source.dart';
 // ignore: implementation_imports
 import 'package:analyzer/src/lint/io.dart';
 // ignore: implementation_imports
-import 'package:analyzer/src/lint/linter.dart';
-// ignore: implementation_imports
 import 'package:analyzer/src/lint/pub.dart';
 import 'package:meta/meta.dart';
 import 'package:path/path.dart' as path;
 
 import 'analysis_error_info.dart';
 import 'lint_driver.dart';
+import 'linter_options.dart';
 
 Source createSource(Uri uri) {
   var filePath = uri.toFilePath();

pkg/linter/lib/src/test_utilities/test_resource_provider.dart

@@ -12,6 +12,7 @@ import 'package:analyzer/src/test_utilities/mock_sdk.dart';
 import 'package:path/path.dart' as path;
 
 import '../analyzer.dart';
+import 'linter_options.dart';
 import 'test_linter.dart';
 
 /// Builds the [TestLinter] with appropriate mock SDK, resource providers, and

pkg/linter/test/engine_test.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/lint/pub.dart';
 import 'package:analyzer/src/string_source.dart' show StringSource;
+import 'package:linter/src/test_utilities/linter_options.dart';
 import 'package:linter/src/test_utilities/test_linter.dart';
 import 'package:linter/src/utils.dart';
 import 'package:test/test.dart';

pkg/linter/tool/benchmark.dart

@@ -16,6 +16,7 @@ import 'package:linter/src/extensions.dart';
 import 'package:linter/src/rules.dart';
 import 'package:linter/src/test_utilities/analysis_error_info.dart';
 import 'package:linter/src/test_utilities/formatter.dart';
+import 'package:linter/src/test_utilities/linter_options.dart';
 import 'package:linter/src/test_utilities/test_linter.dart';
 import 'package:yaml/yaml.dart';