Fine. Fix for NPE when the subclass has missing name.

Change-Id: I103692a062d15fc856992458d04190bb7edc438c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454340
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -1111,10 +1111,11 @@ class LibraryManifestBuilder {
         var classItem = declaredItems[classElement];
         if (classItem != null) {
           classItem as ClassItem;
-          var ids = (classElement.allSubtypes ?? []).map((type) {
-            var item = declaredItems[type.element] as InterfaceItem;
-            return item.id;
-          }).sorted();
+          var ids = (classElement.allSubtypes ?? [])
+              .map((type) => declaredItems[type.element])
+              .whereType<InterfaceItem>()
+              .map((item) => item.id)
+              .sorted();
           classItem.allSubtypes = ManifestItemIdList(ids);
         }
       }

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -55674,6 +55674,54 @@ class D extends B {}
     );
   }
 
+  test_manifest_class_allSubtypes_final_missingName() async {
+    configuration.withElementManifests = true;
+
+    await _runLibraryManifestScenario(
+      initialCode: r'''
+final class A {}
+class extends A {}
+''',
+      expectedInitialEvents: r'''
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/test.dart
+    hashForRequirements: #H0
+    declaredClasses
+      A: #M0
+        flags: isFinal
+        supertype: Object @ dart:core
+        interface: #M1
+    exportMapId: #M2
+    exportMap
+      A: #M0
+''',
+      updatedCode: r'''
+final class A {}
+class extends A {}
+class C extends A {}
+''',
+      expectedUpdatedEvents: r'''
+[operation] linkLibraryCycle
+  package:test/test.dart
+    hashForRequirements: #H1
+    declaredClasses
+      A: #M0
+        flags: isFinal
+        supertype: Object @ dart:core
+        allSubtypes: #M3
+        interface: #M1
+      C: #M3
+        supertype: A @ package:test/test.dart
+        interface: #M4
+    exportMapId: #M5
+    exportMap
+      A: #M0
+      C: #M3
+''',
+    );
+  }
+
   test_manifest_class_allSubtypes_final_mixin() async {
     configuration.withElementManifests = true;