Fine. Write URIs and lookup names as string refs in manifests

Switch serialization of heavily repeated strings (URIs, `LookupName`s,
and select identifiers) from inline UTF-8 blobs to string references
backed by a per-blob string table. Readers now initialize the table from
the end of the buffer, and writers emit it once at the end.

This cuts duplication in library/requirements/diagnostics bundles and
improves both size and speed when analyzing the analyzer:
- size: 112 MB → 62 MB (~45% smaller)
- time: 450 ms → 310 ms (~31% faster)

Key changes
- Use `writeStringReference` / `readStringReference` for:
  - URIs (`writeUri`/`readUri`); parse via `uriCache.parse`.
  - `LookupName`, `BaseName`, and various manifest/type strings
    (e.g., token buffers, member/top-level names, record field names,
    named parameter names).
- Add `writeStringTableAtEnd()` in all writers that produce persisted
  blobs, and `initializeStringTableFromEnd()` in matching readers:
  - `LinkedBundleProvider` (get/put paths)
  - `LibraryDiagnosticsBundle` (toBytes/fromBytes)
  - Manifest and requirements assert-serialization paths
- Bump `AnalysisDriver.DATA_VERSION` to 561 to invalidate old caches.

Why this works
- Manifests and requirements repeat the same URIs and names across many
  entries. Interning them through a string table removes redundancy and
  reduces I/O.
- `uriCache.parse` avoids repeated `Uri` allocations and speeds up
  lookup.

Trade-offs
- Writers must call `writeStringTableAtEnd()` exactly once after all
  payload writes and before `takeBytes()`.
- Readers that consume string references must initialize the table
  before any reference reads.

Change-Id: I2346e02fa34e0f421b6f15ccd485a0d19b00062d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451126
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/binary/binary_reader.dart

@@ -8,6 +8,7 @@ import 'dart:typed_data';
 import 'package:_fe_analyzer_shared/src/scanner/string_canonicalizer.dart';
 import 'package:analyzer/src/binary/binary_writer.dart';
 import 'package:analyzer/src/binary/string_table.dart';
+import 'package:analyzer/src/utilities/uri_cache.dart';
 
 /// Reader for binary formats.
 class BinaryReader {
@@ -261,8 +262,8 @@ class BinaryReader {
   }
 
   Uri readUri() {
-    var uriStr = readStringUtf8();
-    return Uri.parse(uriStr);
+    var uriStr = readStringReference();
+    return uriCache.parse(uriStr);
   }
 
   List<Uri> readUriList() {

pkg/analyzer/lib/src/binary/binary_writer.dart

@@ -297,7 +297,7 @@ class BinaryWriter {
 
   void writeUri(Uri uri) {
     var uriStr = uri.toString();
-    writeStringUtf8(uriStr);
+    writeStringReference(uriStr);
   }
 
   void writeUriList(List<Uri> uriList) {

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 560;
+  static const int DATA_VERSION = 561;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/analysis/library_context.dart

@@ -552,6 +552,7 @@ class LinkedBundleProvider {
 
     performance.getDataInt('bytesLength').add(bytes.length);
     var reader = BinaryReader(bytes);
+    reader.initializeStringTableFromEnd();
     var nonTransitiveApiSignature = reader.readStringUtf8();
     var libraryManifests = reader.readMap(
       readKey: () => reader.readUri(),
@@ -593,7 +594,9 @@ class LinkedBundleProvider {
     entry.requirements.write(writer);
     writer.writeUint8List(entry.linkedBytes);
 
+    writer.writeStringTableAtEnd();
     var bytes = writer.takeBytes();
+
     byteStore.putGet(key, bytes);
     performance.getDataInt('bytes').add(bytes.length);
 

pkg/analyzer/lib/src/dart/analysis/library_diagnostics.dart

@@ -33,6 +33,7 @@ class LibraryDiagnosticsBundle {
 
   factory LibraryDiagnosticsBundle.fromBytes(Uint8List bytes) {
     var reader = BinaryReader(bytes);
+    reader.initializeStringTableFromEnd();
     return LibraryDiagnosticsBundle(
       requirements: RequirementsManifest.read(reader),
       serializedFileResults: reader.readMap(
@@ -58,6 +59,7 @@ class LibraryDiagnosticsBundle {
       writeKey: (uri) => writer.writeUri(uri),
       writeValue: (bytes) => writer.writeUint8List(bytes),
     );
+    writer.writeStringTableAtEnd();
     return writer.takeBytes();
   }
 }

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -798,13 +798,17 @@ class LibraryManifestBuilder {
     Uint8List manifestAsBytes(LibraryManifest manifest) {
       var writer = BinaryWriter();
       manifest.write(writer);
+      writer.writeStringTableAtEnd();
       return writer.takeBytes();
     }
 
     newManifests.forEach((uri, manifest) {
       var bytes = manifestAsBytes(manifest);
 
-      var readManifest = LibraryManifest.read(BinaryReader(bytes));
+      var reader = BinaryReader(bytes);
+      reader.initializeStringTableFromEnd();
+
+      var readManifest = LibraryManifest.read(reader);
       var readBytes = manifestAsBytes(readManifest);
 
       if (!const ListEquality<int>().equals(bytes, readBytes)) {

pkg/analyzer/lib/src/fine/lookup_name.dart

@@ -11,15 +11,15 @@ import 'package:analyzer/src/utilities/extensions/string.dart';
 /// In contrast to [LookupName] there is no `=` at the end.
 extension type BaseName(String _it) {
   factory BaseName.read(BinaryReader reader) {
-    var str = reader.readStringUtf8();
+    var str = reader.readStringReference();
     return BaseName(str);
   }
 
   /// Returns the underlying [String] value, explicitly.
   String get asString => _it;
 
   void write(BinaryWriter writer) {
-    writer.writeStringUtf8(_it);
+    writer.writeStringReference(_it);
   }
 
   static int compare(BaseName left, BaseName right) {
@@ -32,7 +32,7 @@ extension type BaseName(String _it) {
 /// Specifically, for setters there is `=` at the end.
 extension type LookupName(String _it) {
   factory LookupName.read(BinaryReader reader) {
-    var str = reader.readStringUtf8();
+    var str = reader.readStringReference();
     return LookupName(str);
   }
 
@@ -109,7 +109,7 @@ extension type LookupName(String _it) {
   }
 
   void write(BinaryWriter writer) {
-    writer.writeStringUtf8(_it);
+    writer.writeStringReference(_it);
   }
 
   static int compare(LookupName left, LookupName right) {

pkg/analyzer/lib/src/fine/manifest_ast.dart

@@ -118,7 +118,7 @@ class ManifestNode {
   factory ManifestNode.read(BinaryReader reader) {
     return ManifestNode._(
       isValid: reader.readBool(),
-      tokenBuffer: reader.readStringUtf8(),
+      tokenBuffer: reader.readStringReference(),
       tokenLengthList: reader.readUint30List(),
       elements: ManifestElement.readList(reader),
       elementIndexList: reader.readUint30List(),
@@ -195,7 +195,7 @@ class ManifestNode {
 
   void write(BinaryWriter writer) {
     writer.writeBool(isValid);
-    writer.writeStringUtf8(tokenBuffer);
+    writer.writeStringReference(tokenBuffer);
     writer.writeUint30List(tokenLengthList);
     writer.writeList(elements, (e) => e.write(writer));
     writer.writeUint30List(elementIndexList);

pkg/analyzer/lib/src/fine/manifest_context.dart

@@ -117,8 +117,8 @@ final class ManifestElement {
     return ManifestElement(
       libraryUri: reader.readUri(),
       kind: reader.readEnum(ManifestElementKind.values),
-      topLevelName: reader.readStringUtf8(),
-      memberName: reader.readOptionalStringUtf8(),
+      topLevelName: reader.readStringReference(),
+      memberName: reader.readOptionalStringReference(),
       id: reader.readOptionalObject(() => ManifestItemId.read(reader)),
     );
   }
@@ -173,8 +173,8 @@ final class ManifestElement {
   void write(BinaryWriter writer) {
     writer.writeUri(libraryUri);
     writer.writeEnum(kind);
-    writer.writeStringUtf8(topLevelName);
-    writer.writeOptionalStringUtf8(memberName);
+    writer.writeStringReference(topLevelName);
+    writer.writeOptionalStringReference(memberName);
     id.writeOptional(writer);
   }
 

pkg/analyzer/lib/src/fine/manifest_type.dart

@@ -102,7 +102,7 @@ class ManifestFunctionNamedFormalParameter
       isSuperFormal: reader.readBool(),
       type: ManifestType.read(reader),
       defaultValue: ManifestNode.readOptional(reader),
-      name: reader.readStringUtf8(),
+      name: reader.readStringReference(),
     );
   }
 
@@ -127,7 +127,7 @@ class ManifestFunctionNamedFormalParameter
   @override
   void write(BinaryWriter writer) {
     super.write(writer);
-    writer.writeStringUtf8(name);
+    writer.writeStringReference(name);
   }
 }
 
@@ -513,7 +513,7 @@ class ManifestRecordTypeNamedField {
 
   factory ManifestRecordTypeNamedField.read(BinaryReader reader) {
     return ManifestRecordTypeNamedField._(
-      name: reader.readStringUtf8(),
+      name: reader.readStringReference(),
       type: ManifestType.read(reader),
     );
   }
@@ -525,7 +525,7 @@ class ManifestRecordTypeNamedField {
   }
 
   void write(BinaryWriter writer) {
-    writer.writeStringUtf8(name);
+    writer.writeStringReference(name);
     type.write(writer);
   }
 }