[ CLI ] Add support for --enable-asserts to dart compile jit-snapshot

Makes jit-snapshot more consistent with other compilation modes (e.g.,
exe, aot-snapshot, wasm).

Change-Id: I6ede1b9cd54b2e2ed368b5c60ace1f8e41afd359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434500
Auto-Submit: Ben Konyi <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>
Reviewed-by: Derek Xu <[email protected]>
Commit-Queue: Derek Xu <[email protected]>

Author: bkonyi

pkg/dartdev/lib/src/commands/compile.dart

@@ -360,6 +360,11 @@ class CompileJitSnapshotCommand extends CompileSubcommandCommand {
         abbr: defineOption.abbr,
         valueHelp: defineOption.valueHelp,
       )
+      ..addFlag(
+        enableAssertsOption.flag,
+        negatable: false,
+        help: enableAssertsOption.help,
+      )
       ..addFlag(soundNullSafetyOption.flag,
           help: soundNullSafetyOption.help,
           defaultsTo: soundNullSafetyOption.flagDefaultsTo,
@@ -409,6 +414,7 @@ class CompileJitSnapshotCommand extends CompileSubcommandCommand {
 
     final enabledExperiments = args.enabledExperiments;
     final defines = args.multiOption(defineOption.flag);
+    final enableAsserts = args.flag(enableAssertsOption.flag);
 
     // Build arguments.
     final buildArgs = <String>[];
@@ -439,6 +445,11 @@ class CompileJitSnapshotCommand extends CompileSubcommandCommand {
     for (final define in defines) {
       buildArgs.add('-D$define');
     }
+
+    if (enableAsserts) {
+      buildArgs.add('--${enableAssertsOption.flag}');
+    }
+
     buildArgs.add(path.canonicalize(sourcePath));
 
     // Add the training arguments.
@@ -493,9 +504,9 @@ class CompileNativeCommand extends CompileSubcommandCommand {
         valueHelp: defineOption.valueHelp,
       )
       ..addFlag(
-        'enable-asserts',
+        enableAssertsOption.flag,
         negatable: false,
-        help: 'Enable assert statements.',
+        help: enableAssertsOption.help,
       )
       ..addOption(
         packagesOption.flag,
@@ -663,7 +674,7 @@ Remove debugging information from the output and save it separately to the speci
         defines: args.multiOption(defineOption.flag),
         packages: args.option('packages'),
         enableExperiment: args.enabledExperiments.join(','),
-        enableAsserts: args.flag('enable-asserts'),
+        enableAsserts: args.flag(enableAssertsOption.flag),
         debugFile: args.option('save-debugging-info'),
         verbose: verbose,
         verbosity: args.option('verbosity')!,
@@ -821,9 +832,9 @@ class CompileWasmCommand extends CompileSubcommandCommand {
         negatable: false,
       )
       ..addFlag(
-        'enable-asserts',
-        help: 'Enable assert statements.',
+        enableAssertsOption.flag,
         negatable: false,
+        help: enableAssertsOption.help,
       )
       ..addOption(
         'shared-memory',
@@ -977,7 +988,7 @@ class CompileWasmCommand extends CompileSubcommandCommand {
       if (packages != null) '--packages=$packages',
       if (args.flag('print-wasm')) '--print-wasm',
       if (args.flag('print-kernel')) '--print-kernel',
-      if (args.flag('enable-asserts')) '--enable-asserts',
+      if (args.flag(enableAssertsOption.flag)) '--${enableAssertsOption.flag}',
       if (!generateSourceMap) '--no-source-maps',
       for (final define in defines) '-D$define',
       if (maxPages != null) ...[
@@ -1074,27 +1085,29 @@ Sets the verbosity level of the compilation.
     flagDefaultsTo: true,
   );
 
-  final Option defineOption;
-  final Option packagesOption;
-
-  CompileSubcommandCommand(super.name, super.description, super.verbose,
-      {super.hidden})
-      : defineOption = Option(
-          flag: 'define',
-          abbr: 'D',
-          valueHelp: 'key=value',
-          help: '''
+  late final Option defineOption = Option(
+    flag: 'define',
+    abbr: 'D',
+    valueHelp: 'key=value',
+    help: '''
 Define an environment declaration. To specify multiple declarations, use multiple options or use commas to separate key-value pairs.
 For example: dart compile $name -Da=1,b=2 main.dart''',
-        ),
-        packagesOption = Option(
-            flag: 'packages',
-            abbr: 'p',
-            valueHelp: 'path',
-            help:
-                '''Get package locations from the specified file instead of .dart_tool/package_config.json.
+  );
+
+  late final Option packagesOption = Option(
+      flag: 'packages',
+      abbr: 'p',
+      valueHelp: 'path',
+      help:
+          '''Get package locations from the specified file instead of .dart_tool/package_config.json.
 <path> can be relative or absolute.
 For example: dart compile $name --packages=/tmp/pkgs.json main.dart''');
+
+  final Option enableAssertsOption =
+      Option(flag: 'enable-asserts', help: 'Enable assert statements.');
+
+  CompileSubcommandCommand(super.name, super.description, super.verbose,
+      {super.hidden});
 }
 
 class CompileCommand extends DartdevCommand {

pkg/dartdev/test/commands/compile_test.dart

@@ -1481,6 +1481,39 @@ void main() {
     expect(result.exitCode, 254);
   });
 
+  test('Compile JIT snapshot with asserts', () async {
+    final p = project(mainSrc: '''
+void main() {
+  assert(int.parse('1') == 2);
+}
+''');
+    final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
+    final outFile = path.canonicalize(path.join(p.dirPath, 'myjit'));
+
+    var result = await p.run(
+      [
+        'compile',
+        'jit-snapshot',
+        '--enable-asserts',
+        '-o',
+        outFile,
+        inFile,
+      ],
+    );
+
+    // Only printed when -v/--verbose is used, not --verbosity.
+    expect(result.stdout, isNot(contains(usingTargetOSMessage)));
+    expect(result.stdout, isNot(contains(soundNullSafetyMessage)));
+    expect(result.stderr, contains(failedAssertionError));
+    expect(result.exitCode, 255);
+
+    result = await p.run(
+      ['--enable-asserts', outFile],
+    );
+    expect(result.stdout, isEmpty);
+    expect(result.stderr, contains(failedAssertionError));
+  });
+
   if (Platform.isMacOS) {
     test('Compile and run executable from signed dartaotruntime', () async {
       // Either the locally built dartaotruntime is already linker signed