[vm] Refactor runtime entries.

- Reduce header surface area.
- Remove runtime_entry_<arch>.cc, which no longer include code generation.
- Fix signature of DLRT_Enter/ExitSafepoint.
- Give non-leaf runtime functions C linkage, as C++ does not have a defined ABI.

TEST=ci
Change-Id: I21e21a50ad9e4f9b32b1204d755bfa69a2ae9b17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430981
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

runtime/lib/concurrent.cc

@@ -4,6 +4,7 @@
 
 #include "include/dart_api.h"
 #include "vm/bootstrap_natives.h"
+#include "vm/heap/safepoint.h"
 #include "vm/os_thread.h"
 
 namespace dart {

runtime/lib/double.cc

@@ -14,7 +14,6 @@
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
-#include "vm/runtime_entry.h"  // DartModulo.
 #include "vm/symbols.h"
 
 namespace dart {

runtime/lib/object.cc

@@ -14,6 +14,7 @@
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/resolver.h"
+#include "vm/runtime_entry.h"
 #include "vm/stack_frame.h"
 #include "vm/symbols.h"
 

runtime/vm/compiler/jit/compiler.cc

@@ -198,25 +198,6 @@ FlowGraph* Compiler::BuildFlowGraph(
   return graph;
 }
 
-// Compile a function. Should call only if the function has not been compiled.
-//   Arg0: function object.
-DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
-  ASSERT(thread->IsDartMutatorThread());
-  const Function& function = Function::CheckedHandle(zone, arguments.ArgAt(0));
-
-  {
-    // Another isolate's mutator thread may have created [function] and
-    // published it via an ICData, MegamorphicCache etc. Entering the lock below
-    // is an acquire operation that pairs with the release operation when the
-    // other isolate exited the lock, ensuring the initializing stores for
-    // [function] are visible in the current thread.
-    SafepointReadRwLocker ml(thread, thread->isolate_group()->program_lock());
-  }
-
-  // Will throw if compilation failed (e.g. with compile-time error).
-  function.EnsureHasCode();
-}
-
 bool Compiler::CanOptimizeFunction(Thread* thread, const Function& function) {
 #if !defined(PRODUCT)
   if (thread->isolate_group()->debugger()->IsDebugging(thread, function)) {
@@ -1224,14 +1205,6 @@ void BackgroundCompiler::Disable() {
 
 #else  // DART_PRECOMPILED_RUNTIME
 
-DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
-  const Function& function = Function::CheckedHandle(zone, arguments.ArgAt(0));
-  FATAL("Precompilation missed function %s (%s, %s)\n",
-        function.ToLibNamePrefixedQualifiedCString(),
-        function.token_pos().ToCString(),
-        Function::KindToCString(function.kind()));
-}
-
 bool Compiler::IsBackgroundCompilation() {
   return false;
 }

runtime/vm/dart_entry.cc

@@ -10,6 +10,7 @@
 #include "vm/dispatch_table.h"
 #include "vm/heap/safepoint.h"
 #include "vm/interpreter.h"
+#include "vm/log.h"
 #include "vm/object_store.h"
 #include "vm/resolver.h"
 #include "vm/runtime_entry.h"

runtime/vm/heap/pointer_block.cc

@@ -5,32 +5,12 @@
 #include "vm/heap/pointer_block.h"
 
 #include "platform/assert.h"
+#include "vm/isolate.h"
 #include "vm/lockers.h"
-#include "vm/runtime_entry.h"
+#include "vm/thread.h"
 
 namespace dart {
 
-DEFINE_LEAF_RUNTIME_ENTRY(void, StoreBufferBlockProcess, 1, Thread* thread) {
-  thread->StoreBufferBlockProcess(StoreBuffer::kCheckThreshold);
-}
-END_LEAF_RUNTIME_ENTRY
-
-DEFINE_LEAF_RUNTIME_ENTRY(void,
-                          OldMarkingStackBlockProcess,
-                          1,
-                          Thread* thread) {
-  thread->OldMarkingStackBlockProcess();
-}
-END_LEAF_RUNTIME_ENTRY
-
-DEFINE_LEAF_RUNTIME_ENTRY(void,
-                          NewMarkingStackBlockProcess,
-                          1,
-                          Thread* thread) {
-  thread->NewMarkingStackBlockProcess();
-}
-END_LEAF_RUNTIME_ENTRY
-
 template <int BlockSize>
 typename BlockStack<BlockSize>::List* BlockStack<BlockSize>::global_empty_ =
     nullptr;

runtime/vm/native_entry.cc

@@ -6,17 +6,18 @@
 
 #include "include/dart_api.h"
 
+#include "platform/memory_sanitizer.h"
 #include "vm/bootstrap.h"
 #include "vm/code_patcher.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
+#include "vm/exceptions.h"
 #include "vm/heap/safepoint.h"
 #include "vm/native_symbol.h"
 #include "vm/object_store.h"
 #include "vm/reusable_handles.h"
+#include "vm/runtime_entry.h"
 #include "vm/stack_frame.h"
-#include "vm/symbols.h"
-#include "vm/tags.h"
 
 namespace dart {
 

runtime/vm/native_entry.h

@@ -5,15 +5,10 @@
 #ifndef RUNTIME_VM_NATIVE_ENTRY_H_
 #define RUNTIME_VM_NATIVE_ENTRY_H_
 
-#include "platform/memory_sanitizer.h"
-
 #include "vm/allocation.h"
-#include "vm/exceptions.h"
-#include "vm/heap/verifier.h"
 #include "vm/log.h"
 #include "vm/native_arguments.h"
 #include "vm/native_function.h"
-#include "vm/runtime_entry.h"
 
 namespace dart {
 

runtime/vm/object.h

@@ -259,7 +259,7 @@ class BaseTextBuffer;
   OBJECT_SERVICE_SUPPORT(object)                                               \
   friend class Object;
 
-extern "C" void DFLRT_ExitSafepoint(NativeArguments __unusable_);
+extern "C" void DLRT_ExitSafepoint();
 
 #define HEAP_OBJECT_IMPLEMENTATION(object, super)                              \
   OBJECT_IMPLEMENTATION(object, super);                                        \
@@ -270,7 +270,7 @@ extern "C" void DFLRT_ExitSafepoint(NativeArguments __unusable_);
   SNAPSHOT_SUPPORT(object)                                                     \
   friend class StackFrame;                                                     \
   friend class Thread;                                                         \
-  friend void DFLRT_ExitSafepoint(NativeArguments __unusable_);
+  friend void DLRT_ExitSafepoint();
 
 // This macro is used to denote types that do not have a sub-type.
 #define FINAL_HEAP_OBJECT_IMPLEMENTATION_HELPER(object, rettype, super)        \
@@ -299,7 +299,7 @@ extern "C" void DFLRT_ExitSafepoint(NativeArguments __unusable_);
   friend class Object;                                                         \
   friend class StackFrame;                                                     \
   friend class Thread;                                                         \
-  friend void DFLRT_ExitSafepoint(NativeArguments __unusable_);
+  friend void DLRT_ExitSafepoint();
 
 #define FINAL_HEAP_OBJECT_IMPLEMENTATION(object, super)                        \
   FINAL_HEAP_OBJECT_IMPLEMENTATION_HELPER(object, object, super)

runtime/vm/profiler.cc

@@ -14,6 +14,7 @@
 #include "vm/compiler/compiler_state.h"
 #endif
 #include "vm/debugger.h"
+#include "vm/heap/safepoint.h"
 #include "vm/instructions.h"
 #include "vm/isolate.h"
 #include "vm/json_stream.h"