Elements. Remove 'normalParameterNames' and 'optionalParameterNames' from FunctionType.

Change-Id: I934dca9f635411b71add032a3fc607dddf7de11a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393362
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -34,6 +34,7 @@
 * Remove deprecated `source_resource.dart`.
 * Remove `MultiplyInheritedExecutableElement`.
 * Remove `AnalyzeFunctionBodiesPredicate`.
+* Remove `normalParameterNames` and `optionalParameterNames` from `FunctionType`.
 
 ## 6.11.0
 * Un-deprecated `LibraryElement.exportedLibraries`.

pkg/analyzer/lib/dart/element/type.dart

@@ -247,21 +247,13 @@ abstract class FunctionType
   /// named parameters declared, then the map will be empty.
   Map<String, DartType> get namedParameterTypes;
 
-  /// The names of the required positional parameters of this type of function,
-  /// not necessarily in the order that the parameters appear.
-  List<String> get normalParameterNames;
-
   /// A list containing the types of the normal parameters of this type of
   /// function.
   ///
   /// The parameter types are not necessarily in the same order as they appear
   /// in the declaration of the function.
   List<DartType> get normalParameterTypes;
 
-  /// The names of the optional positional parameters of this type of function,
-  /// not necessarily in the order that the parameters appear.
-  List<String> get optionalParameterNames;
-
   /// A map from the names of optional (positional) parameters to the types of
   /// the optional parameters of this type of function.
   ///

pkg/analyzer/lib/src/dart/element/type.dart

@@ -199,22 +199,10 @@ class FunctionTypeImpl extends TypeImpl implements FunctionType {
           parameter.name: parameter.type
       };
 
-  @override
-  List<String> get normalParameterNames => parameters
-      .where((p) => p.isRequiredPositional)
-      .map((p) => p.name)
-      .toList();
-
   @override
   List<DartType> get normalParameterTypes =>
       positionalParameterTypes.sublist(0, requiredPositionalParameterCount);
 
-  @override
-  List<String> get optionalParameterNames => parameters
-      .where((p) => p.isOptionalPositional)
-      .map((p) => p.name)
-      .toList();
-
   @override
   List<DartType> get optionalParameterTypes =>
       positionalParameterTypes.sublist(requiredPositionalParameterCount);

pkg/analyzer/test/src/dart/element/function_type_test.dart

@@ -50,12 +50,8 @@ class FunctionTypeTest extends AbstractTypeSystemTest {
     // FunctionType properties
     expect(f.namedParameterTypes, namedParameterTypes,
         reason: 'namedParameterTypes');
-    expect(f.normalParameterNames, normalParameterNames,
-        reason: 'normalParameterNames');
     expect(f.normalParameterTypes, normalParameterTypes,
         reason: 'normalParameterTypes');
-    expect(f.optionalParameterNames, optionalParameterNames,
-        reason: 'optionalParameterNames');
     expect(f.optionalParameterTypes, optionalParameterTypes,
         reason: 'optionalParameterTypes');
     expect(f.parameters, parameters, reason: 'parameters');