Skip to content

Commit 1a8334d

Browse files
stereotype441Commit Queue
authored andcommitted
[analyzer] Make logic for interpreting messages.yaml file sharable with CFE.
Moves the following top level declarations, as well as other declarations they depend on, from `pkg/analyzer/tool/messages/error_code_info.dart` into `package:analyzer_utilities`, so that they can be imported by the CFE's diagnostic code generator: - `frontEndMessages` - `placeholderPattern` - `FrontEndErrorCodeInfo` There is no functional change. In a follow-up CL, I will modify `pkg/front_end/tool/generate_messages_lib.dart` to use these declarations. Change-Id: I6a6a69642230f0b943ccaf800c1f9e569c5b7579 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447982 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 365d1ac commit 1a8334d

File tree

8 files changed

+671
-654
lines changed

8 files changed

+671
-654
lines changed

pkg/analyzer/test/src/fasta/message_coverage_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import 'dart:io' as io;
77
import 'package:analyzer/dart/ast/ast.dart';
88
import 'package:analyzer/dart/ast/visitor.dart';
99
import 'package:analyzer_testing/package_root.dart' as package_root;
10+
import 'package:analyzer_utilities/messages.dart';
1011
import 'package:path/path.dart' as path;
1112
import 'package:test/test.dart';
1213
import 'package:test_reflective_loader/test_reflective_loader.dart';
1314

14-
import '../../../tool/messages/error_code_info.dart';
1515
import '../../generated/parser_test_base.dart';
1616

1717
main() {

pkg/analyzer/test/verify_diagnostics_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import 'package:analyzer/diagnostic/diagnostic.dart';
66
import 'package:analyzer/error/error.dart';
77
import 'package:analyzer/utilities/package_config_file_builder.dart';
88
import 'package:analyzer_testing/utilities/utilities.dart';
9+
import 'package:analyzer_utilities/messages.dart';
910
import 'package:test/test.dart';
1011
import 'package:test_reflective_loader/test_reflective_loader.dart';
1112

0 commit comments

Comments
 (0)