Skip to content

Commit 1b5df75

Browse files
nshahanCommit Queue
authored andcommitted
[benchmark] Cleanup lint violations
Fix violations of lints that I expect have no influence on the performance characteristics of this benchmark: * avoid_init_to_null * directives_ordering * prefer_single_quotes Change-Id: I50b507405abf9eb75c2fba688a9588a2fa84bab7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433268 Reviewed-by: Ömer Ağacan <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
1 parent fa2f490 commit 1b5df75

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

benchmarks/WasmJSInterop/dart/WasmJSInterop.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ double dartifyBoolBenchmark() =>
121121
}, minimumMeasureDurationMillis) /
122122
ITERATIONS;
123123

124-
bool? nullableBoolSink = null;
124+
bool? nullableBoolSink;
125125

126126
double dartifyNullableBoolBenchmark() =>
127127
BenchmarkBase.measureFor(() {
@@ -141,7 +141,7 @@ double dartifyNumBenchmark() =>
141141
}, minimumMeasureDurationMillis) /
142142
ITERATIONS;
143143

144-
num? nullableNumSink = null;
144+
num? nullableNumSink;
145145

146146
double dartifyNullableNumBenchmark() =>
147147
BenchmarkBase.measureFor(() {
@@ -161,7 +161,7 @@ double dartifyDoubleBenchmark() =>
161161
}, minimumMeasureDurationMillis) /
162162
ITERATIONS;
163163

164-
double? nullableDoubleSink = null;
164+
double? nullableDoubleSink;
165165

166166
double dartifyNullableDoubleBenchmark() =>
167167
BenchmarkBase.measureFor(() {
@@ -181,7 +181,7 @@ double dartifyIntBenchmark() =>
181181
}, minimumMeasureDurationMillis) /
182182
ITERATIONS;
183183

184-
int? nullableIntSink = null;
184+
int? nullableIntSink;
185185

186186
double dartifyNullableIntBenchmark() =>
187187
BenchmarkBase.measureFor(() {
@@ -191,7 +191,7 @@ double dartifyNullableIntBenchmark() =>
191191
}, minimumMeasureDurationMillis) /
192192
ITERATIONS;
193193

194-
String stringSink = "";
194+
String stringSink = '';
195195

196196
double dartifyStringBenchmark() =>
197197
BenchmarkBase.measureFor(() {
@@ -201,7 +201,7 @@ double dartifyStringBenchmark() =>
201201
}, minimumMeasureDurationMillis) /
202202
ITERATIONS;
203203

204-
String? nullableStringSink = null;
204+
String? nullableStringSink;
205205

206206
double dartifyNullableStringBenchmark() =>
207207
BenchmarkBase.measureFor(() {
@@ -221,7 +221,7 @@ double dartifyJSArrayBenchmark() =>
221221
}, minimumMeasureDurationMillis) /
222222
ITERATIONS;
223223

224-
JSArray? nullableJsArraySink = null;
224+
JSArray? nullableJsArraySink;
225225

226226
double dartifyNullableJSArrayBenchmark() =>
227227
BenchmarkBase.measureFor(() {
@@ -241,7 +241,7 @@ double dartifyJSUint8ArrayBenchmark() =>
241241
}, minimumMeasureDurationMillis) /
242242
ITERATIONS;
243243

244-
JSUint8Array? nullableJsUint8ArraySink = null;
244+
JSUint8Array? nullableJsUint8ArraySink;
245245

246246
double dartifyNullableJSUint8ArrayBenchmark() =>
247247
BenchmarkBase.measureFor(() {

0 commit comments

Comments
 (0)