DAS plugins: Update docs for new public names

This change highlights how all of the necessary imports are now public!

From here, forward, we are guarded by analyzer's public API rules.

Change-Id: I71a7f928fc5913df846aa6253cd880719b4cd726
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439342
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/doc/writing_rules.md

@@ -17,9 +17,11 @@ various syntax tree nodes that the visitor class needs to visit. Let's see an
 example:
 
 ```dart
+import 'package:analyzer/analysis_rule/analysis_rule.dart';
+import 'package:analyzer/analysis_rule/rule_context.dart';
+import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/src/dart/error/lint_codes.dart';
-import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/error/error.dart';
 
 class MyRule extends AnalysisRule {
   static const LintCode code = LintCode(
@@ -39,7 +41,7 @@ class MyRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, RuleContext context) {
     var visitor = _Visitor(this, context);
     registry.addAwaitExpression(this, visitor);
   }
@@ -75,13 +77,13 @@ Let's look at each declaration individually:
   a [Dart syntax tree][] (we see how the visitor is defined in "The visitor
   class," below). This visitor is typically named `_Visitor`. This visitor
   class must be instantiated once in this method. Typically, the instance of
-  the rule class (`this`) and a `LinterContext` object (described below) are
+  the rule class (`this`) and a `RuleContext` object (described below) are
   passed to the visitor constructor.
 
   In order for such a visitor's various 'visit' methods to be called, we need
-  to register them, in a `NodeLintRegistry`. Each 'visit' method found on
-  `SimpleAstVisitor` has a corresponding 'add' method in the `NodeLintRegistry`
-  class.
+  to register them, in a `RuleVisitorRegistry`. Each 'visit' method found on
+  `SimpleAstVisitor` has a corresponding 'add' method in the
+  `RuleVisitorRegistry` class.
 
 [Dart syntax tree]: https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/doc/tutorial/ast.md
 
@@ -95,21 +97,22 @@ implementation. Let's look at a quick example:
 [SimpleAstVisitor docs]: https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/lib/dart/ast/visitor.dart#L1841
 
 ```dart
+import 'package:analyzer/analysis_rule/analysis_rule.dart';
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/src/lint/linter.dart';
 
 class _Visitor extends SimpleAstVisitor<void> {
-  final LintRule rule;
+  final AnalysisRule rule;
 
-  final LinterContext context;
+  final RuleContext context;
 
   _Visitor(this.rule, this.context);
 
   @override
   void visitAwaitExpression(AwaitExpression node) {
     if (context.isInLibDir) {
-      rule.reportLint(node);
+      rule.reportAtNode(node);
     }
   }
 }
@@ -122,15 +125,15 @@ Let's look at each declaration individually:
   tree visitors, using one directly in a rule can result in poor performance
   and unexpected behavior. The type argument on `SimpleAstVisitor` is not
   important, as 'visit' return values are not used, so `void` is appropriate.
-* `final LintRule rule` - The rule is the object to which we can report
+* `final AnalysisRule rule` - The rule is the object to which we can report
   diagnostics (lints or warnings). Several methods are provided, all starting
-  with `reportLint`. The different methods allow for different ranges of text
-  to be highlighted.
-* `final LinterContext context` - The LinterContext object provides various
+  with `reportAt`. The different methods allow for different ranges of text to
+  be highlighted.
+* `final RuleContext context` - The RuleContext object provides various
   information about the library being analyzed. In this example, we make use of
   a `isInLibDir` utility.
-* `_Visitor(...)` - Often the constructor just initializes the LintRule and
-  LinterContext fields. Other information can be initialized as well.
+* `_Visitor(...)` - Often the constructor just initializes the AnalysisRule and
+  RuleContext fields. Other information can be initialized as well.
 * `void visitAwaitExpression(AwaitExpression node)` - The main component of the
   `_Visitor` class is the 'visit' methods. In this case, `visitAwaitExpression`
   is invoked for each 'await expression' found in the source code under