Skip to content

Commit 1d4c570

Browse files
srujzsCommit Queue
authored andcommitted
Skip SDK library-level expression evaluation tests
These are no longer handled with the new module format, so skip them when that's enabled. This is the last piece to get expression evaluation tests working again with the new format. Change-Id: I92933363ea4e275f7a3f1c9cd62e24b0f7987f49 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393162 Commit-Queue: Srujan Gaddam <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]>
1 parent 4fa616b commit 1d4c570

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,14 +489,30 @@ void runNullSafeSharedTests(
489489
expression: 'Flow.begin(id: 0) is Flow',
490490
libraryUri: Uri.parse('dart:developer'),
491491
expectedResult: 'true');
492-
});
492+
},
493+
// The new module format requires a per-library compiler. Since we
494+
// loaded the SDK from a summary/dill, we've never actually created a
495+
// compiler for it, and therefore can't execute library-level
496+
// expression evaluation in the SDK. Currently, no real workflow can
497+
// meaningfully use this anyways. See
498+
// https://github.com/flutter/devtools/issues/7766 for the initial
499+
// motivation.
500+
skip: setup.emitLibraryBundle);
493501

494502
test('tearoff an SDK method', () async {
495503
await driver.check(
496504
expression: 'postEvent',
497505
libraryUri: Uri.parse('dart:developer'),
498506
expectedResult: contains('function postEvent(eventKind'));
499-
});
507+
},
508+
// The new module format requires a per-library compiler. Since we
509+
// loaded the SDK from a summary/dill, we've never actually created a
510+
// compiler for it, and therefore can't execute library-level
511+
// expression evaluation in the SDK. Currently, no real workflow can
512+
// meaningfully use this anyways. See
513+
// https://github.com/flutter/devtools/issues/7766 for the initial
514+
// motivation.
515+
skip: setup.emitLibraryBundle);
500516
});
501517

502518
group('method level', () {

0 commit comments

Comments
 (0)