[DAS] Fixes nested pattern keyword completion

Fixes: #60917
Change-Id: I711dd50383f73f5a59eea5ebf659dcef72e3c76f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435400
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -2242,7 +2242,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
         _forVariablePattern();
       }
       var isKeywordNeeded = false;
-      if (node.parent?.parent is GuardedPattern) {
+      if (node.thisOrAncestorOfType<GuardedPattern>() != null) {
         isKeywordNeeded = true;
       }
       _forPatternFieldName(

pkg/analysis_server/test/lsp/completion_dart_test.dart

@@ -255,6 +255,47 @@ void f() {
     expectDocumentation(resolved, contains('Enum Member.'));
   }
 
+  Future<void> test_innerPatternKeyword() async {
+    content = '''
+class A {
+  A([this.value]);
+  A? value;
+}
+
+void main() {
+  final value = A(A(A()));
+  if (value case A(value: A(:^))) {}
+}
+''';
+    await initializeServer();
+
+    var code = TestCode.parse(content);
+    var completion = await getCompletionItem('value');
+    expect(completion, isNotNull);
+
+    // Resolve the completion item to get its edits.
+    var resolved = await resolveCompletion(completion);
+
+    // Apply all current-document edits.
+    var newContent = applyTextEdits(code.code, [
+      toTextEdit(resolved.textEdit!),
+    ]);
+    expect(
+      newContent,
+      equals('''
+class A {
+  A([this.value]);
+  A? value;
+}
+
+void main() {
+  final value = A(A(A()));
+  if (value case A(value: A(:var value))) {}
+}
+'''),
+    );
+  }
+
   /// We should not show `var`, `final` or the member type on the display text.
   Future<void> test_pattern_member_name_only() async {
     content = '''