Skip to content

Commit 1f5b904

Browse files
keertipCommit Queue
authored andcommitted
Elements. Migrate test/src/dart/analysis/session_test.dart
Change-Id: I0e35b0a56119adc42708a0e44321c600db33f8f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404220 Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Keerti Parthasarathy <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 50527da commit 1f5b904

File tree

1 file changed

+47
-49
lines changed

1 file changed

+47
-49
lines changed

pkg/analyzer/test/src/dart/analysis/session_test.dart

Lines changed: 47 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: analyzer_use_new_elements
6-
75
import 'package:analyzer/dart/analysis/results.dart';
86
import 'package:analyzer/dart/analysis/session.dart';
97
import 'package:analyzer/dart/ast/ast.dart';
10-
import 'package:analyzer/dart/element/element.dart';
8+
import 'package:analyzer/dart/element/element2.dart';
119
import 'package:analyzer/file_system/file_system.dart';
1210
import 'package:analyzer/src/dart/element/element.dart';
1311
import 'package:analyzer/src/utilities/extensions/file_system.dart';
@@ -125,7 +123,7 @@ class AnalysisSessionImpl_BlazeWorkspaceTest
125123
var session = contextFor(file).currentSession;
126124
var result = await session.getUnitElementValid(file);
127125
expect(result.path, file.path);
128-
expect(result.element.classes, hasLength(1));
126+
expect(result.fragment.classes2, hasLength(1));
129127
expect(result.uri.toString(), 'package:dart.my/a.dart');
130128
}
131129
}
@@ -266,10 +264,10 @@ class B {}
266264

267265
var session = contextFor(testFile).currentSession;
268266
var result = await session.getLibraryByUriValid('package:test/test.dart');
269-
var library = result.element;
270-
expect(library.getClass('A'), isNotNull);
271-
expect(library.getClass('B'), isNotNull);
272-
expect(library.getClass('C'), isNull);
267+
var library = result.element2;
268+
expect(library.getClass2('A'), isNotNull);
269+
expect(library.getClass2('B'), isNotNull);
270+
expect(library.getClass2('C'), isNull);
273271
}
274272

275273
test_getLibraryByUri_inconsistent() async {
@@ -330,8 +328,8 @@ class B {}
330328
);
331329
var parsedLibrary = session.getParsedLibraryValid(testFile);
332330

333-
var element = libraryResult.element.getClass('A')!;
334-
var declaration = parsedLibrary.getElementDeclaration(element)!;
331+
var element = libraryResult.element2.getClass2('A')!;
332+
var declaration = parsedLibrary.getElementDeclaration2(element.firstFragment)!;
335333
var node = declaration.node as ClassDeclaration;
336334
expect(node.name.lexeme, 'A');
337335
expect(node.offset, 0);
@@ -345,12 +343,12 @@ class B {}
345343
var resolvedUnit =
346344
await session.getResolvedUnit(testFile.path) as ResolvedUnitResult;
347345
var typeProvider = resolvedUnit.typeProvider;
348-
var intClass = typeProvider.intType.element;
346+
var intClass = typeProvider.intType.element3;
349347

350348
var parsedLibrary = session.getParsedLibraryValid(testFile);
351349

352350
expect(() {
353-
parsedLibrary.getElementDeclaration(intClass);
351+
parsedLibrary.getElementDeclaration2(intClass.firstFragment);
354352
}, throwsArgumentError);
355353
}
356354

@@ -363,19 +361,19 @@ int foo = 0;
363361
var parsedLibrary = session.getParsedLibraryValid(testFile);
364362

365363
var unitResult = await session.getUnitElementValid(testFile);
366-
var fooElement = unitResult.element.topLevelVariables[0];
367-
expect(fooElement.name, 'foo');
364+
var fooElement = unitResult.fragment.topLevelVariables2[0];
365+
expect(fooElement.name2, 'foo');
368366

369367
// We can get the variable element declaration.
370-
var fooDeclaration = parsedLibrary.getElementDeclaration(fooElement)!;
368+
var fooDeclaration = parsedLibrary.getElementDeclaration2(fooElement)!;
371369
var fooNode = fooDeclaration.node as VariableDeclaration;
372370
expect(fooNode.name.lexeme, 'foo');
373371
expect(fooNode.offset, 4);
374372
expect(fooNode.length, 7);
375373

376374
// Synthetic elements don't have nodes.
377-
expect(parsedLibrary.getElementDeclaration(fooElement.getter!), isNull);
378-
expect(parsedLibrary.getElementDeclaration(fooElement.setter!), isNull);
375+
expect(parsedLibrary.getElementDeclaration2(fooElement.getter2!), isNull);
376+
expect(parsedLibrary.getElementDeclaration2(fooElement.setter2!), isNull);
379377
}
380378

381379
test_getParsedLibrary_inconsistent() async {
@@ -477,7 +475,7 @@ class C3 {}
477475
var libraryResult = await session.getLibraryByUriValid(
478476
'package:test/test.dart',
479477
);
480-
var element = libraryResult.element;
478+
var element = libraryResult.element2;
481479

482480
var parsedLibrary = session.getParsedLibraryByElementValid(element);
483481
expect(parsedLibrary.session, session);
@@ -498,12 +496,12 @@ class C3 {}
498496
var libraryResult = await session.getLibraryByUriValid(
499497
'package:test/test.dart',
500498
);
501-
var element = libraryResult.element;
499+
var element = libraryResult.element2;
502500

503501
var aaaFile = getFile('$workspaceRootPath/aaa/lib/a.dart');
504502
var aaaSession = contextFor(aaaFile).currentSession;
505503

506-
var result = aaaSession.getParsedLibraryByElement(element);
504+
var result = aaaSession.getParsedLibraryByElement2(element);
507505
expect(result, isA<NotElementOfThisSessionResult>());
508506
}
509507

@@ -558,13 +556,13 @@ class B2 extends X {}
558556
expect(resolvedLibrary.session, session);
559557

560558
var typeProvider = resolvedLibrary.typeProvider;
561-
expect(typeProvider.intType.element.name, 'int');
559+
expect(typeProvider.intType.element3.name3, 'int');
562560

563-
var libraryElement = resolvedLibrary.element;
561+
var libraryElement = resolvedLibrary.element2;
564562

565-
var aClass = libraryElement.getClass('A')!;
563+
var aClass = libraryElement.getClass2('A')!;
566564

567-
var bClass = libraryElement.getClass('B')!;
565+
var bClass = libraryElement.getClass2('B')!;
568566

569567
var aUnitResult = resolvedLibrary.units[0];
570568
expect(aUnitResult.path, a.path);
@@ -584,19 +582,19 @@ class B2 extends X {}
584582
expect(bUnitResult.unit.declarations, hasLength(2));
585583
expect(bUnitResult.errors, isNotEmpty);
586584

587-
var aDeclaration = resolvedLibrary.getElementDeclaration(aClass)!;
585+
var aDeclaration = resolvedLibrary.getElementDeclaration2(aClass.firstFragment)!;
588586
var aNode = aDeclaration.node as ClassDeclaration;
589587
expect(aNode.name.lexeme, 'A');
590588
expect(aNode.offset, 16);
591589
expect(aNode.length, 16);
592-
expect(aNode.declaredElement!.name, 'A');
590+
expect(aNode.declaredFragment!.name2, 'A');
593591

594-
var bDeclaration = resolvedLibrary.getElementDeclaration(bClass)!;
592+
var bDeclaration = resolvedLibrary.getElementDeclaration2(bClass.firstFragment)!;
595593
var bNode = bDeclaration.node as ClassDeclaration;
596594
expect(bNode.name.lexeme, 'B');
597595
expect(bNode.offset, 19);
598596
expect(bNode.length, 16);
599-
expect(bNode.declaredElement!.name, 'B');
597+
expect(bNode.declaredFragment!.name2, 'B');
600598
}
601599

602600
test_getResolvedLibrary_getElementDeclaration_notThisLibrary() async {
@@ -606,8 +604,8 @@ class B2 extends X {}
606604
var resolvedLibrary = await session.getResolvedLibraryValid(testFile);
607605

608606
expect(() {
609-
var intClass = resolvedLibrary.typeProvider.intType.element;
610-
resolvedLibrary.getElementDeclaration(intClass);
607+
var intClass = resolvedLibrary.typeProvider.intType.element3;
608+
resolvedLibrary.getElementDeclaration2(intClass.firstFragment);
611609
}, throwsArgumentError);
612610
}
613611

@@ -618,22 +616,22 @@ int foo = 0;
618616

619617
var session = contextFor(testFile).currentSession;
620618
var resolvedLibrary = await session.getResolvedLibraryValid(testFile);
621-
var unitElement = resolvedLibrary.element.definingCompilationUnit;
619+
var unitElement = resolvedLibrary.element2.firstFragment;
622620

623-
var fooElement = unitElement.topLevelVariables[0];
624-
expect(fooElement.name, 'foo');
621+
var fooElement = unitElement.topLevelVariables2[0];
622+
expect(fooElement.name2, 'foo');
625623

626624
// We can get the variable element declaration.
627-
var fooDeclaration = resolvedLibrary.getElementDeclaration(fooElement)!;
625+
var fooDeclaration = resolvedLibrary.getElementDeclaration2(fooElement)!;
628626
var fooNode = fooDeclaration.node as VariableDeclaration;
629627
expect(fooNode.name.lexeme, 'foo');
630628
expect(fooNode.offset, 4);
631629
expect(fooNode.length, 7);
632-
expect(fooNode.declaredElement!.name, 'foo');
630+
expect(fooNode.declaredFragment!.name2, 'foo');
633631

634632
// Synthetic elements don't have nodes.
635-
expect(resolvedLibrary.getElementDeclaration(fooElement.getter!), isNull);
636-
expect(resolvedLibrary.getElementDeclaration(fooElement.setter!), isNull);
633+
expect(resolvedLibrary.getElementDeclaration2(fooElement.getter2!), isNull);
634+
expect(resolvedLibrary.getElementDeclaration2(fooElement.setter2!), isNull);
637635
}
638636

639637
test_getResolvedLibrary_inconsistent() async {
@@ -684,14 +682,14 @@ part 'c.dart';
684682
var libraryResult = await session.getLibraryByUriValid(
685683
'package:test/test.dart',
686684
);
687-
var element = libraryResult.element;
685+
var element = libraryResult.element2;
688686

689687
var result = await session.getResolvedLibraryByElementValid(element);
690688
expect(result.session, session);
691689
expect(result.units, hasLength(1));
692690
expect(result.units[0].path, test.path);
693691
expect(result.units[0].uri, Uri.parse('package:test/test.dart'));
694-
expect(result.units[0].unit.declaredElement, isNotNull);
692+
expect(result.units[0].unit.declaredFragment, isNotNull);
695693
}
696694

697695
test_getResolvedLibraryByElement_differentSession() async {
@@ -701,12 +699,12 @@ part 'c.dart';
701699
var libraryResult = await session.getLibraryByUriValid(
702700
'package:test/test.dart',
703701
);
704-
var element = libraryResult.element;
702+
var element = libraryResult.element2;
705703

706704
var aaaFile = getFile('$workspaceRootPath/aaa/lib/a.dart');
707705
var aaaSession = contextFor(aaaFile).currentSession;
708706

709-
var result = await aaaSession.getResolvedLibraryByElement(element);
707+
var result = await aaaSession.getResolvedLibraryByElement2(element);
710708
expect(result, isA<NotElementOfThisSessionResult>());
711709
}
712710

@@ -724,7 +722,7 @@ class B {}
724722
expect(unitResult.uri, Uri.parse('package:test/test.dart'));
725723
expect(unitResult.unit.declarations, hasLength(2));
726724
expect(unitResult.typeProvider, isNotNull);
727-
expect(unitResult.libraryElement, isNotNull);
725+
expect(unitResult.libraryElement2, isNotNull);
728726
}
729727

730728
test_getResolvedUnit_inconsistent() async {
@@ -906,13 +904,13 @@ unitElementResult
906904

907905
sink.writelnWithIndent('element');
908906
sink.withIndent(() {
909-
var element = result.element as CompilationUnitElementImpl;
907+
var element = result.fragment as CompilationUnitElementImpl;
910908
sink.writelnWithIndent('reference: ${element.reference}');
911909

912-
var library = element.library;
910+
var library = (element as LibraryFragment).element as LibraryElementImpl;
913911
sink.writelnWithIndent('library: ${library.reference}');
914912

915-
var classListStr = element.classes.map((e) => e.name).join(', ');
913+
var classListStr = element.classes2.map((e) => e.name2).join(', ');
916914
sink.writelnWithIndent('classes: $classListStr');
917915
});
918916
});
@@ -934,8 +932,8 @@ extension on AnalysisSession {
934932
return await getLibraryByUri(uriStr) as LibraryElementResult;
935933
}
936934

937-
ParsedLibraryResult getParsedLibraryByElementValid(LibraryElement element) {
938-
return getParsedLibraryByElement(element) as ParsedLibraryResult;
935+
ParsedLibraryResult getParsedLibraryByElementValid(LibraryElement2 element) {
936+
return getParsedLibraryByElement2(element) as ParsedLibraryResult;
939937
}
940938

941939
ParsedLibraryResult getParsedLibraryValid(File file) {
@@ -947,8 +945,8 @@ extension on AnalysisSession {
947945
}
948946

949947
Future<ResolvedLibraryResult> getResolvedLibraryByElementValid(
950-
LibraryElement element) async {
951-
return await getResolvedLibraryByElement(element) as ResolvedLibraryResult;
948+
LibraryElement2 element) async {
949+
return await getResolvedLibraryByElement2(element) as ResolvedLibraryResult;
952950
}
953951

954952
Future<ResolvedLibraryResult> getResolvedLibraryValid(File file) async {

0 commit comments

Comments
 (0)