[vm,dyn_modules] Disable dart:mirrors in standalone VM when using interpreter

Bytecode doesn't fully support dart:mirrors and support for
dart:mirrors is already disabled in dart2bytecode.

This change disables dart:mirrors in the standalone VM running with
--interpreter flag and updates status files.

TEST=ci

Change-Id: Id9423bafb10926e8274835b77a6f50a825ad7fd7
Cq-Include-Trybots: luci.dart.try:vm-aot-dyn-linux-debug-x64-try,vm-aot-dyn-linux-product-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try,vm-ffi-dyn-mac-debug-simarm64_arm64-try,vm-ffi-dyn-mac-release-simarm64_arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451580
Reviewed-by: Ryan Macnak <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

Author: alexmarkov

runtime/tests/vm/vm.status

@@ -97,6 +97,8 @@ cc/TryCatchOptimizer_DeadParameterElimination_*: SkipByDesign # Building flow gr
 cc/TwoWayInduction: SkipByDesign # Building flow graph is not supported from bytecode.
 cc/TypePropagator_*: SkipByDesign # Building flow graph is not supported from bytecode.
 cc/WrapAroundAndDerived: SkipByDesign # Building flow graph is not supported from bytecode.
+dart/await_type_check_with_dynamic_loading_test: SkipByDesign # dart:mirrors is not supported.
+dart/redirection_type_shuffling_test: SkipByDesign # dart:mirrors is not supported.
 dart/regress_52703_test: Pass, Slow
 
 [ $compiler == dartk ]

runtime/vm/kernel_isolate.cc

@@ -917,7 +917,7 @@ class KernelCompilationRequest : public ValueObject {
 
     Dart_CObject enable_mirrors;
     enable_mirrors.type = Dart_CObject_kBool;
-    enable_mirrors.value.as_bool = FLAG_enable_mirrors;
+    enable_mirrors.value.as_bool = FLAG_enable_mirrors && !FLAG_interpreter;
 
     Dart_CObject generate_bytecode;
     generate_bytecode.type = Dart_CObject_kBool;

tests/co19/co19-kernel.status

@@ -2,11 +2,6 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
-[ $runtime == dart_precompiled ]
-Language/Classes/Instance_Methods/Operators/unary_minus_t01: SkipByDesign # dart:mirrors is not supported
-Language/Expressions/Constants/Constant_Contexts/constant_context_A02_t01: SkipByDesign # dart:mirrors is not supported.
-LibTest/mirrors/*: SkipByDesign # dart:mirrors is not supported:
-
 [ $runtime == vm ]
 LibTest/collection/ListBase/ListBase_class_A01_t02: Slow, Pass # Does many calls
 LibTest/collection/ListMixin/ListMixin_class_A01_t02: Slow, Pass # Does many calls
@@ -27,6 +22,11 @@ LibTest/core/List/List_class_A01_t03: Slow, Pass
 LibTest/collection/ListBase/ListBase_class_A01_t01: SkipSlow # Issue 43036
 LibTest/collection/ListMixin/ListMixin_class_A01_t01: SkipSlow # Issue 43036
 
+[ $compiler == dart2bytecode || $runtime == dart_precompiled ]
+Language/Classes/Instance_Methods/Operators/unary_minus_t01: SkipByDesign # dart:mirrors is not supported.
+Language/Expressions/Constants/Constant_Contexts/constant_context_A02_t01: SkipByDesign # dart:mirrors is not supported.
+LibTest/mirrors/*: SkipByDesign # dart:mirrors is not supported.
+
 # It makes no sense to run any test that uses spawnURI under the simulator
 # as that would involve running CFE (the front end) in simulator mode
 # to compile the URI file specified in spawnURI code.

tests/language/language.status

@@ -24,7 +24,7 @@ unsorted/invocation_mirror_test: SkipByDesign # Relies on symbol names
 vm/type_cast_vm_test: SkipByDesign # Relies on symbol names
 
 [ $compiler == dart2bytecode ]
-vm/reflect_core_vm_test: Crash
+vm/reflect_core_vm_test: SkipByDesign # dart:mirrors is not supported.
 
 [ $compiler != fasta ]
 value_class/*: Skip # Internship, jlcontreras

tests/language/library/env_test.dart

@@ -53,7 +53,7 @@ main() {
 
   // `dart:mirrors` is only supported in JIT mode.
   Expect.equals(
-    isVmJitConfiguration,
+    isVmJitConfiguration && !configAsString.contains('-dyn-'),
     const bool.fromEnvironment("dart.library.mirrors"),
   );
 

tests/lib/lib.status

@@ -6,6 +6,10 @@ html/cross_frame_test: Skip # Issue 32039, test reloads itself (not by design -
 [ $arch == simarm ]
 convert/utf85_test: Skip # Pass, Slow Issue 12644.
 
+[ $compiler == dart2bytecode ]
+isolate/illegal_msg_mirror_test: SkipByDesign # dart:mirrors is not supported.
+mirrors/*: SkipByDesign # dart:mirrors is not supported.
+
 [ $compiler == dart2wasm ]
 fix_data_tests/*: SkipByDesign
 html/*: SkipByDesign # dart:html not supported on dart2wasm

tests/standalone/standalone.status

@@ -46,6 +46,9 @@ io/socket_sigpipe_test: SkipByDesign # Spawns server process using Platform.exec
 [ $compiler == dart2analyzer ]
 deferred_transitive_import_error_test: Skip
 
+[ $compiler == dart2bytecode ]
+io/http_redirect_test: SkipByDesign # dart:mirrors is not supported.
+
 [ $compiler == dartkp ]
 lazy_async_stack_test: Skip # Flaky.