Skip to content

Commit 1f90293

Browse files
alexmarkovCommit Queue
authored andcommitted
[gardening] Fix gcc build of samples/embedder
GCC doesn't like // comments which are not terminated due to \ at the end of line. TEST=ci Change-Id: I9d6188bf1db9358804b488d73bef88ba5e6b4f39 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417220 Commit-Queue: Alexander Markov <[email protected]> Reviewed-by: Tess Strickland <[email protected]>
1 parent 73629e6 commit 1f90293

File tree

3 files changed

+21
-15
lines changed

3 files changed

+21
-15
lines changed

pkg/vm/tool/generate_entry_point_shims.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,20 @@ void main(List<String> args) async {
112112

113113
for (final buffer in [declarations, definitions]) {
114114
buffer.write('''
115-
// Generated with:
116-
// dart pkg/vm/tools/generate_entry_point_shims.dart \\
117-
// ''');
115+
/*
116+
Generated with:
117+
dart pkg/vm/tool/generate_entry_point_shims.dart \\
118+
''');
118119
if (createUninitializedInstanceMethods) {
119120
buffer.write('-u ');
120121
}
121122
if (uriString != null) {
122123
buffer.write('''-p $uriString \\
123-
// ''');
124+
''');
124125
}
125126
buffer.writeln('''$source \\
126-
// $outputPath
127+
$outputPath
128+
*/
127129
''');
128130
}
129131

samples/embedder/timer.cc

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4-
//
5-
// Generated with:
6-
// dart pkg/vm/tools/generate_entry_point_shims.dart \
7-
// out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \
8-
// samples/embedder/timer
4+
5+
/*
6+
Generated with:
7+
dart pkg/vm/tool/generate_entry_point_shims.dart \
8+
out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \
9+
samples/embedder/timer
10+
*/
911

1012
#include "timer.h"
1113

samples/embedder/timer.h

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4-
//
5-
// Generated with:
6-
// dart pkg/vm/tools/generate_entry_point_shims.dart \
7-
// out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \
8-
// samples/embedder/timer
4+
5+
/*
6+
Generated with:
7+
dart pkg/vm/tool/generate_entry_point_shims.dart \
8+
out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \
9+
samples/embedder/timer
10+
*/
911

1012
#ifndef SAMPLES_EMBEDDER_TIMER_H
1113
#define SAMPLES_EMBEDDER_TIMER_H

0 commit comments

Comments
 (0)