Skip to content

Commit 212e49f

Browse files
DanTupCommit Queue
authored andcommitted
[dds/dap] Treat "Service Connection Disposed" the same as "Client closed with pending request"
Should fix flutter/flutter#153473 Change-Id: I77bcf2da01d340412c3dc709a74cc8ed2d80a43f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381181 Reviewed-by: Helin Shiah <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Helin Shiah <[email protected]>
1 parent 4f77352 commit 212e49f

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

pkg/dds/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 4.2.6
2+
- [DAP] Fixed an issue where "Service connection disposed" errors may go unhandled during termination/shutdown.
3+
14
# 4.2.5+1
25
- Fix issue where `DartDevelopmentServiceException.fromJson` would throw a `StateError` whenever called, except when called to create an `ExistingDartDevelopmentServiceException`.
36

pkg/dds/lib/src/dap/adapters/dart.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2881,7 +2881,8 @@ abstract class DartDebugAdapter<TL extends LaunchRequestArguments,
28812881
// errors because these can always occur during shutdown if we were
28822882
// just starting to send (or had just sent) a request.
28832883
if (e.message.contains("The client is closed") ||
2884-
e.message.contains("The client closed with pending request")) {
2884+
e.message.contains("The client closed with pending request") ||
2885+
e.message.contains("Service connection disposed")) {
28852886
return null;
28862887
}
28872888
}

pkg/dds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: dds
2-
version: 4.2.5+1
2+
version: 4.2.6
33
description: >-
44
A library used to spawn the Dart Developer Service, used to communicate with
55
a Dart VM Service instance.

0 commit comments

Comments
 (0)