analyzer: Detect and report more cases of omitted args for Deprecated.optional parameters

Change-Id: I654a3b3bc5bea9c44368345bdd869c1d922e8178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451980
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -316,6 +316,16 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
     for (var v in _elementUsageFrontierDetectors) {
       v.pushElement(element);
     }
+    // TODO(srawlins): Use _deprecatedFunctionalityVerifier to detect omitted
+    // super-parameters corresponding to `@Deprecated.optional` parameters.
+    // TODO(srawlins): Use _deprecatedFunctionalityVerifier to detect omitted
+    // parameters in a redirecting factory constructor.
+    for (var redirectingConstructorInvocation
+        in node.initializers.whereType<RedirectingConstructorInvocation>()) {
+      _deprecatedFunctionalityVerifier.redirectingConstructorInvocation(
+        redirectingConstructorInvocation,
+      );
+    }
     try {
       super.visitConstructorDeclaration(node);
     } finally {
@@ -864,6 +874,7 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
     for (var v in _elementUsageFrontierDetectors) {
       v.superConstructorInvocation(node);
     }
+    _deprecatedFunctionalityVerifier.superConstructorInvocation(node);
     _invalidAccessVerifier.verifySuperConstructorInvocation(node);
     super.visitSuperConstructorInvocation(node);
   }

pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/src/dart/ast/ast.dart';
@@ -44,7 +45,7 @@ class DeprecatedFunctionalityVerifier {
     _checkForDeprecatedOptional(
       element: element,
       argumentList: node.argumentList,
-      errorNode: node.constructorName,
+      errorEntity: node.constructorName,
     );
     _checkForDeprecatedInstantiate(
       element: element.enclosingElement,
@@ -58,7 +59,7 @@ class DeprecatedFunctionalityVerifier {
     _checkForDeprecatedOptional(
       element: element,
       argumentList: node.argumentList,
-      errorNode: node.memberName,
+      errorEntity: node.memberName,
     );
   }
 
@@ -73,7 +74,7 @@ class DeprecatedFunctionalityVerifier {
     _checkForDeprecatedOptional(
       element: constructor,
       argumentList: node.argumentList,
-      errorNode: node.constructorName,
+      errorEntity: node.constructorName,
     );
     var interfaceElement = node.constructorName.type.element;
     if (interfaceElement is! InterfaceElement) return;
@@ -90,7 +91,7 @@ class DeprecatedFunctionalityVerifier {
     _checkForDeprecatedOptional(
       element: method,
       argumentList: node.argumentList,
-      errorNode: node.methodName,
+      errorEntity: node.methodName,
     );
   }
 
@@ -101,6 +102,26 @@ class DeprecatedFunctionalityVerifier {
     _checkForDeprecatedImplement(node.onClause?.superclassConstraints);
   }
 
+  void redirectingConstructorInvocation(RedirectingConstructorInvocation node) {
+    var element = node.element;
+    if (element is! ConstructorElement) return;
+    _checkForDeprecatedOptional(
+      element: element,
+      argumentList: node.argumentList,
+      errorEntity: node.constructorName ?? node.thisKeyword,
+    );
+  }
+
+  void superConstructorInvocation(SuperConstructorInvocation node) {
+    var constructor = node.element;
+    if (constructor == null) return;
+    _checkForDeprecatedOptional(
+      element: constructor,
+      argumentList: node.argumentList,
+      errorEntity: node.constructorName ?? node.superKeyword,
+    );
+  }
+
   void _checkForDeprecatedExtend(NamedType? node) {
     if (node == null) return;
     var element = node.element;
@@ -179,7 +200,7 @@ class DeprecatedFunctionalityVerifier {
   void _checkForDeprecatedOptional({
     required ExecutableElement element,
     required ArgumentList argumentList,
-    required AstNode errorNode,
+    required SyntacticEntity errorEntity,
   }) {
     var omittedParameters = element.formalParameters.toList();
     for (var argument in argumentList.arguments) {
@@ -189,8 +210,8 @@ class DeprecatedFunctionalityVerifier {
     }
     for (var parameter in omittedParameters) {
       if (parameter.isDeprecatedWithKind('optional')) {
-        _diagnosticReporter.atNode(
-          errorNode,
+        _diagnosticReporter.atEntity(
+          errorEntity,
           WarningCode.deprecatedOptional,
           arguments: [parameter.name ?? '<unknown>'],
         );

pkg/analyzer/test/src/diagnostics/deprecated_optional_test.dart

@@ -138,6 +138,60 @@ void g(D d) {
 ''');
   }
 
+  test_argumentOmitted_redirectedConstructor() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  C([@Deprecated.optional() int? p]);
+  C.two() : this();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 60, 4)],
+    );
+  }
+
+  test_argumentOmitted_redirectedConstructor_named() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  C.one([@Deprecated.optional() int? p]);
+  C.two() : this.one();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 69, 3)],
+    );
+  }
+
+  test_argumentOmitted_superInvocation() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  C([@Deprecated.optional() int? p]);
+}
+
+class D extends C {
+  D() : super();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 79, 5)],
+    );
+  }
+
+  test_argumentOmitted_superInvocation_named() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  C.named([@Deprecated.optional() int? p]);
+}
+
+class D extends C {
+  D() : super.named();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 91, 5)],
+    );
+  }
+
   test_noAnnotation() async {
     await assertNoErrorsInCode(r'''
 void f([int? p]) {}