linter: deprecate AnalysisRule.lintCode

Work towards #50986

Change-Id: Iedf1127b9f04aec910647c7f35597f38c6bfe1d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428846
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart

@@ -8,7 +8,7 @@ import 'package:analysis_server/lsp_protocol/protocol.dart';
 import 'package:analysis_server/src/lsp/constants.dart';
 import 'package:analysis_server/src/lsp/extensions/code_action.dart';
 import 'package:analysis_server/src/services/correction/fix_internal.dart';
-import 'package:analyzer/src/dart/error/lint_codes.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/lint/registry.dart';
 import 'package:analyzer/src/test_utilities/test_code_format.dart';
@@ -817,5 +817,5 @@ class _DeprecatedCamelCaseTypes extends LintRule {
       );
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 }

pkg/analysis_server/test/src/services/completion/yaml/analysis_options_generator_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/src/services/completion/yaml/analysis_options_generator.dart';
-import 'package:analyzer/src/dart/error/lint_codes.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/task/options.dart';
 import 'package:analyzer/src/test_utilities/lint_registration_mixin.dart';
@@ -316,7 +316,7 @@ class InternalRule extends LintRule {
     : super(name: 'internal_lint', state: State.internal(), description: '');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 }
 
 class _RemovedLint extends LintRule {
@@ -326,5 +326,5 @@ class _RemovedLint extends LintRule {
     : super(name: 'removed_lint', state: State.removed(), description: '');
 
   @override
-  LintCode get lintCode => _code;
+  DiagnosticCode get diagnosticCode => _code;
 }

pkg/analysis_server/test/src/services/correction/fix/analysis_options/remove_lint_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/src/dart/error/lint_codes.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/test_utilities/lint_registration_mixin.dart';
 import 'package:linter/src/rules.dart';
@@ -31,7 +31,7 @@ class DeprecatedRule extends LintRule {
       );
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 }
 
 class RemovedRule extends LintRule {
@@ -45,7 +45,7 @@ class RemovedRule extends LintRule {
     : super(name: 'removed_rule', description: '', state: State.removed());
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 }
 
 @reflectiveTest

pkg/analysis_server_plugin/test/src/lint_rules.dart

@@ -13,7 +13,7 @@ class NoBoolsRule extends AnalysisRule {
   NoBoolsRule() : super(name: 'no_bools', description: 'No bools desc');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(
@@ -30,7 +30,7 @@ class NoDoublesRule extends AnalysisRule {
       : super(name: 'no_doubles', description: 'No doubles message');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -265,7 +265,7 @@ class _ThrowsAsyncErrorRule extends AnalysisRule {
       : super(name: 'no_bools', description: 'No bools desc');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(
@@ -312,7 +312,7 @@ class _ThrowsSyncErrorRule extends AnalysisRule {
       : super(name: 'no_bools', description: 'No bools desc');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(

pkg/analyzer/lib/src/lint/linter.dart

@@ -161,14 +161,14 @@ abstract class AnalysisRule extends AbstractAnalysisRule {
   AnalysisRule({required super.name, required super.description, super.state});
 
   /// The code to report for a violation.
-  DiagnosticCode get diagnosticCode => lintCode;
+  DiagnosticCode get diagnosticCode;
 
   @override
-  List<DiagnosticCode> get diagnosticCodes => [lintCode];
+  List<DiagnosticCode> get diagnosticCodes => [diagnosticCode];
 
   /// The code to report for a violation.
-  // TODO(srawlins): Deprecate this in favor of `diagnosticCode`.
-  LintCode get lintCode;
+  @Deprecated("Use 'diagnosticCode' instead.")
+  DiagnosticCode get lintCode => diagnosticCode;
 
   /// Reports a diagnostic at [node] with message [arguments] and
   /// [contextMessages].

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -8,6 +8,7 @@ import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/diagnostic/diagnostic.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
@@ -39976,7 +39977,7 @@ class _AlwaysReportedLint extends LintRule {
   _AlwaysReportedLint() : super(name: 'always_reported_lint', description: '');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(

pkg/analyzer/test/src/diagnostics/removed_lint_use_test.dart

@@ -25,7 +25,7 @@ class RemovedLint extends LintRule {
       );
 
   @override
-  LintCode get lintCode => throw UnimplementedError();
+  DiagnosticCode get diagnosticCode => throw UnimplementedError();
 }
 
 @reflectiveTest

pkg/analyzer/test/src/diagnostics/replaced_lint_use_test.dart

@@ -25,7 +25,7 @@ class RemovedLint extends LintRule {
       );
 
   @override
-  LintCode get lintCode => throw UnimplementedError();
+  DiagnosticCode get diagnosticCode => throw UnimplementedError();
 }
 
 @reflectiveTest
@@ -83,5 +83,5 @@ class ReplacingLint extends LintRule {
       );
 
   @override
-  LintCode get lintCode => throw UnimplementedError();
+  DiagnosticCode get diagnosticCode => throw UnimplementedError();
 }

pkg/analyzer/test/src/diagnostics/unignorable_ignore_test.dart

@@ -4,6 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/test_utilities/lint_registration_mixin.dart';
@@ -80,7 +81,7 @@ class UnignorableIgnoreTest extends PubPackageResolutionTest
 // ignore: avoid_int
 int a = 0;
 ''',
-      [error(avoidIntRule.lintCode, 21, 3)],
+      [error(avoidIntRule.diagnosticCode, 21, 3)],
     );
   }
 }
@@ -95,7 +96,7 @@ class _AvoidIntRule extends LintRule {
   _AvoidIntRule() : super(name: 'avoid_int', description: '');
 
   @override
-  LintCode get lintCode => code;
+  DiagnosticCode get diagnosticCode => code;
 
   @override
   void registerNodeProcessors(