Skip to content

Commit 23c8a11

Browse files
sigmundchCommit Queue
authored andcommitted
[dyn_modules] build dart2bytecode regardless
Change-Id: Ic12c18801765149fc017373a639513e46a0f2bea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424640 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
1 parent 8c89088 commit 23c8a11

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

sdk/BUILD.gn

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ declare_args() {
4242
# ......utils/gen_snapshot or utils/gen_snapshot.exe (if not on ia32)
4343
# ......snapshots/
4444
# ........analysis_server.dart.snapshot
45-
# ........dart2bytecode.snapshot (if dart_dynamic_modules)
45+
# ........dart2bytecode.snapshot (AOT snapshot, for selected targets)
4646
# ........dart2js_aot.dart.snapshot (AOT snapshot, if not on ia32)
4747
# ........dart2js.dart.snapshot (JIT snapshot only on ia32)
4848
# ........dart2wasm_product.snapshot (if not on ia32)
@@ -172,7 +172,11 @@ if (dart_snapshot_kind == "app-jit") {
172172
"kernel-service",
173173
] ]
174174
}
175-
if (dart_dynamic_modules) {
175+
176+
# dart2bytecode is an AOT snapshot, which is not supported on the ia32
177+
# architecture. It is only included as needed on a subset of OS targets.
178+
if ((dart_target_arch == "x64" || dart_target_arch == "arm64") &&
179+
(dart_dynamic_modules || target_os == "linux" || target_os == "mac")) {
176180
_platform_sdk_snapshots += [ [
177181
"dart2bytecode",
178182
"../utils/dart2bytecode:dart2bytecode",

0 commit comments

Comments
 (0)