Skip to content

Commit 24e89ca

Browse files
devoncarewCommit Queue
authored andcommitted
[deps] rev dartdoc, protobuf, test, tools
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/98d03ad..6d1aa6f): 6d1aa6f5 2025-10-23 Sam Rawlins Refactor Locatable into an interface, HasLocation (dart-lang/dartdoc#4118) f82cd35d 2025-10-23 Sam Rawlins Remove unused extension method, replaced in analyzer 8.4.0 (dart-lang/dartdoc#4119) protobuf (https://github.com/dart-lang/protobuf/compare/78cf743..7db0784): 7db0784 2025-10-24 Ömer Sinan Ağacan Avoid redundant nullability checks when updating repeated fields (google/protobuf.dart#1069) a77f9a6 2025-10-23 Ömer Sinan Ağacan More field validation tests (google/protobuf.dart#1068) 27730db 2025-10-21 Ömer Sinan Ağacan Move PbMap to its own library (google/protobuf.dart#1066) 9b4c46f 2025-10-21 Ömer Sinan Ağacan More clearExtension tests: (google/protobuf.dart#1064) 5a44489 2025-10-21 Ömer Sinan Ağacan Move PbList to its own library (google/protobuf.dart#1063) test (https://github.com/dart-lang/test/compare/8083c8f..5855358): 58553580 2025-10-24 Nate Bosch Add a sentence to clarify "Platform" (dart-lang/test#2550) tools (https://github.com/dart-lang/tools/compare/5fe6ee6..e0cc0bc): e0cc0bcc 2025-10-27 Morgan :) Test DirectoryWatcher exception on missing path. (dart-lang/tools#2224) e6ce99da 2025-10-24 Morgan :) Test new link to directory races, fix for them (dart-lang/tools#2223) 9053fae7 2025-10-24 Morgan :) Check file sizes as well as "last modified" times. (dart-lang/tools#2221) Change-Id: Ica6937ba0af21c5ba435e97bd0673fbe7b3043cc Tested: update test goldens Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457800 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
1 parent 1f0437e commit 24e89ca

File tree

5 files changed

+25
-21
lines changed

5 files changed

+25
-21
lines changed

DEPS

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,21 +133,21 @@ vars = {
133133
# EOL comment after a dependency to instead pin at the current revision.
134134
"ai_rev": "0a85ddf4f75cee6e3abe07cecdffae69bbdbc793",
135135
"core_rev": "5c3e2c38df268be2347f3aad30ced0147dd012bb", # b/444274553
136-
"dartdoc_rev": "98d03ad2cc341d1fb053e0addfc96ba35301976b",
136+
"dartdoc_rev": "6d1aa6f5045c33d3723aba05e3e0dc1403b763c0",
137137
"ecosystem_rev": "6a8746e70b315aceec7f81cae9bef8b67abb2453",
138138
"flute_rev": "b84119fba67016a80c3eb80765762bcc4d0d0b8d",
139139
"http_rev": "2cb6c12966e18abc11a0217a8b613742849a29ea",
140140
"i18n_rev": "34d1832b7e65d9aef1f7f6a82c22f6e53476191c",
141141
"leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # rolled manually
142142
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
143143
"native_rev": "3ec573500f743d4a1393f7802143aef50fec0a47", # rolled manually while native assets are experimental
144-
"protobuf_rev": "78cf7432a6b1a0771042a1931047cf7c15d931c6",
144+
"protobuf_rev": "7db07843c86de526edbe3c4d668c0962ef0b203b",
145145
"pub_rev": "f7f1891e2de3d795532f45ec214f88ac912ffcd6", # rolled manually
146146
"shelf_rev": "710b8cef08f69acf176c807eaf274dfb8656fde0",
147147
"sync_http_rev": "6666fff944221891182e1f80bf56569338164d72",
148148
"tar_rev": "13479f7c2a18f499e840ad470cfcca8c579f6909",
149-
"test_rev": "8083c8f24ffbca58cc0385add03c296b70636e7a",
150-
"tools_rev": "5fe6ee6fe1e545fab5e253c3a57f279f7000a807",
149+
"test_rev": "5855358095b8718712567b8abc0435ddfd125ba8",
150+
"tools_rev": "e0cc0bcc7f685e913ef87624951487e4a2c76d0f",
151151
"vector_math_rev": "a7b7e9ccb931348dbfa669e0f8fea1bf97705b16",
152152
"web_rev": "5a7d0be70a258252b95bac6b900f26d6dae4d433",
153153
"webdev_rev": "b9c39c00853dfad0e235bec3b265f86a0f4f328a",

pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/create_test.dart.expect

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ static method main() → dynamic {
4848
[@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.barKeep] [@vm.inferred-type.metadata=? (skip check)] #t1.{pb::FooKeep::barKeep} = let final pb::BarKeep #t2 = [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep] pb::BarKeep::•() in block {
4949
[@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=? (skip check)] #t2.{pb::BarKeep::aKeep} = 5;
5050
} =>#t2;
51-
[@vm.call-site-attributes.metadata=receiverType:dart.core::Map<dart.core::String, library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep>] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap.[]=] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap] #t1.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]=}("foo", let final pb::BarKeep #t3 = [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep] pb::BarKeep::•() in block {
51+
[@vm.call-site-attributes.metadata=receiverType:dart.core::Map<dart.core::String, library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep>] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap.[]=] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap] #t1.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]=}("foo", let final pb::BarKeep #t3 = [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep] pb::BarKeep::•() in block {
5252
[@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=? (skip check)] #t3.{pb::BarKeep::aKeep} = 2;
5353
} =>#t3){(core::String, pb::BarKeep) → void};
5454
[@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.aKeep] [@vm.inferred-type.metadata=? (skip check)] #t1.{pb::FooKeep::aKeep} = 43;
5555
} =>#t1;
5656
sca::test([@vm.closure-id=1]() → Null {
5757
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.barKeep] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep] foo.{pb::FooKeep::barKeep}{pb::BarKeep}.{pb::BarKeep::aKeep}{core::int}, 5);
58-
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap.[]] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep? (skip check)] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap] foo.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]}("foo"){(core::Object?) → pb::BarKeep?}!.{pb::BarKeep::aKeep}{core::int}, 2);
58+
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap.[]] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep? (skip check)] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap] foo.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]}("foo"){(core::Object?) → pb::BarKeep?}!.{pb::BarKeep::aKeep}{core::int}, 2);
5959
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.hasHasKeep] [@vm.inferred-type.metadata=dart.core::bool (skip check)] foo.{pb::FooKeep::hasHasKeep}(){() → core::bool}, false);
6060
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.aKeep] [@vm.inferred-type.metadata=int] foo.{pb::FooKeep::aKeep}{core::int}, 43);
6161
[@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.clearClearKeep] [@vm.inferred-type.metadata=? (skip check)] foo.{pb::FooKeep::clearClearKeep}(){() → void};
@@ -65,6 +65,7 @@ library foo.pb.dart;
6565
import self as self;
6666
import "package:protobuf/src/protobuf/internal.dart" as int;
6767
import "dart:core" as core;
68+
import "package:protobuf/src/protobuf/pb_map.dart" as pb_;
6869

6970
import "dart:core" as $core;
7071
import "package:protobuf/src/protobuf/internal.dart";
@@ -112,11 +113,11 @@ class FooKeep extends int::GeneratedMessage {
112113
[@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.setField] [@vm.inferred-type.metadata=? (skip check)] this.{int::GeneratedMessage::setField}(v){(core::int, core::Object) → void};
113114
}
114115

115-
[@vm.inferred-return-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap]
116+
[@vm.inferred-return-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap]
116117
[@vm.procedure-attributes.metadata=methodOrSetterCalledDynamically:false,getterCalledDynamically:false,hasThisUses:false,hasNonThisUses:false,hasTearOffUses:false,getterSelectorId:4]
117118
@#C11
118119
get mapKeep() → core::Map<core::String, self::BarKeep>
119-
return [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.$_getMap] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap (skip check)] this.{int::GeneratedMessage::$_getMap}<core::String, self::BarKeep>(){(core::int) → int::PbMap<core::String, self::BarKeep>};
120+
return [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.$_getMap] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap (skip check)] this.{int::GeneratedMessage::$_getMap}<core::String, self::BarKeep>(){(core::int) → pb_::PbMap<core::String, self::BarKeep>};
120121

121122
[@vm.inferred-return-type.metadata=int]
122123
[@vm.procedure-attributes.metadata=methodOrSetterCalledDynamically:false,getterCalledDynamically:false,hasThisUses:false,hasNonThisUses:false,hasTearOffUses:false,methodOrSetterSelectorId:5,getterSelectorId:6]

pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/decode_test.dart.expect

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static field core::List<core::int> buffer = <core::int>[10, 4, 8, 5, 16, 4, 26,
4949
static method main() → dynamic {
5050
[@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep] pb::FooKeep foo = [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep] pb::FooKeep::fromBuffer([@vm.inferred-type.metadata=dart.core::_GrowableList<dart.core::int>] self::buffer);
5151
sca::test([@vm.closure-id=1]() → Null {
52-
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap.[]] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep? (skip check)] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap] foo.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]}("foo"){(core::Object?) → pb::BarKeep?}!.{pb::BarKeep::aKeep}{core::int}, 42);
52+
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap.[]] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep? (skip check)] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.mapKeep] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap] foo.{pb::FooKeep::mapKeep}{core::Map<core::String, pb::BarKeep>}.{core::Map::[]}("foo"){(core::Object?) → pb::BarKeep?}!.{pb::BarKeep::aKeep}{core::int}, 42);
5353
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep.aKeep] [@vm.inferred-type.metadata=int] [@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.barKeep] [@vm.inferred-type.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::BarKeep] foo.{pb::FooKeep::barKeep}{pb::BarKeep}.{pb::BarKeep::aKeep}{core::int}, 5);
5454
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.aKeep] [@vm.inferred-type.metadata=int] foo.{pb::FooKeep::aKeep}{core::int}, 43);
5555
exp::expect([@vm.direct-call.metadata=library file:pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/generated/foo.pb.dart::FooKeep.hasHasKeep] [@vm.inferred-type.metadata=dart.core::bool (skip check)] foo.{pb::FooKeep::hasHasKeep}(){() → core::bool}, true);
@@ -60,6 +60,7 @@ library foo.pb.dart;
6060
import self as self;
6161
import "package:protobuf/src/protobuf/internal.dart" as int;
6262
import "dart:core" as core;
63+
import "package:protobuf/src/protobuf/pb_map.dart" as pb_;
6364

6465
import "dart:core" as $core;
6566
import "package:protobuf/src/protobuf/internal.dart";
@@ -103,11 +104,11 @@ class FooKeep extends int::GeneratedMessage {
103104
get barKeep() → self::BarKeep
104105
return [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.$_getN] [@vm.inferred-type.metadata=foo.pb.dart::BarKeep (skip check)] this.{int::GeneratedMessage::$_getN}<self::BarKeep>(){(core::int) → self::BarKeep};
105106

106-
[@vm.inferred-return-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap]
107+
[@vm.inferred-return-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap]
107108
[@vm.procedure-attributes.metadata=methodOrSetterCalledDynamically:false,getterCalledDynamically:false,hasThisUses:false,hasNonThisUses:false,hasTearOffUses:false,getterSelectorId:3]
108109
@#C12
109110
get mapKeep() → core::Map<core::String, self::BarKeep>
110-
return [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.$_getMap] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/internal.dart::PbMap (skip check)] this.{int::GeneratedMessage::$_getMap}<core::String, self::BarKeep>(){(core::int) → int::PbMap<core::String, self::BarKeep>};
111+
return [@vm.direct-call.metadata=library package:protobuf/src/protobuf/internal.dart::GeneratedMessage.$_getMap] [@vm.inferred-type.metadata=library package:protobuf/src/protobuf/pb_map.dart::PbMap (skip check)] this.{int::GeneratedMessage::$_getMap}<core::String, self::BarKeep>(){(core::int) → pb_::PbMap<core::String, self::BarKeep>};
111112

112113
[@vm.inferred-return-type.metadata=int]
113114
[@vm.procedure-attributes.metadata=methodOrSetterCalledDynamically:false,getterCalledDynamically:false,hasThisUses:false,hasNonThisUses:false,hasTearOffUses:false,getterSelectorId:4]

0 commit comments

Comments
 (0)