analyzer: Add LintRule.report* methods that don't use the word Lint

Since these can be used to report warnings, in analyzer plugins, we need
to rename them before moving them to be in the public API.

* reportLint          -> reportAtNode
* reportLintForOffset -> reportAtOffset
* reportLintForToken  -> reportAtToken
* reportPubLint       -> reportAtPubNode

After landing these replacements, can start updating call sites and
removing the old names.

based on naming in: https://docs.google.com/document/d/12keEm32bCp8e1SpUM-25RZsuhPED3CkJzlRof4AiEF4/edit?resourcekey=0-b8hNBIXx4fSuubCzQxNbuw&tab=t.0#heading=h.d3j522v1l734

Change-Id: Icdbd43ae9a83b997901125ee286efb0b0745af71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424561
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -245,7 +245,12 @@ abstract class LintRule {
     LinterContext context,
   ) {}
 
-  void reportLint(
+  /// Reports a diagnostic at [node] with message [arguments] and
+  /// [contextMessages].
+  ///
+  /// The error reported is either [errorCode] if that is passed in, otherwise
+  /// [lintCode].
+  void reportAtNode(
     AstNode? node, {
     List<Object> arguments = const [],
     List<DiagnosticMessage>? contextMessages,
@@ -261,7 +266,12 @@ abstract class LintRule {
     }
   }
 
-  void reportLintForOffset(
+  /// Reports a diagnostic at [offset], with [length], with message [arguments]
+  /// and [contextMessages].
+  ///
+  /// The error reported is either [errorCode] if that is passed in, otherwise
+  /// [lintCode].
+  void reportAtOffset(
     int offset,
     int length, {
     List<Object> arguments = const [],
@@ -277,7 +287,35 @@ abstract class LintRule {
     );
   }
 
-  void reportLintForToken(
+  /// Reports a diagnostic at Pubspec [node], with message [arguments] and
+  /// [contextMessages].
+  ///
+  /// The error reported is either [errorCode] if that is passed in, otherwise
+  /// [lintCode].
+  void reportAtPubNode(
+    PSNode node, {
+    List<Object> arguments = const [],
+    List<DiagnosticMessage> contextMessages = const [],
+    ErrorCode? errorCode,
+  }) {
+    // Cache error and location info for creating `AnalysisErrorInfo`s.
+    var error = AnalysisError.tmp(
+      source: node.source,
+      offset: node.span.start.offset,
+      length: node.span.length,
+      errorCode: errorCode ?? lintCode,
+      arguments: arguments,
+      contextMessages: contextMessages,
+    );
+    reporter.reportError(error);
+  }
+
+  /// Reports a diagnostic at [token], with message [arguments] and
+  /// [contextMessages].
+  ///
+  /// The error reported is either [errorCode] if that is passed in, otherwise
+  /// [lintCode].
+  void reportAtToken(
     Token token, {
     List<Object> arguments = const [],
     List<DiagnosticMessage>? contextMessages,
@@ -293,23 +331,59 @@ abstract class LintRule {
     }
   }
 
+  // TODO(srawlins): Deprecate this in favor of [reportNode].
+  void reportLint(
+    AstNode? node, {
+    List<Object> arguments = const [],
+    List<DiagnosticMessage>? contextMessages,
+    ErrorCode? errorCode,
+  }) => reportAtNode(
+    node,
+    arguments: arguments,
+    contextMessages: contextMessages,
+    errorCode: errorCode,
+  );
+
+  // TODO(srawlins): Deprecate this in favor of [reportOffset].
+  void reportLintForOffset(
+    int offset,
+    int length, {
+    List<Object> arguments = const [],
+    List<DiagnosticMessage>? contextMessages,
+    ErrorCode? errorCode,
+  }) => reportAtOffset(
+    offset,
+    length,
+    arguments: arguments,
+    contextMessages: contextMessages,
+    errorCode: errorCode,
+  );
+
+  // TODO(srawlins): Deprecate this in favor of [reportToken].
+  void reportLintForToken(
+    Token token, {
+    List<Object> arguments = const [],
+    List<DiagnosticMessage>? contextMessages,
+    ErrorCode? errorCode,
+  }) => reportAtToken(
+    token,
+    arguments: arguments,
+    contextMessages: contextMessages,
+    errorCode: errorCode,
+  );
+
+  // TODO(srawlins): Deprecate this in favor of [reportPubNode].
   void reportPubLint(
     PSNode node, {
     List<Object> arguments = const [],
     List<DiagnosticMessage> contextMessages = const [],
     ErrorCode? errorCode,
-  }) {
-    // Cache error and location info for creating `AnalysisErrorInfo`s.
-    var error = AnalysisError.tmp(
-      source: node.source,
-      offset: node.span.start.offset,
-      length: node.span.length,
-      errorCode: errorCode ?? lintCode,
-      arguments: arguments,
-      contextMessages: contextMessages,
-    );
-    reporter.reportError(error);
-  }
+  }) => reportAtPubNode(
+    node,
+    arguments: arguments,
+    contextMessages: contextMessages,
+    errorCode: errorCode,
+  );
 }
 
 /// Provides access to information needed by lint rules that is not available