Fine. Changes to analyzer/ and linter/ to not trigger opaqu API usage.

With these changes I was able to run all linter/ tests without any
opaque API usage stack trace.

Change-Id: I28a5de8a0fce47efdf16f7dd845cda103fddb92c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450422
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5139,9 +5139,8 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   }
 
   @override
-  @trackedDirectlyOpaque
+  @trackedIndirectly
   ExecutableElement? getInterfaceMember(Name name) {
-    globalResultRequirements?.recordOpaqueApiUse(this, 'getInterfaceMember');
     return inheritanceManager.getMember(this, name);
   }
 

pkg/analyzer/lib/src/summary2/extension_type.dart

@@ -67,10 +67,12 @@ class _Node extends graph.Node<_Node> {
 
     var dependencies = <_Node>[];
     for (var element in visitor.dependencies) {
-      var declaration = walker.linker.getLinkingNode2(element.firstFragment);
-      if (declaration is ExtensionTypeDeclarationImpl) {
-        var node = walker.getNode(declaration);
-        dependencies.add(node);
+      if (walker.linker.isLinkingElement(element)) {
+        var declaration = walker.linker.getLinkingNode2(element.firstFragment);
+        if (declaration is ExtensionTypeDeclarationImpl) {
+          var node = walker.getNode(declaration);
+          dependencies.add(node);
+        }
       }
     }
 

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -9229,6 +9229,128 @@ class C extends A implements B {}
     );
   }
 
+  test_dependency_class_instanceMethod_change_getInterfaceMember() async {
+    configuration
+      ..withGetErrorsEvents = false
+      ..withStreamResolvedUnitResults = false;
+
+    _ManualRequirements.install((state) {
+      var B = state.singleUnit.scopeClassElement('B');
+      B.getInterfaceMember(Name(null, 'foo'));
+    });
+
+    await _runChangeScenarioTA(
+      initialA: r'''
+abstract class A {
+  int foo();
+}
+
+abstract class B extends A {}
+''',
+      testCode: r'''
+import 'a.dart';
+''',
+      operation: _FineOperationTestFileGetErrors(),
+      expectedInitialEvents: r'''
+[status] working
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/a.dart
+    declaredClasses
+      A: #M0
+        declaredMethods
+          foo: #M1
+        interface: #M2
+          map
+            foo: #M1
+      B: #M3
+        interface: #M4
+          map
+            foo: #M1
+          inherited
+            foo: #M1
+  requirements
+[operation] linkLibraryCycle
+  package:test/test.dart
+  requirements
+[operation] analyzeFile
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+  requirements
+    libraries
+      package:test/a.dart
+        libraryMetadataId: #M5
+        exportedTopLevels
+          B: #M3
+          B=: <null>
+        reExportDeprecatedOnly
+          B: false
+        interfaces
+          B
+            methods
+              foo: #M1
+[status] idle
+''',
+      updatedA: r'''
+abstract class A {
+  double foo();
+}
+
+abstract class B extends A {}
+''',
+      expectedUpdatedEvents: r'''
+[status] working
+[operation] linkLibraryCycle
+  package:test/a.dart
+    declaredClasses
+      A: #M0
+        declaredMethods
+          foo: #M6
+        interface: #M7
+          map
+            foo: #M6
+      B: #M3
+        interface: #M8
+          map
+            foo: #M6
+          inherited
+            foo: #M6
+  requirements
+[operation] reuseLinkedBundle
+  package:test/test.dart
+[operation] checkLibraryDiagnosticsRequirements
+  library: /home/test/lib/test.dart
+  instanceMethodIdMismatch
+    libraryUri: package:test/a.dart
+    interfaceName: B
+    methodName: foo
+    expectedId: #M1
+    actualId: #M6
+[operation] analyzeFile
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+  requirements
+    libraries
+      package:test/a.dart
+        libraryMetadataId: #M5
+        exportedTopLevels
+          B: #M3
+          B=: <null>
+        reExportDeprecatedOnly
+          B: false
+        interfaces
+          B
+            methods
+              foo: #M6
+[status] idle
+''',
+    );
+  }
+
   test_dependency_class_instanceMethod_change_getMethod() async {
     _ManualRequirements.install((state) {
       var A = state.singleUnit.scopeInstanceElement('A');

pkg/linter/lib/src/extensions.dart

@@ -331,7 +331,7 @@ extension ElementExtension on Element? {
     var self = this;
     return self is TopLevelFunctionElement &&
         self.name == 'print' &&
-        self.firstFragment.libraryFragment.element.isDartCore;
+        self.library.isDartCore;
   }
 
   /// Returns the class member that is overridden by `this`, if there is one,

pkg/linter/lib/src/rules/deprecated_member_use_from_same_package.dart

@@ -13,6 +13,7 @@ import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart';
+import 'package:analyzer/src/dart/element/element.dart'; // ignore: implementation_imports
 import 'package:analyzer/src/dart/element/extensions.dart'; // ignore: implementation_imports
 import 'package:analyzer/src/error/deprecated_member_use_verifier.dart' // ignore: implementation_imports
     show BaseDeprecatedMemberUseVerifier;
@@ -62,10 +63,11 @@ class _DeprecatedMemberUseVerifier extends BaseDeprecatedMemberUseVerifier {
     String? message,
   ) {
     var library = element is LibraryElement ? element : element.library;
-    if (library == null ||
-        !_workspacePackage.contains(library.firstFragment.source)) {
-      // In this case, `DEPRECATED_MEMBER_USE` is reported by the analyzer.
-      return;
+    if (library case LibraryElementImpl library) {
+      if (!_workspacePackage.contains(library.source)) {
+        // In this case, `DEPRECATED_MEMBER_USE` is reported by the analyzer.
+        return;
+      }
     }
 
     var normalizedMessage = message?.trim();

pkg/linter/lib/src/rules/use_build_context_synchronously.dart

@@ -1465,10 +1465,7 @@ extension ElementExtension on Element {
         // The BuildContext object is the field on Flutter's State class.
         // This object can only be guarded by async gaps with a mounted
         // check on the State.
-        return enclosingElement.lookUpGetter(
-          name: 'mounted',
-          library: enclosingElement.library,
-        );
+        return enclosingElement.mountedGetter;
       }
     }
 
@@ -1478,12 +1475,16 @@ extension ElementExtension on Element {
       _ => null,
     }?.element;
     if (buildContextElement is InterfaceElement) {
-      return buildContextElement.lookUpGetter(
-        name: 'mounted',
-        library: buildContextElement.library,
-      );
+      return buildContextElement.mountedGetter;
     }
 
     return null;
   }
 }
+
+extension _InterfaceElementExtension on InterfaceElement {
+  GetterElement? get mountedGetter {
+    var result = getInterfaceMember(Name(null, 'mounted'));
+    return result is GetterElement ? result : null;
+  }
+}

pkg/linter/lib/src/util/flutter_utils.dart

@@ -116,7 +116,7 @@ class _Flutter {
 
   /// Whether [element] is exactly the element named [type], from Flutter.
   bool isExactly(InterfaceElement element, String type, Uri uri) =>
-      element.name == type && element.library.firstFragment.source.uri == uri;
+      element.name == type && element.library.uri == uri;
 
   bool isExactWidget(ClassElement element) =>
       isExactly(element, _nameWidget, _uriFramework);
@@ -183,9 +183,7 @@ extension InterfaceElementExtension2 on InterfaceElement? {
   /// Whether this is the exact [type] defined in the file with the given [uri].
   bool _isExactly(String type, Uri uri) {
     var self = this;
-    return self is ClassElement &&
-        self.name == type &&
-        self.firstFragment.libraryFragment.source.uri == uri;
+    return self is ClassElement && self.name == type && self.library.uri == uri;
   }
 
   static bool _hasWidgetAsAscendant(