Revert "[VM/Service] Record timeline events representing completed microtasks"

This reverts commit 22021cc.

Reason for revert: I didn't gate stacktrace collection behind `--profile-microtasks` correctly

Original change's description:
> [VM/Service] Record timeline events representing completed microtasks
>
> TEST=pkg/vm_service/test/timeline_events_for_completed_microtasks_test
>
> CoreLibraryReviewExempt: This CL does not include any core library API
> changes, it only modifies the implementation of microtasks (by
> instrumenting them).
> Change-Id: I54d886db9519c73f9e3218a9cc1c46bc9fe9acc3
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420221
> Commit-Queue: Derek Xu <[email protected]>
> Reviewed-by: Ben Konyi <[email protected]>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I82b4a49764956254c51bd3abfee0cb3cd1b329d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423920
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Jessy Yameogo <[email protected]>
Commit-Queue: Jessy Yameogo <[email protected]>
Auto-Submit: Derek Xu <[email protected]>

Author: derekxu16

pkg/vm_service/test/common/service_test_common.dart

@@ -5,13 +5,11 @@
 library service_test_common;
 
 import 'dart:async';
-import 'dart:collection' show HashMap;
 import 'dart:typed_data';
 
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 import 'package:vm_service/vm_service.dart';
-import 'package:vm_service_protos/vm_service_protos.dart' show DebugAnnotation;
 
 typedef IsolateTest = Future<void> Function(
   VmService service,
@@ -916,19 +914,3 @@ IsolateTest testExpressionEvaluationAndAvailableVariables(
     }
   };
 }
-
-Map<String, String> mapFromListOfDebugAnnotations(
-  List<DebugAnnotation> debugAnnotations,
-) {
-  return HashMap.fromEntries(
-    debugAnnotations.map((a) {
-      if (a.hasStringValue()) {
-        return MapEntry(a.name, a.stringValue);
-      } else if (a.hasLegacyJsonValue()) {
-        return MapEntry(a.name, a.legacyJsonValue);
-      } else {
-        throw 'We should not be writing annotations without values';
-      }
-    }),
-  );
-}

pkg/vm_service/test/get_perfetto_vm_timeline_rpc_test.dart

@@ -5,6 +5,7 @@
 // VMOptions=
 // VMOptions=--intern_strings_when_writing_perfetto_timeline
 
+import 'dart:collection';
 import 'dart:convert';
 import 'dart:developer';
 import 'dart:io' show Platform;
@@ -13,7 +14,6 @@ import 'package:test/test.dart';
 import 'package:vm_service/vm_service.dart' hide Timeline;
 import 'package:vm_service_protos/vm_service_protos.dart';
 
-import 'common/service_test_common.dart' show mapFromListOfDebugAnnotations;
 import 'common/test_helper.dart';
 
 void primeTimeline() {
@@ -143,6 +143,22 @@ List<TrackEvent> extractTrackEventsFromTracePackets(
   return result;
 }
 
+Map<String, String> mapFromListOfDebugAnnotations(
+  List<DebugAnnotation> debugAnnotations,
+) {
+  return HashMap.fromEntries(
+    debugAnnotations.map((a) {
+      if (a.hasStringValue()) {
+        return MapEntry(a.name, a.stringValue);
+      } else if (a.hasLegacyJsonValue()) {
+        return MapEntry(a.name, a.legacyJsonValue);
+      } else {
+        throw 'We should not be writing annotations without values';
+      }
+    }),
+  );
+}
+
 void checkThatAllEventsHaveIsolateNumbers(Iterable<TrackEvent> events) {
   for (final event in events) {
     final debugAnnotations =

pkg/vm_service/test/timeline_events_for_completed_microtasks_test.dart

@@ -5,17 +5,12 @@
 #include "vm/bootstrap_natives.h"
 #include "vm/debugger.h"
 #include "vm/exceptions.h"
-#include "vm/flags.h"
-#include "vm/microtask_mirror_queues.h"
 #include "vm/native_entry.h"
 #include "vm/object_store.h"
 #include "vm/runtime_entry.h"
 
 namespace dart {
 
-// This flag is defined in "vm/microtask_mirror_queues.cc".
-DECLARE_FLAG(bool, profile_microtasks);
-
 DEFINE_NATIVE_ENTRY(AsyncStarMoveNext_debuggerStepCheck, 0, 1) {
 #if !defined(PRODUCT)
   GET_NON_NULL_NATIVE_ARGUMENT(Closure, generator, arguments->NativeArgAt(0));
@@ -61,41 +56,4 @@ DEFINE_NATIVE_ENTRY(SuspendState_instantiateClosureWithFutureTypeArgument,
   return closure.ptr();
 }
 
-DEFINE_NATIVE_ENTRY(MicrotaskMirrorQueue_onScheduleAsyncCallback, 0, 1) {
-#if !defined(PRODUCT)
-  if (FLAG_profile_microtasks) {
-    GET_NON_NULL_NATIVE_ARGUMENT(StackTrace, stack_trace,
-                                 arguments->NativeArgAt(0));
-    MicrotaskMirrorQueues::GetQueue(static_cast<int64_t>(isolate->main_port()))
-        ->OnScheduleAsyncCallback(stack_trace);
-  }
-#endif  // !defined(PRODUCT)
-  return Object::null();
-}
-
-DEFINE_NATIVE_ENTRY(MicrotaskMirrorQueue_onSchedulePriorityAsyncCallback,
-                    0,
-                    0) {
-#if !defined(PRODUCT)
-  if (FLAG_profile_microtasks) {
-    MicrotaskMirrorQueues::GetQueue(static_cast<int64_t>(isolate->main_port()))
-        ->OnSchedulePriorityAsyncCallback();
-  }
-#endif  // !defined(PRODUCT)
-  return Object::null();
-}
-
-DEFINE_NATIVE_ENTRY(MicrotaskMirrorQueue_onAsyncCallbackComplete, 0, 2) {
-#if !defined(PRODUCT)
-  if (FLAG_profile_microtasks) {
-    GET_NON_NULL_NATIVE_ARGUMENT(Integer, start_time,
-                                 arguments->NativeArgAt(0));
-    GET_NON_NULL_NATIVE_ARGUMENT(Integer, end_time, arguments->NativeArgAt(1));
-    MicrotaskMirrorQueues::GetQueue(static_cast<int64_t>(isolate->main_port()))
-        ->OnAsyncCallbackComplete(start_time.Value(), end_time.Value());
-  }
-#endif  // !defined(PRODUCT)
-  return Object::null();
-}
-
 }  // namespace dart

runtime/lib/async.cc

@@ -149,9 +149,6 @@ namespace dart {
   V(Timeline_getTraceClock, 0)                                                 \
   V(Timeline_isDartStreamEnabled, 0)                                           \
   V(Timeline_reportTaskEvent, 5)                                               \
-  V(MicrotaskMirrorQueue_onScheduleAsyncCallback, 1)                           \
-  V(MicrotaskMirrorQueue_onSchedulePriorityAsyncCallback, 0)                   \
-  V(MicrotaskMirrorQueue_onAsyncCallbackComplete, 2)                           \
   V(TypedDataBase_length, 1)                                                   \
   V(TypedDataBase_setClampedRange, 5)                                          \
   V(TypedData_GetFloat32, 2)                                                   \

runtime/vm/bootstrap_natives.h

@@ -33,7 +33,6 @@
 #include "vm/kernel_isolate.h"
 #include "vm/message_handler.h"
 #include "vm/metrics.h"
-#include "vm/microtask_mirror_queues.h"
 #include "vm/native_entry.h"
 #include "vm/native_message_handler.h"
 #include "vm/object.h"
@@ -765,7 +764,6 @@ char* Dart::Cleanup() {
   }
   Timeline::Cleanup();
 #endif
-  NOT_IN_PRODUCT(MicrotaskMirrorQueues::CleanUp());
   Zone::Cleanup();
   Random::Cleanup();
   // Delete the current thread's TLS and set it's TLS to null.