[DAS] Removes Create Class fix at instance method invocation

Fixes: #60955
Change-Id: I1be7564e71edb919c56c6c1fbc282f901f96bab4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435560
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/dart/create_class.dart

@@ -49,6 +49,13 @@ class CreateClass extends MultiCorrectionProducer {
     } else if (targetNode case SimpleIdentifier(
       :var parent,
     ) when parent is! PropertyAccess && parent is! PrefixedIdentifier) {
+      if (parent case MethodInvocation(:var target)) {
+        if (target case SimpleIdentifier(:PrefixElement element)) {
+          prefixElement = element;
+        } else if (target?.staticType != null) {
+          return const [];
+        }
+      }
       className = targetNode.nameOfType ?? targetNode.name;
       requiresConstConstructor |= _requiresConstConstructor(targetNode);
     } else if (targetNode case SimpleIdentifier(

pkg/analysis_server/test/src/services/correction/fix/create_class_test.dart

@@ -25,6 +25,15 @@ class CreateClassLowercaseTest extends FixProcessorTest {
   @override
   FixKind get kind => DartFixKind.CREATE_CLASS_LOWERCASE;
 
+  Future<void> test_instanceMethod_noFix() async {
+    await resolveTestCode('''
+class C {}
+
+String? f(C c) => c.foo();
+''');
+    await assertNoFix();
+  }
+
   Future<void> test_lowercaseAssignment() async {
     await resolveTestCode('''
 void f() {
@@ -73,6 +82,20 @@ class _0newName {
 ''');
   }
 
+  Future<void> test_prefix() async {
+    newFile('$testPackageLibPath/lib.dart', '');
+    await resolveTestCode('''
+import 'lib.dart' as lib;
+
+String? f() => lib.foo();
+''');
+    await assertHasFix('''
+
+class foo {
+}
+''', target: '$testPackageLibPath/lib.dart');
+  }
+
   Future<void> test_startWithDollarSign() async {
     await resolveTestCode(r'''
 void f() {
@@ -454,6 +477,15 @@ class Test {
     assertLinkedGroup(change.linkedEditGroups[0], ['Test ()', 'Test {']);
   }
 
+  Future<void> test_instanceMethod_noFix() async {
+    await resolveTestCode('''
+class C {}
+
+String? f(C c) => c.Foo();
+''');
+    await assertNoFix();
+  }
+
   Future<void> test_itemOfList() async {
     await resolveTestCode('''
 void f() {
@@ -500,6 +532,20 @@ class Test {
     assertLinkedGroup(change.linkedEditGroups[0], ['Test])', 'Test {']);
   }
 
+  Future<void> test_prefix() async {
+    newFile('$testPackageLibPath/lib.dart', '');
+    await resolveTestCode('''
+import 'lib.dart' as lib;
+
+String? f() => lib.Foo();
+''');
+    await assertHasFix('''
+
+class Foo {
+}
+''', target: '$testPackageLibPath/lib.dart');
+  }
+
   Future<void> test_simple() async {
     await resolveTestCode('''
 void f() {