Add experiment keys to experiment-related diagnostics

In a recent discussion we decided to add an `experiment` key to the
entries in the analyzer's `messages.yaml` file with the same semantics
as they have in the front-end messages file. This is an initial attempt
to add them.

I'm reasonably confident that all of the markes diagnostics are related
to the specified experiment, but there might well be others. I'm happy
to update this CL to capture those as well, but we can always add the
map entry later as we discover diagnostics that were missed.

Change-Id: I31ec94bae905828e64a1769fdf905ef7a19a8d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430120
Reviewed-by: Kallen Tu <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: bwilkerson

pkg/analyzer/messages.yaml

@@ -1148,24 +1148,28 @@ CompileTimeErrorCode:
       }
       ```
   AUGMENTATION_EXTENDS_CLAUSE_ALREADY_PRESENT:
+    experiment: augmentations
     problemMessage: The augmentation has an 'extends' clause, but an augmentation target already includes an 'extends' clause and it isn't allowed to be repeated or changed.
     correctionMessage: Try removing the 'extends' clause, either here or in the augmentation target.
     hasPublishedDocs: false
   AUGMENTATION_MODIFIER_EXTRA:
+    experiment: augmentations
     problemMessage: The augmentation has the '{0}' modifier that the declaration doesn't have.
     correctionMessage: Try removing the '{0}' modifier, or adding it to the declaration.
     hasPublishedDocs: false
     comment: |-
       Parameters:
       0: the lexeme of the modifier.
   AUGMENTATION_MODIFIER_MISSING:
+    experiment: augmentations
     problemMessage: The augmentation is missing the '{0}' modifier that the declaration has.
     correctionMessage: Try adding the '{0}' modifier, or removing it from the declaration.
     hasPublishedDocs: false
     comment: |-
       Parameters:
       0: the lexeme of the modifier.
   AUGMENTATION_OF_DIFFERENT_DECLARATION_KIND:
+    experiment: augmentations
     problemMessage: Can't augment a {0} with a {1}.
     correctionMessage: Try changing the augmentation to match the declaration kind.
     hasPublishedDocs: false
@@ -1174,30 +1178,37 @@ CompileTimeErrorCode:
       0: the name of the declaration kind.
       1: the name of the augmentation kind.
   AUGMENTATION_TYPE_PARAMETER_BOUND:
+    experiment: augmentations
     problemMessage: The augmentation type parameter must have the same bound as the corresponding type parameter of the declaration.
     correctionMessage: Try changing the augmentation to match the declaration type parameters.
     hasPublishedDocs: false
   AUGMENTATION_TYPE_PARAMETER_COUNT:
+    experiment: augmentations
     problemMessage: The augmentation must have the same number of type parameters as the declaration.
     correctionMessage: Try changing the augmentation to match the declaration type parameters.
     hasPublishedDocs: false
   AUGMENTATION_TYPE_PARAMETER_NAME:
+    experiment: augmentations
     problemMessage: The augmentation type parameter must have the same name as the corresponding type parameter of the declaration.
     correctionMessage: Try changing the augmentation to match the declaration type parameters.
     hasPublishedDocs: false
   AUGMENTATION_WITHOUT_DECLARATION:
+    experiment: augmentations
     problemMessage: The declaration being augmented doesn't exist.
     correctionMessage: Try changing the augmentation to match an existing declaration.
     hasPublishedDocs: false
   AUGMENTED_EXPRESSION_IS_NOT_SETTER:
+    experiment: augmentations
     problemMessage: The augmented declaration is not a setter, it can't be used to write a value.
     correctionMessage: Try assigning a value to a setter.
     hasPublishedDocs: false
   AUGMENTED_EXPRESSION_IS_SETTER:
+    experiment: augmentations
     problemMessage: The augmented declaration is a setter, it can't be used to read a value.
     correctionMessage: Try assigning a value to the augmented setter.
     hasPublishedDocs: false
   AUGMENTED_EXPRESSION_NOT_OPERATOR:
+    experiment: augmentations
     problemMessage: The enclosing augmentation doesn't augment the operator '{0}'.
     correctionMessage: Try augmenting or invoking the correct operator.
     hasPublishedDocs: false
@@ -3865,10 +3876,12 @@ CompileTimeErrorCode:
       Parameters:
       0: the name of the duplicate entity
   DOT_SHORTHAND_MISSING_CONTEXT:
+    experiment: dot-shorthands
     problemMessage: "A dot shorthand can't be used where there is no context type."
     hasPublishedDocs: false
   DOT_SHORTHAND_UNDEFINED_GETTER:
     sharedName: DOT_SHORTHAND_UNDEFINED_MEMBER
+    experiment: dot-shorthands
     problemMessage: "The static getter '{0}' isn't defined for the context type '{1}'."
     correctionMessage: "Try correcting the name to the name of an existing static getter, or defining a getter or field named '{0}'."
     hasPublishedDocs: false
@@ -3878,6 +3891,7 @@ CompileTimeErrorCode:
       1: the name of the enclosing type where the getter is being looked for
   DOT_SHORTHAND_UNDEFINED_INVOCATION:
     sharedName: DOT_SHORTHAND_UNDEFINED_MEMBER
+    experiment: dot-shorthands
     problemMessage: "The static method or constructor '{0}' isn't defined for the type '{1}'."
     correctionMessage: "Try correcting the name to the name of an existing static method or constructor, or defining a static method or constructor named '{0}'."
     hasPublishedDocs: false
@@ -18402,6 +18416,7 @@ CompileTimeErrorCode:
       ```
   WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR:
     sharedName: WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR
+    experiment: dot-shorthands
     problemMessage: "The constructor '{0}.{1}` doesn't have type parameters."
     correctionMessage: Try removing the type arguments, or adding a class name, followed by the type arguments, then the constructor name.
     hasPublishedDocs: true
@@ -21500,6 +21515,7 @@ ParserErrorCode:
     correctionMessage: "Try removing the keyword 'covariant'."
     hasPublishedDocs: false
   DECLARATION_NAMED_AUGMENTED_INSIDE_AUGMENTATION:
+    experiment: augmentations
     problemMessage: "The identifier 'augmented' has a special meaning inside augmenting declarations."
     correctionMessage: "Try using a different name."
     hasPublishedDocs: false
@@ -21665,6 +21681,7 @@ ParserErrorCode:
     correctionMessage: Try converting the body to a block.
     hasPublishedDocs: false
   INVALID_USE_OF_IDENTIFIER_AUGMENTED:
+    experiment: augmentations
     problemMessage: The identifier 'augmented' can only be used to reference the augmented declaration inside an augmentation.
     correctionMessage: Try using a different identifier.
     hasPublishedDocs: false