[analysis_server] Dot shorthands: Update ReplaceFinalWithConst fix.

Adds an extra dot shorthand constructor invocation case to the
`ReplaceFinalWithConst` fix. Added relevant tests.

Bug: #60994
Change-Id: I23d9882ae5b8633a29f6d50a40de35d80edb2a2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442161
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analysis_server/lib/src/services/correction/dart/replace_final_with_const.dart

@@ -38,8 +38,12 @@ class ReplaceFinalWithConst extends ResolvedCorrectionProducer {
         var initializer = variable.initializer;
         if (initializer != null) {
           Token? constToken;
-          if (initializer is InstanceCreationExpression) {
-            constToken = initializer.keyword;
+          if (initializer
+              case InstanceCreationExpression(:var keyword) ||
+                  DotShorthandConstructorInvocation(
+                    constKeyword: Token? keyword,
+                  )) {
+            constToken = keyword;
           } else if (initializer is TypedLiteral) {
             constToken = initializer.constKeyword;
           }

pkg/analysis_server/test/src/services/correction/fix/replace_final_with_const_test.dart

@@ -41,6 +41,51 @@ class ReplaceFinalWithConstTest extends FixProcessorLintTest {
   @override
   String get lintCode => LintNames.prefer_const_declarations;
 
+  Future<void> test_const_dotShorthand_multiple() async {
+    await resolveTestCode('''
+class A {
+  const A.named();
+}
+final A a1 = const .named(), a2 = const .named();
+''');
+    await assertHasFix('''
+class A {
+  const A.named();
+}
+const A a1 = .named(), a2 = .named();
+''');
+  }
+
+  Future<void> test_const_dotShorthand_named() async {
+    await resolveTestCode('''
+class A {
+  const A.named();
+}
+final A a = const .named();
+''');
+    await assertHasFix('''
+class A {
+  const A.named();
+}
+const A a = .named();
+''');
+  }
+
+  Future<void> test_const_dotShorthand_unnamed() async {
+    await resolveTestCode('''
+class A {
+  const A();
+}
+final A a = const .new();
+''');
+    await assertHasFix('''
+class A {
+  const A();
+}
+const A a = .new();
+''');
+  }
+
   Future<void> test_const_instanceCreation() async {
     await resolveTestCode('''
 class A {