Implement a visitor method for DotShorthandPropertyAccess to ExitDetector.

Change-Id: I98a3ce4126d2ca7e7743ba788ec1dc9b580b54a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457781
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: fshcheglov

pkg/analyzer/lib/src/dart/resolver/exit_detector.dart

@@ -186,6 +186,11 @@ class ExitDetector extends GeneralizingAstVisitor<bool> {
     return _nodeExits(node.argumentList);
   }
 
+  @override
+  bool visitDotShorthandPropertyAccess(DotShorthandPropertyAccess node) {
+    return _elementExits(node.propertyName.element);
+  }
+
   @override
   bool visitEmptyStatement(EmptyStatement node) => false;
 

pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart

@@ -1027,6 +1027,28 @@ void f() {
 ''', 0);
   }
 
+  test_dotShorthandPropertyAccess_getterReturnsNever() async {
+    await _assertNthStatementExits(r'''
+class C {
+  static Never get foo => throw 42;
+}
+void f() {
+  C _ = .foo;
+}
+''', 0);
+  }
+
+  test_dotShorthandPropertyAccess_noExit() async {
+    await _assertNthStatementDoesNotExit(r'''
+class C {
+  static C get foo => C();
+}
+void f() {
+  C _ = .foo;
+}
+''', 0);
+  }
+
   test_forStatement_implicitTrue_breakWithLabel() async {
     await _assertNthStatementDoesNotExit(r'''
 void f() {