[dart2js] Skip interop extension type object literal constructors during serialization

Fixes #57008

dart2js was mistakenly assuming the generated procedures for these
constructors are top-level external interop members and accidentally
generating invalid code. We should skip serializing these procedures.
This should be safe since any invocation of these procedures are
transformed in visitStaticInvocation.

Change-Id: If11c718bea8447b60de00b73f328a3cdd5544bda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393001
Auto-Submit: Srujan Gaddam <[email protected]>
Commit-Queue: Srujan Gaddam <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>

Author: srujzs

pkg/compiler/lib/src/ssa/builder.dart

@@ -440,6 +440,16 @@ class KernelSsaGraphBuilder extends ir.VisitorDefault<void>
           ir.Node target = definition.node;
           if (target is ir.Procedure) {
             if (target.isExternal) {
+              // Skip interop extension type object literal constructors as
+              // that's handled within `visitStaticInvocation`.
+              // TODO(54968): We should handle the lowering for object literal
+              // constructors in the interop transformer somehow instead and
+              // avoid assuming all such members are object literal constructors
+              // or otherwise paying the cost to verify by indexing extension
+              // types.
+              final isObjectLiteralConstructor = target.isExtensionTypeMember &&
+                  target.function.namedParameters.isNotEmpty;
+              if (isObjectLiteralConstructor) return null;
               _buildExternalFunctionNode(targetElement as FunctionEntity,
                   _ensureDefaultArgumentValues(target.function));
             } else {

tests/modular/js_interop_object_literal_constructor_with_extension_types/def.dart

@@ -0,0 +1,9 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:js_interop';
+
+extension type ObjectLiteral._(JSObject _) implements JSObject {
+  external factory ObjectLiteral({int foo});
+}

tests/modular/js_interop_object_literal_constructor_with_extension_types/main.dart

@@ -0,0 +1,9 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'def.dart';
+
+void main() {
+  ObjectLiteral(foo: 0);
+}

tests/modular/js_interop_object_literal_constructor_with_extension_types/modules.yaml

@@ -0,0 +1,9 @@
+# Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+# for details. All rights reserved. Use of this source code is governed by a
+# BSD-style license that can be found in the LICENSE file.
+#
+# Regression test for https://github.com/dart-lang/sdk/issues/57008: Test that
+# we skip generated procedures for object literal constructors when we serialize
+# the codegen. All invocations of such procedures are transformed.
+dependencies:
+  main: def